Changeset View
Changeset View
Standalone View
Standalone View
source/lobby/glooxwrapper/glooxwrapper.h
Show First 20 Lines • Show All 631 Lines • ▼ Show 20 Lines | protected: | ||||
gloox::Jingle::Session* m_Wrapped; | gloox::Jingle::Session* m_Wrapped; | ||||
bool m_Owned; | bool m_Owned; | ||||
public: | public: | ||||
class GLOOXWRAPPER_API Jingle | class GLOOXWRAPPER_API Jingle | ||||
{ | { | ||||
private: | private: | ||||
const gloox::Jingle::Session::Jingle* m_Wrapped; | const gloox::Jingle::Session::Jingle* m_Wrapped; | ||||
bool m_Owned; | |||||
public: | public: | ||||
Jingle(const gloox::Jingle::Session::Jingle* wrapped, bool owned) : m_Wrapped(wrapped), m_Owned(owned) {} | Jingle(const gloox::Jingle::Session::Jingle* wrapped, bool UNUSED(owned)) : m_Wrapped(wrapped) {} | ||||
leper: This seems strange. I suspect not actually handling this properlymight make make us leak memory… | |||||
elexisAuthorUnsubmitted Not Done Inline ActionsPerhaps nicer in a separate memory leak investigation patch if we can fix the other two things beforehand elexis: Perhaps nicer in a separate memory leak investigation patch if we can fix the other two things… | |||||
const PluginList plugins() const; | const PluginList plugins() const; | ||||
ICEUDP::Candidate getCandidate() const; | ICEUDP::Candidate getCandidate() const; | ||||
}; | }; | ||||
Session(gloox::Jingle::Session* wrapped, bool owned) : m_Wrapped(wrapped), m_Owned(owned) {} | Session(gloox::Jingle::Session* wrapped, bool owned) : m_Wrapped(wrapped), m_Owned(owned) {} | ||||
Show All 28 Lines |
Wildfire Games · Phabricator
This seems strange. I suspect not actually handling this properlymight make make us leak memory (to be more specific m_Wrapped).