Differential D1269 Diff 5592 binaries/data/mods/public/gui/session/selection_panels_middle/unit_commands.xml
Changeset View
Changeset View
Standalone View
Standalone View
binaries/data/mods/public/gui/session/selection_panels_middle/unit_commands.xml
<?xml version="1.0" encoding="utf-8"?> | <?xml version="1.0" encoding="utf-8"?> | ||||
<!-- Unit Commands --> | <!-- Unit Commands --> | ||||
<object name="unitCommandPanel" | <object name="unitCommandPanel" | ||||
size="0 100%-36 100% 100%-4" | size="0 100%-36 100% 100%-4" | ||||
type="image" | type="image" | ||||
z="30" | z="30" | ||||
> | > | ||||
<object size="0 1 100% 100%"> | <object size="0 1 100% 100%"> | ||||
<repeat count="6"> | <repeat count="18"> | ||||
<object name="unitCommandButton[n]" hidden="true" style="iconButton" type="button" size="0 0 32 32" tooltip_style="sessionToolTipBottomBold"> | <object name="unitCommandButton[n]" hidden="true" style="iconButton" type="button" size="0 0 32 32" tooltip_style="sessionToolTipBottomBold"> | ||||
<object name="unitCommandIcon[n]" ghost="true" type="image" size="0 0 100% 100%" style="commandIcon"/> | <object name="unitCommandIcon[n]" ghost="true" type="image" size="0 0 100% 100%" style="commandIcon"/> | ||||
<object name="unitCommandCount[n]" ghost="true" style="groupIconsText" type="text" size="0 0 100% 100%"/> | <object name="unitCommandCount[n]" ghost="true" style="groupIconsText" type="text" size="0 0 100% 100%"/> | ||||
</object> | </object> | ||||
</repeat> | </repeat> | ||||
<object name="unitCommandArrowN" hidden="false" style="iconButton" type="button" size="100%-15 0 100%-5 32" tooltip_style="sessionToolTipBottomBold"> | |||||
bb: they end up as black squares now, some arrow would look better (I know there are space problems. | |||||
ImarokAuthorUnsubmitted Not Done Inline Actions
See the summary of this diff:
Imarok: > they end up as black squares now, some arrow would look better (I know there are space… | |||||
<action on="Press">++g_OpenCommandPage;</action> | |||||
bbUnsubmitted Done Inline ActionsWe rely here on the onTick/onSimupdates for updating the buttons and those can take an arbitrary amount of time, instead of doing it directly by updateSelectionDetails bb: We rely here on the onTick/onSimupdates for updating the buttons and those can take an… | |||||
</object> | |||||
<object name="unitCommandArrowP" hidden="true" style="iconButton" type="button" size="5 0 14 32" tooltip_style="sessionToolTipBottomBold"> | |||||
<action on="Press">--g_OpenCommandPage;</action> | |||||
Not Done Inline Actionsinstead of hardcoding two pages, perhaps put that in a repeat aswell, and then have every page with 6 items bb: instead of hardcoding two pages, perhaps put that in a repeat aswell, and then have every page… | |||||
</object> | |||||
</object> | </object> | ||||
<!-- shading for unit commands area --> | <!-- shading for unit commands area --> | ||||
<object z="50" size="4 100% 100%-4 100%" ghost="true" type="image" sprite="bottomEdgedPanelShader"/> | <object z="50" size="4 100% 100%-4 100%" ghost="true" type="image" sprite="bottomEdgedPanelShader"/> | ||||
Done Inline ActionsSince the OOP rewrite, maybe this can be done nicely in the JS? Stan: Since the OOP rewrite, maybe this can be done nicely in the JS? | |||||
Done Inline ActionsGood question Imarok: Good question | |||||
Done Inline ActionsHmm I don't see how this could benefit from doing it in js only. Imarok: Hmm I don't see how this could benefit from doing it in js only. | |||||
</object> | </object> | ||||
Wildfire Games · Phabricator
they end up as black squares now, some arrow would look better (I know there are space problems...)