Page Menu
Home
Wildfire Games
Search
Configure Global Search
Log In
Differential
D1274
Diff 5770
source/lib/status.h
Changeset View
The do while loop is placebo?
For the current behavior of the fucntion: According to FAIL = -1 and OK = 0, it is RETURN_FAIL_IF_NOT_OK, and -1 should be FAIL then.
On the other hand one may consider the enum numbers to be arbitrary, i .e. coincidental that it is 0. The return value of the microsoft function is not linked to INFO::OK, so it seems wrong to put this function here suggesting that it checks for a status code when it checks for a ms function return value.
Perhaps just using if !x() return or if !x() && !y() && !z()) return ... or return x() && y() && z(); would avoid this.