Changeset View
Changeset View
Standalone View
Standalone View
binaries/data/mods/public/gui/session/session.js
const g_IsReplay = Engine.IsVisualReplay(); | const g_IsReplay = Engine.IsVisualReplay(); | ||||
const g_CivData = loadCivData(false, true); | const g_CivData = loadCivData(false, true); | ||||
const g_Ceasefire = prepareForDropdown(g_Settings && g_Settings.Ceasefire); | const g_Ceasefire = prepareForDropdown(g_Settings && g_Settings.Ceasefire); | ||||
const g_MapSizes = prepareForDropdown(g_Settings && g_Settings.MapSizes); | const g_MapSizes = prepareForDropdown(g_Settings && g_Settings.MapSizes); | ||||
const g_MapTypes = prepareForDropdown(g_Settings && g_Settings.MapTypes); | const g_MapTypes = prepareForDropdown(g_Settings && g_Settings.MapTypes); | ||||
const g_PopulationCapacities = prepareForDropdown(g_Settings && g_Settings.PopulationCapacities); | const g_PopulationCapacities = prepareForDropdown(g_Settings && g_Settings.PopulationCapacities); | ||||
const g_StartingResources = prepareForDropdown(g_Settings && g_Settings.StartingResources); | const g_StartingResources = prepareForDropdown(g_Settings && g_Settings.StartingResources); | ||||
const g_VictoryConditions = prepareForDropdown(g_Settings && g_Settings.VictoryConditions); | |||||
const g_VictoryDurations = prepareForDropdown(g_Settings && g_Settings.VictoryDurations); | const g_VictoryDurations = prepareForDropdown(g_Settings && g_Settings.VictoryDurations); | ||||
const g_VictoryConditions = g_Settings && g_Settings.VictoryConditions; | |||||
elexis: `|| []` sounds unneeded. if g_Settings is undefined, it should end immediately (hell broke… | |||||
Not Done Inline Actionssame for gamesetup bb: same for gamesetup | |||||
var g_GameSpeeds; | var g_GameSpeeds; | ||||
Done Inline ActionsStill arguing for const\nconst\n\nvar elexis: Still arguing for `const\nconst\n\nvar` | |||||
Not Done Inline Actions(not still, other location but same code, don't yell about nuking duplication) bb: (not still, other location but same code, don't yell about nuking duplication) | |||||
/** | /** | ||||
* Whether to display diplomacy colors (where players see self/ally/neutral/enemy each in different colors and | * Whether to display diplomacy colors (where players see self/ally/neutral/enemy each in different colors and | ||||
* observers see each team in a different color) or regular player colors. | * observers see each team in a different color) or regular player colors. | ||||
*/ | */ | ||||
var g_DiplomacyColorsToggle = false; | var g_DiplomacyColorsToggle = false; | ||||
/** | /** | ||||
▲ Show 20 Lines • Show All 1,751 Lines • Show Last 20 Lines |
Wildfire Games · Phabricator
|| [] sounds unneeded. if g_Settings is undefined, it should end immediately (hell broke loose already).