Differential D92 Diff 346 binaries/data/mods/public/simulation/templates/template_structure_defense_wall_gate.xml

Changeset View

Standalone View

binaries/data/mods/public/simulation/templates/template_structure_defense_wall_gate.xml

	<?xml version="1.0" encoding="utf-8"?>			<?xml version="1.0" encoding="utf-8"?>
	<Entity parent="template_structure_defense_wall_long">			<Entity parent="template_structure_defense_wall_long">
	<Auras disable=""/>			<Auras disable=""/>
				<!-- We don't disable the Cost component, although gates cannot be built directly, as Cost/BuildTime is required to prevent instantaneous repair -->
	<GarrisonHolder disable=""/>			<GarrisonHolder disable=""/>
				fatherbushidoUnsubmitted Not Done Inline Actions Not sure if we should nuke that. The patch needs that to work? fatherbushido: Not sure if we should nuke that. The patch needs that to work?
				fatherbushidoUnsubmitted Not Done Inline Actions I mean, imo we could keep the own resources cost (even if it's not use). If the patch needs it to be nuked, imo it's bad (we could add another way to check that). fatherbushido: I mean, imo we could keep the own resources cost (even if it's not use). If the patch needs it…
	<Gate>			<Gate>
	<PassRange>20</PassRange>			<PassRange>20</PassRange>
	</Gate>			</Gate>
				bbUnsubmitted Not Done Inline Actions This is ugly, better remove the Cost component from gates completely. bb: This is ugly, better remove the Cost component from gates completely.
				fatherbushidoUnsubmitted Not Done Inline Actions The entity itself can/must have his own Cost. Moreover, the time at least is needed for the repair rate. fatherbushido: The entity itself can/must have his own Cost. Moreover, the time at least is needed for the…
				elexisUnsubmitted Done Inline Actions Since that question was asked by me in the ticket as well, adding a XML comment might be appropriate. elexis: Since that question was asked by me in the ticket as well, adding a XML comment might be…
				fatherbushidoUnsubmitted Not Done Inline Actions I could live with such an xml comment, and I understand why you want to add it but again it seems imo pointless (perhaps also a matter of taste). We must have in mind that the intrinsic cost of an entity is something different (can even be not correlated) to the upgrade costs. An entity can also have a cost component even if in common games (rms map) that entity is not in any Builder / ProductionQueue list (see other/celt_longhouse.xml...) Moreover here, we just have to not touch at it, so how would look like such a comment? "Here you want perhaps remove the cost entry but don't do it?". ;-) fatherbushido: I could live with such an xml comment, and I understand why you want to add it but again it…
				elexisUnsubmitted Not Done Inline Actions `<!-- Inherit Cost, as the BuildTime determines the repair rate ->` just to avoid further repetitions of the question. I could also live with not adding it though ;) elexis: `<!-- Inherit Cost, as the BuildTime determines the repair rate ->` just to avoid further…
				fatherbushidoUnsubmitted Not Done Inline Actions sure, I would emphasize that it's also bad to remove (or to have to remove) the not time ressource cost. fatherbushido: sure, I would emphasize that it's also bad to remove (or to have to remove) the not time…
	<Identity>			<Identity>
	<GenericName>City Gate</GenericName>			<GenericName>City Gate</GenericName>
	<Tooltip>Allow units access through a city wall. Can be locked to prevent access.</Tooltip>			<Tooltip>Allow units access through a city wall. Can be locked to prevent access.</Tooltip>
	<Classes datatype="tokens">Gates</Classes>			<Classes datatype="tokens">Gates</Classes>
	<Icon>structures/gate.png</Icon>			<Icon>structures/gate.png</Icon>
	<RequiredTechnology>phase_town</RequiredTechnology>			<RequiredTechnology>phase_town</RequiredTechnology>
	</Identity>			</Identity>
	<Obstruction>			<Obstruction>
	Show All 23 Lines