Differential D104 Diff 378 binaries/data/mods/public/gui/gamesetup/gamesetup.js

Changeset View

Standalone View

binaries/data/mods/public/gui/gamesetup/gamesetup.js

Context not available.
	"ExploreMap": "exploreMap",	"ExploreMap": "exploreMap",
	"DisableTreasures": "disableTreasures",	"DisableTreasures": "disableTreasures",
	"LockTeams": "lockTeams",	"LockTeams": "lockTeams",
	"LastManStanding" : "lastManStanding",	"LastManStanding": "lastManStanding",
		"RegicideGarrison": "regicideGarrison",
	"CheatsEnabled": "enableCheats"	"CheatsEnabled": "enableCheats"
	};	};

		elexisUnsubmitted Not Done Inline Actions (This will keep the setting saved even if the victory condition is changed again, but fixing this is out-of-scope as it isn't trivial.) elexis: (This will keep the setting saved even if the victory condition is changed again, but fixing…
		SandaracAuthorUnsubmitted Not Done Inline Actions (Yes, also an issue for `RelicCount` and `VictoryDuration`, and it's not so nice when these are written to the commands.txt for no reason.) Sandarac: (Yes, also an issue for `RelicCount` and `VictoryDuration`, and it's not so nice when these are…
Context not available.
	{	{
	delete g_GameAttributes.settings.WonderDuration;	delete g_GameAttributes.settings.WonderDuration;
	delete g_GameAttributes.settings.LastManStanding;	delete g_GameAttributes.settings.LastManStanding;
		delete g_GameAttributes.settings.RegicideGarrison;
		leperUnsubmitted Not Done Inline Actions `delete` is slow and messes up some structure information internally, if we have to do that (which I think we do here, but this diff is lacking context) we might want to reorder the structure so we delete the last property added (or defined). leper: `delete` is slow and messes up some structure information internally, if we have to do that…
		elexisUnsubmitted Not Done Inline Actions Context should be clear, when changing the map, these settings can be persisted unless it is a scenario map. I'm not aware of any other statement that removes a property (and not only set it to undefined) without reconstructing the entire object. Using an array instead of an object might work, but wouldn't look too clean (so there should be a good reason to do so). What is the messing up of internal structures? Couldn't find any edge case relevant to this object in https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/delete elexis: Context should be clear, when changing the map, these settings can be persisted unless it is a…
	}	}

	if (mapSettings.PlayerData)	if (mapSettings.PlayerData)
Context not available.
	setGUIBoolean("revealMap", "revealMapText", !!mapSettings.RevealMap);	setGUIBoolean("revealMap", "revealMapText", !!mapSettings.RevealMap);
	setGUIBoolean("lockTeams", "lockTeamsText", !!mapSettings.LockTeams);	setGUIBoolean("lockTeams", "lockTeamsText", !!mapSettings.LockTeams);
	setGUIBoolean("lastManStanding", "lastManStandingText", !!mapSettings.LastManStanding);	setGUIBoolean("lastManStanding", "lastManStandingText", !!mapSettings.LastManStanding);
		setGUIBoolean("regicideGarrison", "regicideGarrisonText", !!mapSettings.RegicideGarrison);
	setGUIBoolean("enableRating", "enableRatingText", !!mapSettings.RatingEnabled);	setGUIBoolean("enableRating", "enableRatingText", !!mapSettings.RatingEnabled);

	Engine.GetGUIObjectByName("optionWonderDuration").hidden =	Engine.GetGUIObjectByName("optionWonderDuration").hidden =
	g_GameAttributes.settings.GameType &&	g_GameAttributes.settings.GameType &&
	g_GameAttributes.settings.GameType != "wonder";	g_GameAttributes.settings.GameType != "wonder";
		Engine.GetGUIObjectByName("optionRegicideGarrison").hidden =
		g_GameAttributes.settings.GameType &&
		g_GameAttributes.settings.GameType != "regicide";

	Engine.GetGUIObjectByName("cheatWarningText").hidden = !g_IsNetworked \|\| !mapSettings.CheatsEnabled;	Engine.GetGUIObjectByName("cheatWarningText").hidden = !g_IsNetworked \|\| !mapSettings.CheatsEnabled;

Context not available.

	for (let ctrl of ["victoryCondition", "wonderDuration", "populationCap",	for (let ctrl of ["victoryCondition", "wonderDuration", "populationCap",
	"startingResources", "ceasefire", "revealMap",	"startingResources", "ceasefire", "revealMap",
	"exploreMap", "disableTreasures", "lockTeams", "lastManStanding"])	"exploreMap", "disableTreasures", "lockTeams",
		"lastManStanding", "regicideGarrison"])
	hideControl(ctrl, ctrl + "Text", notScenario);	hideControl(ctrl, ctrl + "Text", notScenario);

	Engine.GetGUIObjectByName("civResetButton").hidden = !notScenario;	Engine.GetGUIObjectByName("civResetButton").hidden = !notScenario;
Context not available.
		elexisUnsubmitted Not Done Inline Actions (Correct, must be in this check because it's a user setting, as opposed to the properties deleted in the loop above.) elexis: (Correct, must be in this check because it's a user setting, as opposed to the properties…