Differential D1029 Diff 6423 source/ps/scripting/JSInterface_Mod.cpp

Changeset View

Standalone View

source/ps/scripting/JSInterface_Mod.cpp

/* Copyright (C) 2018 Wildfire Games.		/* Copyright (C) 2018 Wildfire Games.
* This file is part of 0 A.D.		* This file is part of 0 A.D.
*		*
* 0 A.D. is free software: you can redistribute it and/or modify		* 0 A.D. is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by		* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 2 of the License, or		* the Free Software Foundation, either version 2 of the License, or
* (at your option) any later version.		* (at your option) any later version.
*		*
* 0 A.D. is distributed in the hope that it will be useful,		* 0 A.D. is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of		* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.		* GNU General Public License for more details.
*		*
* You should have received a copy of the GNU General Public License		* You should have received a copy of the GNU General Public License
* along with 0 A.D. If not, see <http://www.gnu.org/licenses/>.		* along with 0 A.D. If not, see <http://www.gnu.org/licenses/>.
*/		*/
		leperUnsubmitted Not Done Inline Actions I might have mentioned it elsewhere, but given a few "contributions" to this thing since I last touched it, I'd still like to see this under a license that prefers distribution. leper: I might have mentioned it elsewhere, but given a few "contributions" to this thing since I last…
		ItmsAuthorUnsubmitted Not Done Inline Actions That shouldn't be a problem, but you are talking about the two `ModIo` source files, in order to allow others to use our mod.io API code, right? Itms: That shouldn't be a problem, but you are talking about the two `ModIo` source files, in order…

#include "precompiled.h"		#include "precompiled.h"

#include "ps/scripting/JSInterface_Mod.h"		#include "JSInterface_Mod.h"
		leperUnsubmitted Done Inline Actions Why? leper: Why?
		ItmsAuthorUnsubmitted Not Done Inline Actions I thought you were following the convention from your comments above. This is it. Itms: I thought you were following the convention from your comments above. This is it.
		leperUnsubmitted Not Done Inline Actions I'm quite certain I didn't have a TODO comment here about messing up includes. leper: I'm quite certain I didn't have a TODO comment here about messing up includes.
		leperUnsubmitted Not Done Inline Actions See elsewhere, still why and to be a little less obscure, WTH? leper: See elsewhere, still why and to be a little less obscure, WTH?
		ItmsAuthorUnsubmitted Not Done Inline Actions Source files and their corresponding header will always move together, no? It's just style here to my eyes. Itms: Source files and their corresponding header will always move together, no? It's just style here…

		#include "ps/CLogger.h"
#include "ps/Mod.h"		#include "ps/Mod.h"
		#include "ps/ModIo.h"

extern void restart_engine();		extern void restart_engine();

JS::Value JSI_Mod::GetEngineInfo(ScriptInterface::CxPrivate* pCxPrivate)		JS::Value JSI_Mod::GetEngineInfo(ScriptInterface::CxPrivate* pCxPrivate)
{		{
return Mod::GetEngineInfo(*(pCxPrivate->pScriptInterface));		return Mod::GetEngineInfo(*(pCxPrivate->pScriptInterface));
}		}

Show All 17 Lines	void JSI_Mod::RestartEngine(ScriptInterface::CxPrivate* UNUSED(pCxPrivate))
restart_engine();		restart_engine();
}		}

void JSI_Mod::SetMods(ScriptInterface::CxPrivate* UNUSED(pCxPrivate), const std::vector<CStr>& mods)		void JSI_Mod::SetMods(ScriptInterface::CxPrivate* UNUSED(pCxPrivate), const std::vector<CStr>& mods)
{		{
g_modsLoaded = mods;		g_modsLoaded = mods;
}		}

		void JSI_Mod::ModIoStartGetGameId(ScriptInterface::CxPrivate* UNUSED(pCxPrivate))
		{
		if (!g_ModIo)
		g_ModIo = new ModIo();

		ENSURE(g_ModIo);

		g_ModIo->StartGetGameId();
		}

		void JSI_Mod::ModIoStartListMods(ScriptInterface::CxPrivate* UNUSED(pCxPrivate))
		{
		if (!g_ModIo)
		{
		LOGERROR("ModIoStartListMods called before ModIoStartGetGameId");
		return;
		}

		g_ModIo->StartListMods();
		}

		void JSI_Mod::ModIoStartDownloadMod(ScriptInterface::CxPrivate* UNUSED(pCxPrivate), uint32_t idx)
		{
		if (!g_ModIo)
		elexisUnsubmitted Not Done Inline Actions See `VisualReplay::GetReplays` for Imaroks example how to create an array in c++ without calling JS functions like this. elexis: See `VisualReplay::GetReplays` for Imaroks example how to create an array in c++ without…
		elexisUnsubmitted Not Done Inline Actions The interface should be minimized. elexis: The interface should be minimized.
		{
		LOGERROR("ModIoStartDownloadMod called before ModIoStartGetGameId");
		return;
		}

		g_ModIo->StartDownloadMod(idx);
		}

		bool JSI_Mod::ModIoAdvanceRequest(ScriptInterface::CxPrivate* pCxPrivate)
		elexisUnsubmitted Done Inline Actions ENSURE would be the common solution elexis: ENSURE would be the common solution
		leperUnsubmitted Not Done Inline Actions Because having a nice way for a user to make the game running in full screen stop responding because it's now waiting for input for the debugger prompt is great usability. leper: Because having a nice way for a user to make the game running in full screen stop responding…
		{
		if (!g_ModIo)
		{
		LOGERROR("ModIoAdvanceRequest called before ModIoGetMods");
		return false;
		}

		ScriptInterface* scriptInterface = pCxPrivate->pScriptInterface;
		return g_ModIo->AdvanceRequest(*scriptInterface);
		}

		void JSI_Mod::ModIoCancelRequest(ScriptInterface::CxPrivate* UNUSED(pCxPrivate))
		{
		if (!g_ModIo)
		{
		LOGERROR("ModIoCancelRequest called before ModIoGetMods");
		return;
		}

		g_ModIo->CancelRequest();
		}

		JS::Value JSI_Mod::ModIoGetMods(ScriptInterface::CxPrivate* pCxPrivate)
		{
		if (!g_ModIo)
		{
		LOGERROR("ModIoGetMods called before ModIoStartGetGameId");
		return JS::NullValue();
		}

		ScriptInterface* scriptInterface = pCxPrivate->pScriptInterface;
		JSContext* cx = scriptInterface->GetContext();
		JSAutoRequest rq(cx);

		const std::vector<ModIoModData>& availableMods = g_ModIo->GetMods();

		JS::RootedObject mods(cx, JS_NewArrayObject(cx, availableMods.size()));
		if (!mods)
		return JS::NullValue();

		u32 i = 0;
		for (const ModIoModData& mod : availableMods)
		{
		JS::RootedValue m(cx, JS::ObjectValue(*JS_NewPlainObject(cx)));
		for (const std::pair<std::string, std::string>& prop : mod.properties)
		scriptInterface->SetProperty(m, prop.first.c_str(), prop.second, true);

		scriptInterface->SetProperty(m, "dependencies", mod.dependencies, true);

		JS_SetElement(cx, mods, i++, m);
		}

		return JS::ObjectValue(*mods);
		}

		JS::Value JSI_Mod::ModIoGetDownloadProgress(ScriptInterface::CxPrivate* pCxPrivate)
		leperUnsubmitted Done Inline Actions Will probably be a nice candidate for `constexpr` at some point, similar to other const things in the ModIo implementation. Could also be const char , but that shouldn't really make any noticable difference here. Or unordered_map, since nothing seems to require any order here. leper:* Will probably be a nice candidate for `constexpr` at some point, similar to other const things…
		ItmsAuthorUnsubmitted Not Done Inline Actions Fixed with `unordered_map` locally. Itms: Fixed with `unordered_map` locally.
		{
		if (!g_ModIo)
		{
		LOGERROR("ModIoGetDownloadProgress called before ModIoGetMods");
		return JS::NullValue();
		}

		ScriptInterface* scriptInterface = pCxPrivate->pScriptInterface;
		JSContext* cx = scriptInterface->GetContext();
		JSAutoRequest rq(cx);

		const DownloadProgressData& downloadProgressData = g_ModIo->GetDownloadProgress();

		JS::RootedValue progressData(cx, JS::ObjectValue(*JS_NewPlainObject(cx)));
		leperUnsubmitted Not Done Inline Actions This block seems ugly. leper: This block seems ugly.
		leperUnsubmitted Not Done Inline Actions And given that there is a huge fancy struct I'm somewhat surprised that this code reads as if one would use a pair or similar. leper: And given that there is a huge fancy struct I'm somewhat surprised that this code reads as if…
		ItmsAuthorUnsubmitted Not Done Inline Actions I'm sorry I really don't see it. Could you give an example? Itms: I'm sorry I really don't see it. Could you give an example?
		leperUnsubmitted Not Done Inline Actions If we have a public definiton of a type, why not also have a public conversion function for that type, instead of having one line for each of those in here? (hint, the block starts here.) leper: If we have a public definiton of a type, why not also have a public conversion function for…
		scriptInterface->SetProperty(progressData, "error", downloadProgressData.error, true);
		scriptInterface->SetProperty(progressData, "progress", downloadProgressData.progress, true);
		scriptInterface->SetProperty(progressData, "status", downloadProgressData.StringStatus(), true);

		return progressData;
		}

void JSI_Mod::RegisterScriptFunctions(const ScriptInterface& scriptInterface)		void JSI_Mod::RegisterScriptFunctions(const ScriptInterface& scriptInterface)
		leperUnsubmitted Done Inline Actions Why two? leper: Why two?
{		{
scriptInterface.RegisterFunction<JS::Value, &GetEngineInfo>("GetEngineInfo");		scriptInterface.RegisterFunction<JS::Value, &GetEngineInfo>("GetEngineInfo");
scriptInterface.RegisterFunction<JS::Value, &JSI_Mod::GetAvailableMods>("GetAvailableMods");		scriptInterface.RegisterFunction<JS::Value, &JSI_Mod::GetAvailableMods>("GetAvailableMods");
scriptInterface.RegisterFunction<void, &JSI_Mod::RestartEngine>("RestartEngine");		scriptInterface.RegisterFunction<void, &JSI_Mod::RestartEngine>("RestartEngine");
scriptInterface.RegisterFunction<void, std::vector<CStr>, &JSI_Mod::SetMods>("SetMods");		scriptInterface.RegisterFunction<void, std::vector<CStr>, &JSI_Mod::SetMods>("SetMods");

		scriptInterface.RegisterFunction<void, &JSI_Mod::ModIoStartGetGameId>("ModIoStartGetGameId");
		scriptInterface.RegisterFunction<void, &JSI_Mod::ModIoStartListMods>("ModIoStartListMods");
		scriptInterface.RegisterFunction<void, uint32_t, &JSI_Mod::ModIoStartDownloadMod>("ModIoStartDownloadMod");
		scriptInterface.RegisterFunction<bool, &JSI_Mod::ModIoAdvanceRequest>("ModIoAdvanceRequest");
		scriptInterface.RegisterFunction<void, &JSI_Mod::ModIoCancelRequest>("ModIoCancelRequest");
		scriptInterface.RegisterFunction<JS::Value, &JSI_Mod::ModIoGetMods>("ModIoGetMods");
		scriptInterface.RegisterFunction<JS::Value, &JSI_Mod::ModIoGetDownloadProgress>("ModIoGetDownloadProgress");
		leperUnsubmitted Done Inline Actions Those have already been declared. I'm not really sure how they even ended up here. leper: Those have already been declared. I'm not really sure how they even ended up here.
		ItmsAuthorUnsubmitted Not Done Inline Actions Huh, didn't even think that would compile. Itms: Huh, didn't even think that would compile.
}		}