Changeset View
Changeset View
Standalone View
Standalone View
binaries/data/mods/public/simulation/helpers/Player.js
| Show First 20 Lines • Show All 114 Lines • ▼ Show 20 Lines | for (var i = 0; i < numPlayers; ++i) | ||||
| let disabledTemplates = []; | let disabledTemplates = []; | ||||
| if (settings.DisabledTemplates !== undefined) | if (settings.DisabledTemplates !== undefined) | ||||
| disabledTemplates = settings.DisabledTemplates; | disabledTemplates = settings.DisabledTemplates; | ||||
| if (getSetting(playerData, playerDefaults, i, "DisabledTemplates") !== undefined) | if (getSetting(playerData, playerDefaults, i, "DisabledTemplates") !== undefined) | ||||
| disabledTemplates = disabledTemplates.concat(getSetting(playerData, playerDefaults, i, "DisabledTemplates")); | disabledTemplates = disabledTemplates.concat(getSetting(playerData, playerDefaults, i, "DisabledTemplates")); | ||||
| if (disabledTemplates.length) | if (disabledTemplates.length) | ||||
| cmpPlayer.SetDisabledTemplates(disabledTemplates); | cmpPlayer.SetDisabledTemplates(disabledTemplates); | ||||
| if (!settings.EnableSpies) | |||||
| { | |||||
| cmpPlayer.AddDisabledTechnology("unlock_spies"); | |||||
| cmpPlayer.AddDisabledTemplate("special/spy"); | |||||
| } | |||||
elexis: todolittle: Seems more clean to concat to `disabledTemplates` | |||||
Not Done Inline ActionsFor readability, i find clearer to add it separately. And that avoid some useless array manipulation from concat (even if it doesn't matter here) as in the player component these are objects not arrays. mimo: For readability, i find clearer to add it separately. And that avoid some useless array… | |||||
Not Done Inline ActionsAgree. Didn't read properly, if it were two disabled templates it could have become if (settings.DisableSpies)
disabledTemplates.push("temp1", "temp2")elexis: Agree. Didn't read properly, if it were two disabled templates it could have become
```
if… | |||||
| // If diplomacy explicitly defined, use that; otherwise use teams | // If diplomacy explicitly defined, use that; otherwise use teams | ||||
| if (getSetting(playerData, playerDefaults, i, "Diplomacy") !== undefined) | if (getSetting(playerData, playerDefaults, i, "Diplomacy") !== undefined) | ||||
| cmpPlayer.SetDiplomacy(getSetting(playerData, playerDefaults, i, "Diplomacy")); | cmpPlayer.SetDiplomacy(getSetting(playerData, playerDefaults, i, "Diplomacy")); | ||||
| else | else | ||||
| { | { | ||||
| // Init diplomacy | // Init diplomacy | ||||
| var myTeam = getSetting(playerData, playerDefaults, i, "Team"); | var myTeam = getSetting(playerData, playerDefaults, i, "Team"); | ||||
| ▲ Show 20 Lines • Show All 210 Lines • Show Last 20 Lines | |||||
Wildfire Games · Phabricator
todolittle: Seems more clean to concat to disabledTemplates