Differential D1707 Diff 7167 binaries/data/mods/public/gui/common/tooltips.js

Changeset View

Standalone View

binaries/data/mods/public/gui/common/tooltips.js

Context not available.
	});	});
	}	}

		function getCountersTooltip(template)
		{

		if (!template.attack)
		return "";

		let result = [];
		for (let attackType in template.attack)
		{
		if (!template.attack[attackType].bonuses)
		continue;

		let string = headerFont(sprintf(translate("Counters %(attackType)s : "), {
		elexisUnsubmitted Done Inline Actions -1 space elexis: -1 space
		NescioUnsubmitted Done Inline Actions let string = headerFont(sprintf(translate("%(attackType)s Counters: "), { Nescio: let string = headerFont(sprintf(translate("%(attackType)s Counters: "), {
		lyvUnsubmitted Done Inline Actions Shouldn't that be .every() == 1? If something isn't one, they should not be skipped over? lyv: Shouldn't that be .every() == 1? If something isn't one, they should not be skipped over?
		StanUnsubmitted Done Inline Actions Could work as well, as I understand it, !some != 1 = every = 1 no ? Stan: Could work as well, as I understand it, !some != 1 = every = 1 no ?
		lyvUnsubmitted Done Inline Actions I did not see that negation. Why a double negative though? I didn’t not see a bird Vs I saw a bird. Is how this reads to me. lyv: I did not see that negation. Why a double negative though? I didn’t not see a bird Vs I saw a…
		StanUnsubmitted Done Inline Actions Yeah I didn't remember the every function. I'll fix it later it makes more sense to me :) Stan: Yeah I didn't remember the every function. I'll fix it later it makes more sense to me :)
		elexisUnsubmitted Done Inline Actions (having all quantors in a formula first = https://en.wikipedia.org/wiki/Prenex_normal_form) elexis: (having all quantors in a formula first = https://en.wikipedia.org/wiki/Prenex_normal_form)
		"attackType": translate(attackType)
		}));
		let bonusesBody = [];
		NescioUnsubmitted Done Inline Actions Shouldn't there be a `s` after `%(multiplier)`? Also, `×`. Nescio: Shouldn't there be a `s` after `%(multiplier)`? Also, `×`.
		StanUnsubmitted Done Inline Actions Right Stan: Right
		for (let key in template.attack[attackType].bonuses)
		{
		let bonus = template.attack[attackType].bonuses[key];
		bonusesBody.push(sprintf("%(multiplier)s %(classes)s", {
		NescioUnsubmitted Done Inline Actions bonusesBody.push(sprintf(translate("%(multiplier)s× vs %(classes)s"), { Nescio: bonusesBody.push(sprintf(translate("%(multiplier)s× vs %(classes)s"), {
		"multiplier": bonus.multiplier,
		"classes": translate(bonus.classes)
		}));
		}
		result.push(string + bodyFont(bonusesBody.join(", ")));
		}
		elexisUnsubmitted Done Inline Actions Looks nicer without the `first` and other variables, right? Try `map` https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Global_Objects/Array/map let bonusBody = template.attack[attackType].bonuses.map(bonus => bodyFont(...) + " " + ...) (The bonus variable could be ommitted by using `template.attack[attackType].bonuses[key]` twice and adding a newline. The string variable can be inlined too with some \n and indentation). multiplier + " " + classes should use a sprintf too I think, languages might reverse that or add characters somewhere, or more space or whatever. elexis: Looks nicer without the `first` and other variables, right? Try `map` https://developer.mozilla.
		FeldfeldUnsubmitted Done Inline Actions If I try map it fails (it says it's not a function), may it be because `template.attack[attackType].bonuses` is an object (not array) or i failed the syntax ? Feldfeld: If I try map it fails (it says it's not a function), may it be because `template.attack…
		elexisUnsubmitted Done Inline Actions Oh, right, sorry for the wasted time. It is an object, not an array. One could use Object.keys(bonuses).map(bonusType => bonuses[bonusType].bla) but that will mean more objects are created, making this slower than your current function, so screw that array function. elexis: Oh, right, sorry for the wasted time. It is an object, not an array. One could use Object.keys…
		elexisUnsubmitted Done Inline Actions ", " still needs a translateWithContext, but that can be fixed at committing stage too. `string` variable can be inlined. Also makes it easier to change `"Counters %(attackType)s : "` to `"Counters %(attackType)s : %(counters)s"` elexis: ", " still needs a translateWithContext, but that can be fixed at committing stage too.
		return result.join("\n");
		}
		elexisUnsubmitted Done Inline Actions The heck happened here elexis: The heck happened here
		StanUnsubmitted Done Inline Actions clip.exe not utf8 happens sometimes. Stan: clip.exe not utf8 happens sometimes.

	function showTemplateViewerOnRightClickTooltip()	function showTemplateViewerOnRightClickTooltip()
	{	{
	// Translation: Appears in a tooltip to indicate that right-clicking the corresponding GUI element will open the Template Details GUI page.	// Translation: Appears in a tooltip to indicate that right-clicking the corresponding GUI element will open the Template Details GUI page.
Context not available.
		wraitiiUnsubmitted Done Inline Actions Accidentally left this in wraitii: Accidentally left this in