Page MenuHomeWildfire Games
Differential D1800 Diff 7611 binaries/data/mods/public/simulation/components/Attack.js

Changeset View

Standalone View

View Options

binaries/data/mods/public/simulation/components/Attack.js

Show First 20 Lines • Show All 673 Lines • ▼ Show 20 Lines
Attack.prototype.GetRangeOverlays = function() Attack.prototype.GetRangeOverlays = function()
{ {
if (!this.template.Ranged || !this.template.Ranged.RangeOverlay) if (!this.template.Ranged || !this.template.Ranged.RangeOverlay)
return []; return [];
let range = this.GetRange("Ranged"); let range = this.GetRange("Ranged");
let rangeOverlays = []; let rangeOverlays = [];
StanUnsubmitted
Not Done
Inline Actions

Range.max ?

Stan: Range.max ?
if (range.elevationBonus && range.max) {
elexisUnsubmitted
Not Done
Inline Actions

\n{

elexis: \n{
elexisUnsubmitted
Not Done
Inline Actions

Why is there a range.elevationBonus test in the condition? Doesn't the elevationadapted range come into play even if that value above is 0?

elexis: Why is there a `range.elevationBonus` test in the condition? Doesn't the elevationadapted range…
let cmpPosition = Engine.QueryInterface(this.entity, IID_Position);
let cmpUnitAI = Engine.QueryInterface(this.entity, IID_UnitAI);
StanUnsubmitted
Not Done
Inline Actions

No check for range manager ?

Stan: No check for range manager ?
let cmpRangeManager = Engine.QueryInterface(SYSTEM_ENTITY, IID_RangeManager);
if (cmpRangeManager && cmpPosition && cmpPosition.IsInWorld())
StanUnsubmitted
Not Done
Inline Actions

Could be unified in one if(cmppos && isingword)
Var x = cmpUnitai ? 2 PI : 0;
bonus = cmpRangeManager.GetElevationAdaptedRange(cmpPosition.GetPosition(), cmpPosition.GetRotation(), range.max, range.elevationBonus, x);

Stan: Could be unified in one if(cmppos && isingword) Var x = cmpUnitai ? 2 PI : 0; bonus =…
elexisUnsubmitted
Not Done
Inline Actions

and inline x

elexis: and inline x
range.max = cmpRangeManager.GetElevationAdaptedRange(cmpPosition.GetPosition(), cmpPosition.GetRotation(), range.max, range.elevationBonus, cmpUnitAI ? 0 : 2*Math.PI);
StanUnsubmitted
Not Done
Inline Actions

Spaces for operator. 2 * PI instead of 2*PI

Stan: Spaces for operator. 2 * PI instead of 2*PI
elexisUnsubmitted
Not Done
Inline Actions

spaces around the * operator.
176 characters that line, how about:

	range.max = cmpRangeManager.GetElevationAdaptedRange(
		cmpPosition.GetPosition(),
		cmpPosition.GetRotation(),
		...

\n before the for

cmpUnitAI init only if the condition is true

elexis: spaces around the * operator. 176 characters that line, how about: ``` range.max =…
}
for (let i in range) for (let i in range)
if ((i == "min" || i == "max") && range[i]) if ((i == "min" || i == "max") && range[i])
rangeOverlays.push({ rangeOverlays.push({
"radius": range[i], "radius": range[i],
"texture": this.template.Ranged.RangeOverlay.LineTexture, "texture": this.template.Ranged.RangeOverlay.LineTexture,
StanUnsubmitted
Not Done
Inline Actions

Range.max ?
Could be merged in the if after the change I guess.

Stan: Range.max ? Could be merged in the if after the change I guess.
"textureMask": this.template.Ranged.RangeOverlay.LineTextureMask, "textureMask": this.template.Ranged.RangeOverlay.LineTextureMask,
"thickness": +this.template.Ranged.RangeOverlay.LineThickness, "thickness": +this.template.Ranged.RangeOverlay.LineThickness,
}); });
return rangeOverlays; return rangeOverlays;
}; };
Engine.RegisterComponentType(IID_Attack, "Attack", Attack); Engine.RegisterComponentType(IID_Attack, "Attack", Attack);
Wildfire Games · Phabricator