Page MenuHomeWildfire Games
Differential D1847 Diff 7842 source/simulation2/components/CCmpRangeOverlayRenderer.cpp

Changeset View

Standalone View

View Options

source/simulation2/components/CCmpRangeOverlayRenderer.cpp

Show First 20 Lines • Show All 124 Lines • ▼ Show 20 Lines void HandleMessage(const CMessage& msg, bool UNUSED(global))
case MT_OwnershipChanged: case MT_OwnershipChanged:
{ {
UpdateColor(); UpdateColor();
break; break;
} }
case MT_RenderSubmit: case MT_RenderSubmit:
{ {
const CMessageRenderSubmit& msgData = static_cast<const CMessageRenderSubmit&> (msg); const CMessageRenderSubmit& msgData = static_cast<const CMessageRenderSubmit&> (msg);
RenderSubmit(msgData.collector); RenderSubmit(msgData.collector, msgData.frustum, msgData.culling);
break; break;
} }
} }
} }
virtual void UpdateColor() virtual void UpdateColor()
{ {
CmpPtr<ICmpOwnership> cmpOwnership(GetEntityHandle()); CmpPtr<ICmpOwnership> cmpOwnership(GetEntityHandle());
Show All 37 Lines void UpdateMessageSubscriptions()
if (needRenderSubmit != m_EnabledRenderSubmit) if (needRenderSubmit != m_EnabledRenderSubmit)
{ {
GetSimContext().GetComponentManager().DynamicSubscriptionNonsync(MT_RenderSubmit, this, needRenderSubmit); GetSimContext().GetComponentManager().DynamicSubscriptionNonsync(MT_RenderSubmit, this, needRenderSubmit);
m_EnabledRenderSubmit = needRenderSubmit; m_EnabledRenderSubmit = needRenderSubmit;
m_Enabled = needRenderSubmit; m_Enabled = needRenderSubmit;
} }
} }
void RenderSubmit(SceneCollector& collector) void RenderSubmit(SceneCollector& collector, const CFrustum& frustum, bool culling)
{ {
if (!m_RangeOverlayData.size()) if (!m_RangeOverlayData.size())
return; return;
for (const RangeOverlayData& rangeOverlay : m_RangeOverlayData) for (const RangeOverlayData& rangeOverlay : m_RangeOverlayData)
StanUnsubmitted
Not Done
Inline Actions

I think you need braces now according to the CC.

Stan: I think you need braces now according to the CC.
if (rangeOverlay.second) if (rangeOverlay.second)
{
if (culling && !rangeOverlay.second->IsVisibleInFrustum(frustum))
continue;
StanUnsubmitted
Not Done
Inline Actions

Could be

if (!rangeOverlay.second)
    continue;
Stan: Could be ```lang=cpp if (!rangeOverlay.second) continue; ```
collector.Submit(rangeOverlay.second); collector.Submit(rangeOverlay.second);
} }
}
private: private:
void UpdateRangeOverlay(const SOverlayDescriptor* overlayDescriptor, SOverlayTexturedLine& overlay, float frameOffset) void UpdateRangeOverlay(const SOverlayDescriptor* overlayDescriptor, SOverlayTexturedLine& overlay, float frameOffset)
{ {
if (!CRenderer::IsInitialised()) if (!CRenderer::IsInitialised())
return; return;
CmpPtr<ICmpPosition> cmpPosition(GetEntityHandle()); CmpPtr<ICmpPosition> cmpPosition(GetEntityHandle());
Show All 25 Lines
Wildfire Games · Phabricator