Changeset View
Changeset View
Standalone View
Standalone View
source/simulation2/components/CCmpRangeOverlayRenderer.cpp
/* Copyright (C) 2018 Wildfire Games. | /* Copyright (C) 2019 Wildfire Games. | ||||
* This file is part of 0 A.D. | * This file is part of 0 A.D. | ||||
* | * | ||||
* 0 A.D. is free software: you can redistribute it and/or modify | * 0 A.D. is free software: you can redistribute it and/or modify | ||||
* it under the terms of the GNU General Public License as published by | * it under the terms of the GNU General Public License as published by | ||||
* the Free Software Foundation, either version 2 of the License, or | * the Free Software Foundation, either version 2 of the License, or | ||||
* (at your option) any later version. | * (at your option) any later version. | ||||
* | * | ||||
* 0 A.D. is distributed in the hope that it will be useful, | * 0 A.D. is distributed in the hope that it will be useful, | ||||
▲ Show 20 Lines • Show All 115 Lines • ▼ Show 20 Lines | void HandleMessage(const CMessage& msg, bool UNUSED(global)) | ||||
case MT_OwnershipChanged: | case MT_OwnershipChanged: | ||||
{ | { | ||||
UpdateColor(); | UpdateColor(); | ||||
break; | break; | ||||
} | } | ||||
case MT_RenderSubmit: | case MT_RenderSubmit: | ||||
{ | { | ||||
const CMessageRenderSubmit& msgData = static_cast<const CMessageRenderSubmit&> (msg); | const CMessageRenderSubmit& msgData = static_cast<const CMessageRenderSubmit&> (msg); | ||||
RenderSubmit(msgData.collector); | RenderSubmit(msgData.collector, msgData.frustum, msgData.culling); | ||||
break; | break; | ||||
} | } | ||||
} | } | ||||
} | } | ||||
virtual void UpdateColor() | virtual void UpdateColor() | ||||
{ | { | ||||
CmpPtr<ICmpOwnership> cmpOwnership(GetEntityHandle()); | CmpPtr<ICmpOwnership> cmpOwnership(GetEntityHandle()); | ||||
Show All 37 Lines | void UpdateMessageSubscriptions() | ||||
if (needRenderSubmit != m_EnabledRenderSubmit) | if (needRenderSubmit != m_EnabledRenderSubmit) | ||||
{ | { | ||||
GetSimContext().GetComponentManager().DynamicSubscriptionNonsync(MT_RenderSubmit, this, needRenderSubmit); | GetSimContext().GetComponentManager().DynamicSubscriptionNonsync(MT_RenderSubmit, this, needRenderSubmit); | ||||
m_EnabledRenderSubmit = needRenderSubmit; | m_EnabledRenderSubmit = needRenderSubmit; | ||||
m_Enabled = needRenderSubmit; | m_Enabled = needRenderSubmit; | ||||
} | } | ||||
} | } | ||||
void RenderSubmit(SceneCollector& collector) | void RenderSubmit(SceneCollector& collector, const CFrustum& frustum, bool culling) | ||||
{ | { | ||||
if (!m_RangeOverlayData.size()) | if (!m_RangeOverlayData.size()) | ||||
return; | return; | ||||
for (const RangeOverlayData& rangeOverlay : m_RangeOverlayData) | for (const RangeOverlayData& rangeOverlay : m_RangeOverlayData) | ||||
Stan: I think you need braces now according to the CC. | |||||
if (rangeOverlay.second) | if (rangeOverlay.second) | ||||
StanUnsubmitted Not Done Inline ActionsCould be if (!rangeOverlay.second) continue; Stan: Could be
```lang=cpp
if (!rangeOverlay.second)
continue;
``` | |||||
{ | |||||
if (culling && !rangeOverlay.second->IsVisibleInFrustum(frustum)) | |||||
continue; | |||||
collector.Submit(rangeOverlay.second); | collector.Submit(rangeOverlay.second); | ||||
} | } | ||||
} | |||||
private: | private: | ||||
void UpdateRangeOverlay(const SOverlayDescriptor* overlayDescriptor, SOverlayTexturedLine& overlay, float frameOffset) | void UpdateRangeOverlay(const SOverlayDescriptor* overlayDescriptor, SOverlayTexturedLine& overlay, float frameOffset) | ||||
{ | { | ||||
if (!CRenderer::IsInitialised()) | if (!CRenderer::IsInitialised()) | ||||
return; | return; | ||||
CmpPtr<ICmpPosition> cmpPosition(GetEntityHandle()); | CmpPtr<ICmpPosition> cmpPosition(GetEntityHandle()); | ||||
Show All 25 Lines |
Wildfire Games · Phabricator
I think you need braces now according to the CC.