Changeset View
Changeset View
Standalone View
Standalone View
source/tools/atlas/GameInterface/MessagesSetup.h
| Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines | |||||
| const bool MERGE = true; | const bool MERGE = true; | ||||
| const bool NOMERGE = false; | const bool NOMERGE = false; | ||||
| #define COMMANDDATASTRUCT(t) \ | #define COMMANDDATASTRUCT(t) \ | ||||
| struct d##t { \ | struct d##t { \ | ||||
| private: \ | private: \ | ||||
| const d##t& operator=(const d##t&); \ | d##t& operator=(const d##t&) = default; \ | ||||
vladislavbelov: The change has a different meaning. | |||||
Done Inline ActionsWarning is
elexis: Warning is
> warning: implicitly-declared ‘AtlasMessage::dSetMapSettings::dSetMapSettings(const… | |||||
vladislavbelovUnsubmitted Not Done Inline ActionsBtw, it should be = deleted as I understand. vladislavbelov: Btw, it should be `= deleted` as I understand. | |||||
elexisAuthorUnsubmitted Done Inline ActionsAgree, the ctor is private, so that it can't be called, hence it's a safeguard and delete is better to reflect that. and it should be supported as it uses C++11 elexis: Agree, the ctor is private, so that it can't be called, hence it's a safeguard and delete is… | |||||
| public: | public: | ||||
| #define COMMANDSTRUCT(t, merge) \ | #define COMMANDSTRUCT(t, merge) \ | ||||
| struct m##t : public mWorldCommand, public d##t { \ | struct m##t : public mWorldCommand, public d##t { \ | ||||
| m##t(const d##t& d) : d##t(d) {} \ | m##t(const d##t& d) : d##t(d) {} \ | ||||
| const char* GetName() const { return #t; } \ | const char* GetName() const { return #t; } \ | ||||
| virtual bool IsMergeable() const { return merge; } \ | virtual bool IsMergeable() const { return merge; } \ | ||||
| void* CloneData() const { return SHAREABLE_NEW(d##t, (*this)); } \ | void* CloneData() const { return SHAREABLE_NEW(d##t, (*this)); } \ | ||||
| ▲ Show 20 Lines • Show All 111 Lines • Show Last 20 Lines | |||||
Wildfire Games · Phabricator
The change has a different meaning.