Page MenuHomeWildfire Games
Differential D1938 Diff 8902 binaries/data/mods/public/simulation/helpers/DamageTypes.js

Changeset View

Standalone View

View Options

binaries/data/mods/public/simulation/helpers/DamageTypes.js

DamageTypes.prototype.BuildSchema = function(helptext = "") /**
* Builds a RelaxRNG schema based on currently valid elements.
*
* To prevent validation errors, disabled damage types are included in the schema.
*
* @param {string} helptext - Text displayed as help
wraitiiUnsubmitted
Done
Inline Actions

You're not actually displaying that :p

wraitii: You're not actually displaying that :p
StanUnsubmitted
Done
Inline Actions

Yeah, should be added back line 12.

Stan: Yeah, should be added back line 12.
FreagarachAuthorUnsubmitted
Done
Inline Actions

I don't even know where it is used ;)

Freagarach: I don't even know where it is used ;)
* @return {string} - RelaxNG schema string
*/
function BuildDamageTypesSchema(helptext = "")
wraitiiUnsubmitted
Done
Inline Actions

Just rename this to function BuildDamageTypesSchema()

wraitii: Just rename this to `function BuildDamageTypesSchema()`
{ {
FreagarachAuthorUnsubmitted
Done
Inline Actions

MTM: Clean this.

Freagarach: MTM: Clean this.
return "<interleave>" + this.GetTypes().reduce((schema, type) => return "<oneOrMore>" +
schema + "<element name='"+type+"' a:help='"+type+" "+helptext+"'><ref name='nonNegativeDecimal'/></element>", "<element a:help='" + helptext + "'>" +
"") + "</interleave>"; "<anyName>" +
}; // Armour requires Foundation to not be a damage type.
"<except><name>Foundation</name></except>" +
StanUnsubmitted
Done
Inline Actions

Space between operators ?

Stan: Space between operators ?
wraitiiUnsubmitted
Done
Inline Actions

Allow "AnyName" instead of hardcoding the damage name here.

wraitii: Allow "AnyName" instead of hardcoding the damage name here.
FreagarachAuthorUnsubmitted
Done
Inline Actions

I'll look into this.

Freagarach: I'll look into this.
FreagarachAuthorUnsubmitted
Done
Inline Actions

I can't seem to get this working:

ERROR: CXeromyces: Parse error: in_memory_buffer:1: Element or text conflicts in interleave

with this as the shema:

let schema =
	"<oneOrMore>" +
		"<element a:help='" + helptext + "'>" +
			"<anyName/>" +
			"<ref name='nonNegativeDecimal'/>" +
		"</element>" +
	"</oneOrMore>";
Freagarach: I can't seem to get this working: ``` ERROR: CXeromyces: Parse error: in_memory_buffer:1…
wraitiiUnsubmitted
Done
Inline Actions

This sent me for a bit of a loop... The problem is that this element's name (being any) might conflict with other elements at the same level.

So you need to do something like:

DamageTypes.prototype.BuildSchema = function(helptext = "", except = [])
{
	return "<oneOrMore>" +
		"<element>" +
			"<anyName>" +
				(except.length ? ("<except>" + except.map(e => "<name>" + e + "</name>").join('') + "</except>") : "") +
			"</anyName>" +
			"<ref name='nonNegativeDecimal' />" +
		"</element>" +
	"</oneOrMore>";
};

and pass the appropriate list everywhere (which is annoying where there are many conflicts).
So I guess that's one more argument for D1950 :)

Though I do think we should allow any name, so I would wait for D1950 first.

wraitii: This sent me for a bit of a loop... The problem is that this element's name (being any) might…
FreagarachAuthorUnsubmitted
Done
Inline Actions

We discussed that the "Armour" doesn't need the "Damage"-container, so there it can still conflict with "Foundation", right? And there the except "Foundation" needs to be given, then. If I read this correctly.

Freagarach: We discussed that the "Armour" doesn't need the "Damage"-container, so there it can still…
wraitiiUnsubmitted
Done
Inline Actions

You read this correctly indeed, but you need to pass ['Foundation'] as it can take a list.

wraitii: You read this correctly indeed, but you need to pass `['Foundation']` as it can take a list.
"</anyName>" +
"<ref name='nonNegativeDecimal' />" +
wraitiiUnsubmitted
Done
Inline Actions

I've add some more time to think about this, and we don't need the "except" parameter.
Foundation cannot be used as a damage name since you can't have armour against it. So instead, we should just explicitly forbid it in all Damage Types schema - no need for the parameter, just write:

"<oneOrMore>" +
	"<element>" +
		"<anyName>" +
			// Armour requires Foundation to not be a damage type.
			"<except>name>Foundation</name></except>" +
		"</anyName>" +
		"<ref name='nonNegativeDecimal' />" +
	"</element>" +
"</oneOrMore>"
wraitii: I've add some more time to think about this, and we don't need the "except" parameter.
"</element>" +
"</oneOrMore>";
}
DamageTypes = new DamageTypes(); Engine.RegisterGlobal("BuildDamageTypesSchema", BuildDamageTypesSchema);
StanUnsubmitted
Done
Inline Actions

Where is this.GetTypes() defined ?
Maybe you can access the attribute directly saving a function call

Stan: Where is this.GetTypes() defined ? Maybe you can access the attribute directly saving a…
FreagarachAuthorUnsubmitted
Done
Inline Actions

I'm not sure how the helper functions work, but it seems that "this" is the Globalscript of the DamageTypes?

Freagarach: I'm not sure how the helper functions work, but it seems that "this" is the Globalscript of the…
StanUnsubmitted
Done
Inline Actions

You don't need the braces here :)

Stan: You don't need the braces here :)
wraitiiUnsubmitted
Done
Inline Actions

And instead here use Engine.RegisterGlobal("BuildDamageTypesSchema", BuildDamageTypesSchema);

wraitii: And instead here use `Engine.RegisterGlobal("BuildDamageTypesSchema", BuildDamageTypesSchema);`
Wildfire Games · Phabricator