Differential D2106 Diff 9056 binaries/data/mods/public/simulation/templates/template_unit_ship_merchant.xml

Changeset View

Standalone View

binaries/data/mods/public/simulation/templates/template_unit_ship_merchant.xml

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines	<Capacities>
<food>75</food>		<food>75</food>
<wood>75</wood>		<wood>75</wood>
<stone>50</stone>		<stone>50</stone>
<metal>50</metal>		<metal>50</metal>
</Capacities>		</Capacities>
</ResourceGatherer>		</ResourceGatherer>
<Trader>		<Trader>
<GainMultiplier>0.75</GainMultiplier>		<GainMultiplier>0.75</GainMultiplier>
		<GainMultiplierPerGarrisonedTrader>0.2</GainMultiplierPerGarrisonedTrader>
		NescioUnsubmitted Not Done Inline Actions Very long node name (33 letters). Also, how much work would it be to allow for custom classes? E.g. a DonkeyTrader adds 0.1, OxTrader 0.2, CamelTrader 0.3; somewhat similar to bonus attacks. Just wondering; I'm not sure it's worth it, though. Nescio: Very long node name (33 letters). Also, how much work would it be to allow for custom classes?
		SilierAuthorUnsubmitted Done Inline Actions Feel free to propose shorter name :) Short answer: Not much. Longer: That would make computation a bit slower, although I do not think noticeably slower. Currently I do not see it as something we need to do. If there would be proposition with defined gains per trader type and it would be mostly balanced and have sense in general and agreed it is something game design needs or wants, than patch allowing that will be made. Anyway I feel it to be out of scope of this patch. Silier: Feel free to propose shorter name :) Short answer: Not much. Longer: That would make…
		FreagarachUnsubmitted Not Done Inline Actions Would you deem it also out of scope to not hard-code the trader part? So not allowing more multipliers but just adding a `GarrisonGainMultiplierClasses`-node? (One could argue that garrisoning slaves would also increase the gain or something.) Then instead of let cmpGarrisonedUnitTrader = Engine.QueryInterface(entity, IID_Trader); if (cmpGarrisonedUnitTrader) one could do: `MatchesClassesList(...)`? (Name could be `GarrisonGainMultiplier` then?) Freagarach: Would you deem it also out of scope to not hard-code the trader part? So not allowing more…
</Trader>		</Trader>
<UnitAI>		<UnitAI>
<DefaultStance>passive</DefaultStance>		<DefaultStance>passive</DefaultStance>
<CanGuard>false</CanGuard>		<CanGuard>false</CanGuard>
<CanPatrol>false</CanPatrol>		<CanPatrol>false</CanPatrol>
</UnitAI>		</UnitAI>
<UnitMotion>		<UnitMotion>
<PassabilityClass>ship-small</PassabilityClass>		<PassabilityClass>ship-small</PassabilityClass>
Show All 9 Lines