Differential D1806 Diff 9368 binaries/data/mods/public/simulation/data/auras/structures/workshop_repair.json

Changeset View

Standalone View

	{			{
	"type": "garrisonedUnits",			"type": "garrisonedUnits",
	"affects": ["Siege"],			"affects": ["Siege"],
	"modifications": [			"modifications": [
	{ "value": "Health/RegenRate", "add": 3 }			{ "value": "Health/RegenRate", "add": 3 }
	],			],
	"auraName": "Workshop Repairs",			"auraName": "Workshop Repairs",
	"auraDescription": "Repairs garrisoned siege units at 3 HP per second."			"auraDescription": "Garrisoned Siege Engines +3 health regeneration rate."
				GallaecioUnsubmitted Not Done Inline Actions engine → Engine? Gallaecio: engine → Engine?
				NescioAuthorUnsubmitted Done Inline Actions The class is `Siege`, not `SiegeEngine`. Nescio: The class is `Siege`, not `SiegeEngine`.
				GallaecioUnsubmitted Not Done Inline Actions We can post-pone this discussion and merge as is. But I think that, even if the class is called Siege in code, it does not make sense to consider ‘engine’ separately for capitalization. I think in ‘siege engine’, mid sentence, we should capitalize either both words or none of them, and when referring to units with the Siege class I would capitalize both words. Gallaecio: We can post-pone this discussion and merge as is. But I think that, even if the class is…
	}			}