Make random agnostic.

Going to make this an array and determine the number in the synchronized part of the code. This occurance might not bug, but having randFloats called each time upon initialization of the file is asking for OOS on rejoin.

One could merge these min/max into an array or object, no strong opinion.

AFAIK it is Greatest amount or Largest number

amount of time? rly ==> number of minutes

TODO AI I guess....

worth a JsDoc imo

dunno if ...waveTime is cleaner.

random agnostic

Why is there a round? isn't it allowed to have a wave after 4:33?

6000 see somewhere below.

totalAttackers seems to imply this, better have some docs about the way it is calculated i.o exponential with the given parameters.

inline pickrandom

Since the attackers in first wave is randomized a bit here (nextWaveTime) imo there is no need in randomizing the initialAttackers also.

If someone stupidly adds a siegeratio>1 we will get errors here. Perhaps add a Math.min or leave as is since ppl shouldn't be that stupid.

Same as above maybe ...heroTime

inline random agnostic

pickrandom

Once #252 is implemented we could add some prefType: !Capture in this, to avoid capturing, for now leave as is.

When hero still alive there is one attacker less and no new hero's will come, so its seems it is sort of good to keep hero alive.

This check works ofc, but wouldn't it be cleaner to use the onOwnershipChange messages to remove the hero from this.gaiaHeroes[cmpPlayer.GetPlayerID()]? This would need some further changes though (storing the ent id instead of player's), no strong opinion.

randfloat and can be inlined later when removing debug.

We now only have siege and champion classes, when we want to add more this needs change ofc.

Math.min unneeded as attackerTypeCount should always be integer.

random agnostic

This is not a fair distribution, since the first template is expected to have more than the second, third etc. (This does not hold for only 2 templates, but there are arrays of more.)
The trivial and slow way is too loop over the entity's and use some pickrandom. Perhaps better is to use some sort of multinomial distribution as below (I didn't proof this will result in a multinomial distribution):

Here an example for 3 templates:

rand1=randFloat(0,1);
rand2=randFloat(0,1);
rand3=randFloat(0,1);
total=rand1+rand2+rand3;
ratio1=rand1/total;
ratio2=rand2/total;
ratio3=rand3/total;

and use these ratio's to calculate the amount of attackers per type.
As said I didn't proof this results in a proper multinomial distribution, but it looks more fair than the current code (and it is faster than looping over all ents).
This can trivially be extended to any number of templates.

With these changes maybe the Math.min(a,b) is needed again.

Seen factor 60* 1000 before as 6000, change either of them. there are some occurrences below too of 60*1000

init helper function, move directly under init functions.

missing whitespace

missing semicolon

Was wondering wheter this could be abused to distract the waves to attack the woman and thus become invincible, but move the woman up requires lots of resources and so it would be almost impossible. A way to fix this is letting the gaia's not attack invincible units, needs same fix as buildings attacking those.

period

Name starts with init: move all of them together at top.

Loads of trailing comma's: meh