Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Trac Tickets
- #1962
Test that ambient sounds work
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 10397 Build 17762: Vulcan Build Jenkins Build 17761: Vulcan Build (Windows) Jenkins Build 17760: arc lint + arc unit
Event Timeline
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1027/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/512/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1331/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/815/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1332/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/816/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1333/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/817/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1334/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/818/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/819/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/simulation2/components/ICmpSoundManager.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/simulation2/components/ICmpSoundManager.h | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/simulation2/components/ICmpSoundManager.h | 28| class·ICmpSoundManager·:·public·IComponent | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classICmpSoundManager:' is invalid C code. Use --std or --language to configure the language. source/soundmanager/SoundManager.h | 27| #include·"items/ISoundItem.h" | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classISoundManager{' is invalid C code. Use --std or --language to configure the language. source/soundmanager/ISoundManager.h | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/soundmanager/ISoundManager.h | 27| class·ISoundManager | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classISoundManager{' is invalid C code. Use --std or --language to configure the language. source/simulation2/components/CCmpSoundManager.cpp | 1| /*·Copyright·(C)·2018·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2018" Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1335/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1336/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/820/display/redirect
binaries/data/mods/public/simulation/components/Sound.js | ||
---|---|---|
70 | Perhaps we can use a timer? |
Build failure - The Moirai have given mortals hearts that can endure.
builderr-debug-macos.txt In file included from ../../../source/soundmanager/SoundManager.cpp:21: In file included from ../../../source/soundmanager/SoundManager.h:28: ../../../source/soundmanager/scripting/SoundGroup.h:63:27: error: extra qualification on member 'GetRandomSound' CSoundData* CSoundGroup::GetRandomSound(); ~~~~~~~~~~~~~^ In file included from ../../../source/ps/scripting/JSInterface_Game.cpp:32: In file included from ../../../source/soundmanager/SoundManager.h:28: ../../../source/soundmanager/scripting/SoundGroup.h:63:27: error: extra qualification on member 'GetRandomSound' CSoundData* CSoundGroup::GetRandomSound(); ~~~~~~~~~~~~~^ 1 error generated. make[1]: *** [obj/engine_Debug/JSInterface_Game.o] Error 1 make[1]: *** Waiting for unfinished jobs.... 1 error generated. make[1]: *** [obj/engine_Debug/SoundManager.o] Error 1 make: *** [engine] Error 2
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1643/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
builderr-debug-gcc6.txt In file included from ../../../source/soundmanager/SoundManager.h:28:0, from ../../../source/ps/scripting/JSInterface_Game.cpp:32: ../../../source/soundmanager/scripting/SoundGroup.h:63:14: error: extra qualification 'CSoundGroup::' on member 'GetRandomSound' [-fpermissive] CSoundData* CSoundGroup::GetRandomSound(); ^~~~~~~~~~~ make[1]: *** [obj/engine_Debug/JSInterface_Game.o] Error 1 make: *** [engine] Error 2
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3295/display/redirect
I sadly haven't made much progress no.
Atlas is still broken AFAIR.
binaries/data/mods/public/simulation/components/Sound.js | ||
---|---|---|
70 | Would sound a bit weird to have a unit making an ambient sound at a different place :) |