Page MenuHomeWildfire Games

[gameplay] tweak wall vision
ClosedPublic

Authored by Nescio on Dec 23 2019, 2:03 PM.

Details

Reviewers
borg-
genava55
wraitii
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23934: Tweak vision of walls and some special structures.
Summary

This patch changes the vision range of wall segments, palisades, Iberian monument, Mauryan pillar, and Roman arch to 1. This means you can select them, but they won't reveal their surrounding area. They're basically pieces of stone, wood, and metal, so it's unnatural to have them see things. (For comparison, field has 0.) Ranged infantry on walls still has an extensive range, of course.

  • Wall towers are garrisonable and have a ranged attack, which means they need to have a vision range larger than their maximum attack range, hence changed from 60 to 80.
Test Plan

Agree this is an improvement.

Event Timeline

Nescio created this revision.Dec 23 2019, 2:03 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/873/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1389/display/redirect

Nescio retitled this revision from tweak wall vision to [gameplay] tweak wall vision.Dec 23 2019, 2:13 PM
Nescio updated this revision to Diff 12301.Jun 14 2020, 11:31 AM
Nescio edited the summary of this revision. (Show Details)
  • remove gate exception
Owners added a subscriber: Restricted Owners Package.Jun 14 2020, 11:31 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2429/display/redirect

borg- added a subscriber: borg-.Jun 19 2020, 4:33 PM

the idea is good.
I will do some tests.

Are there other structures (e.g. corral, pyramids, Stonehenge) that should get this same vision change?

borg- accepted this revision.Aug 4 2020, 3:01 AM

Are there other structures (e.g. corral, pyramids, Stonehenge) that should get this same vision change?

No, I prefer it as it is now. Maybe change field to 1 too?

  • Patch is correct;
  • Mainly affects palisade, which I think is important especially if it is accepted in neutral territory;
  • Stone walls are not much affected because towers;
  • Adds realism to the game;
  • It's a simple patch that doesn't drastically affect gameplay, so why not?
This revision is now accepted and ready to land.Aug 4 2020, 3:01 AM
genava55 accepted this revision.Aug 4 2020, 10:49 AM
genava55 added a subscriber: genava55.

Putting 1 to fields means you can select them anytime?
Concerning the wall and monument changes, I don't see any reason to reject the proposal.

wraitii accepted this revision.Aug 4 2020, 2:45 PM

(needs a rebase now)

Nescio updated this revision to Diff 13045.Aug 4 2020, 3:55 PM
  • rebased
Vulcan added a comment.Aug 4 2020, 3:55 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2868/display/redirect

This revision was landed with ongoing or failed builds.Aug 5 2020, 11:36 AM
This revision was automatically updated to reflect the committed changes.