Page MenuHomeWildfire Games

[gameplay] train champion cavalry at stable
ClosedPublic

Authored by Nescio on Jan 3 2020, 8:13 PM.

Details

Reviewers
ValihrAnt
borg-
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23746: Train champion cavalry at stable.
Summary

This patch allows training cavalry champions at the stable and removes it from the Persian fortress, because only Persians can currently build stables.
For comparison, the elephant stable, available currently only to the Mauryas, trains all types of elephants and whilst the Mauryas can train their elephant champions at captured cart/ptol/sele fortress, elephants can't be trained at their own (maur) fortress.

It also makes the cavalry speed technologies researchable at the stable (in addition to the corral); for comparison, the Nisean horses technology can also be researched at the Seleucid fortress.

Test Plan

Apply the patch, play-test with Persians, agree this is an improvement.

Event Timeline

Nescio created this revision.Jan 3 2020, 8:13 PM
Vulcan added a comment.Jan 3 2020, 8:15 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/940/display/redirect

Vulcan added a comment.Jan 3 2020, 8:17 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1458/display/redirect

Vulcan added a comment.Jan 3 2020, 8:20 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/36/display/redirect

Nescio updated this revision to Diff 10918.Jan 8 2020, 1:35 PM
Nescio edited the summary of this revision. (Show Details)

update tooltip

Vulcan added a comment.Jan 8 2020, 1:36 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/976/display/redirect

Vulcan added a comment.Jan 8 2020, 1:38 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/72/display/redirect

Vulcan added a comment.Jan 8 2020, 1:39 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1494/display/redirect

I support this change. Also, I remember there being a Persian cavalry archer champion in the files somewhere. Wouldn't be bad to include that guy in the stable as well if possible.

Thanks! Now let's hope a team member agrees with the change and is willing to take responsibility for committing it.

@ValihrAnt please accept if you (still) agree and have verified this patch :)

I have nothing against this patch, in the current state of the game it would do no harm, but i would like to note that if we are in a situation where champions are balanced and viable then suddenly persians would become (by far i think) the civ who would be able to spam them the fastest entering city phase and it could become a problem in that case.

Nescio added inline comments.May 28 2020, 11:06 AM
binaries/data/mods/public/simulation/templates/template_structure_military_stable.xml
42

Maybe units/{civ}_champion_chariot should be listed here too. Historically chariots are a branch separate from cavalry, but in 0 A.D. the only difference is the actor and footprint.

borg- accepted this revision.Jun 6 2020, 1:12 AM
borg- added a subscriber: borg-.

I have nothing against this patch.

If my memory working correctly, there is another cavalry champion that could be added to the Persians (champion archer cav i think).

This revision is now accepted and ready to land.Jun 6 2020, 1:12 AM

Yes, the Persians have an unused champion cavalry archer, as well as an unused champion chariot archer (see D2683).

This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Jun 7 2020, 3:09 PM