Page MenuHomeWildfire Games
Differential D2519

Add --with-system-premake5 option to update-workspaces.sh
ClosedPublic
Actions

Authored by Itms on Dec 28 2019, 5:48 PM.

Details

Reviewers
None
Commits
rP23675: Allow using system premake5 (with the flag --with-system-premake5) when running…
Trac Tickets
#1518
Summary

This was a leftover from the premake5 upgrade that I never did. I wanted to close #1518 after this.

Test Plan

Test the script.

It would be nice to test on a distribution where premake5 is in the repositories, although I am not aware of one. This change will probably motivate package maintainers into packaging premake5 as a build dependency of 0ad.

Diff Detail

Event Timeline

Itms created this revision.Dec 28 2019, 5:48 PM
Vulcan added a comment.Dec 28 2019, 5:50 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/907/display/redirect

Vulcan added a comment.Dec 28 2019, 5:54 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1423/display/redirect

Harbormaster completed remote builds in B10557: Diff 10817.Dec 28 2019, 5:54 PM
Itms updated this revision to Diff 10991.Jan 12 2020, 9:30 PM
Itms edited the summary of this revision. (Show Details)
Itms edited the test plan for this revision. (Show Details)

Remove the macOS change that is out of place and is likely to create issues.

Vulcan added a comment.Jan 12 2020, 9:45 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1535/display/redirect

Vulcan added a comment.Jan 12 2020, 9:51 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1017/display/redirect

Vulcan added a comment.Jan 12 2020, 10:09 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/113/display/redirect

Harbormaster completed remote builds in B10764: Diff 10991.Jan 12 2020, 10:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 17 2020, 1:43 PM
Closed by commit rP23675: Allow using system premake5 (with the flag --with-system-premake5) when running… (authored by Itms). · Explain Why
This revision was automatically updated to reflect the committed changes.
Itms added a commit: rP23675: Allow using system premake5 (with the flag --with-system-premake5) when running….

Revision Contents
Changeset List

PathSize
build/
workspaces/
47 lines

Diff 10991

View Options

build/workspaces/update-workspaces.sh

Loading...
Wildfire Games · Phabricator