Paths

Table of Contentst

Differential D2569

[gui] standardize modmod buttons width
ClosedPublic
Actions

Authored by Nescio on Jan 14 2020, 7:39 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP23393: Standardize modmod buttons width

Summary

The buttons at the bottom of the mod selection screen all have the same height (28), but slightly different widths (two have 220, three 190, three 194). This patch standardizes them to a width of 180.
As a consequence it also looks better at screens with a width of 960, which is equivalent to 1920 at gui.scale = "2", 2880 at 3×, and 3840 at 4×.
Before:

After:

Test Plan

Agree this is an improvement.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 14 2020, 7:39 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1037/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/133/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1555/display/redirect

Harbormaster completed remote builds in B10792: Diff 11014.Jan 14 2020, 7:43 PM

Nescio updated this revision to Diff 11015.Jan 14 2020, 7:44 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1038/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/134/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1556/display/redirect

Harbormaster completed remote builds in B10793: Diff 11015.Jan 14 2020, 7:49 PM

bb added a subscriber: bb.Jan 14 2020, 8:23 PM

bb added inline comments.

binaries/data/mods/mod/gui/modmod/modmod.xml
177–180 ↗	(On Diff #11015)	what is this button? seems like it is underneath another button, also not sure if we really want this button

Nescio added inline comments.Jan 14 2020, 8:30 PM

binaries/data/mods/mod/gui/modmod/modmod.xml
177–180 ↗	(On Diff #11015)	Yes, we do. If you disable the `0ad` mod, then you can't cancel to return to the 0 A.D. main menu; instead, you can quit. Upon restarting 0ad you go directly back to the mod selection screen, which is desirable.

bb accepted this revision.Jan 14 2020, 9:02 PM

bb added inline comments.

binaries/data/mods/mod/gui/modmod/modmod.xml
177–180 ↗	(On Diff #11015)	never new about that, thx

This revision is now accepted and ready to land.Jan 14 2020, 9:02 PM

Closed by commit rP23393: Standardize modmod buttons width (authored by bb). · Explain WhyJan 14 2020, 10:03 PM

This revision was automatically updated to reflect the committed changes.

bb added a commit: rP23393: Standardize modmod buttons width.

Nescio retitled this revision from gui: standardize modmod buttons width to [gui] standardize modmod buttons width.May 18 2020, 10:30 AM

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

mod/

gui/

modmod/

16 lines

Diff 11019

ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.xml

Loading...