Page MenuHomeWildfire Games

Proposal for games header in Lobby
AbandonedPublic

Authored by ffffffff on Apr 5 2017, 3:58 PM.

Details

Reviewers
elexis
Summary

Why not having a games header in top bar where the filter for games are and show some numbers like games count and maybe gamestates maybe priorized by init/running/waiting to show numbers of interest.

When we put it middle this would nuke the mapSizeFilter dropdown but as elexis said its not really used.

But we can also put it left side and put the show full filter before mapsizefilter dropdown.

Test Plan

necessity
look if mapsizefilter needed. if so eventualy show games header on left side and put show full filter to right next to mapsizefilter.
else put maybe mid and nuke mapsizefilter

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ffffffff created this revision.EditedApr 5 2017, 3:58 PM

Games header

partial states for init

partial states for init/running with init priorized

partial states for running

ther is also partial state for waiting but cannot simulate nowxD

ffffffff edited the summary of this revision. (Show Details)Apr 5 2017, 4:04 PM
ffffffff edited the test plan for this revision. (Show Details)
ffffffff added a subscriber: scythetwirler.
ffffffff updated this revision to Diff 1111.Apr 5 2017, 4:28 PM

small refactors

ffffffff removed a reviewer: elexis.Apr 5 2017, 4:29 PM
ffffffff added a subscriber: elexis.

Can you add a screenshot as well?

ffffffff added a comment.EditedApr 5 2017, 7:09 PM

Can you add a screenshot as well?

sry ther was no white space to them in link - ther wer added but not showing because of that now comment above ther r ther

elexis suggested he doesnt like coloring in games header when showing some numbers from game state. do u agree scy or do u doesnt like showing these numbers at all. would be nice see some games header land.

ffffffff updated this revision to Diff 1349.Apr 19 2017, 2:02 AM

update gamelist header to show numbers without colors.

but show some info about states init then waiting then running games.

ffffffff updated this revision to Diff 4292.EditedNov 21 2017, 10:43 AM

update.

new version

above playerlist textbox.

with players games and buddy players and buddy games. last two as tooltip.

ffffffff edited subscribers, added: Hannibal_Barca; removed: elexis.

update.

new version

above playerlist textbox.

with players games and buddy players and buddy games. last two as tooltip.

this should be merged now in D948, so this should be deleted

binaries/data/mods/public/gui/lobby/lobby.js
237

map size filter is cut out as it is not used anyway

594

get number of interests : firstly init, then waiting, then running priorized 1,2,3

bb added a subscriber: bb.Apr 6 2018, 5:30 PM

(you can abandon revisions yourself, if it became deprecated)

bb abandoned this revision.Dec 22 2020, 11:07 PM

superseeded by D948