Details
- Reviewers
bb - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23432: Remove trailing 0's from Armour items in templates
Check for mistakes and omissions.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/124/display/redirect
| binaries/data/mods/public/simulation/templates/structures/rome_army_camp.xml | ||
|---|---|---|
| 4 ↗ | (On Diff #9702) | Why change that? (removing the operators) |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/633/display/redirect
| binaries/data/mods/public/simulation/templates/structures/rome_army_camp.xml | ||
|---|---|---|
| 4 ↗ | (On Diff #9702) | Because:
|
All Armour values got consistent now, feel free to removing trailing 0's from other template values too
| binaries/data/mods/public/simulation/templates/structures/rome_army_camp.xml | ||
|---|---|---|
| 4 ↗ | (On Diff #9702) | agreeing the op doesn't make sense here (template_structure_special and this template do not have an obvious relation here) |
All Armour values got consistent now, feel free to removing trailing 0's from other template values too
D2000 removes trailing zeros from aura files, D2222 improves the civ files.
For templates, maybe later, preferably after D2502 (adjusting wall footprints) is in, because rebasing that would be a lot of work.