Page MenuHomeWildfire Games

nuba → noba
ClosedPublic

Authored by Nescio on Sep 26 2020, 12:11 PM.

Details

Reviewers
Freagarach
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP24207: Rename nuba -> noba.
Summary

0 A.D. uses the demonym “Nuba”, which should be “Noba”, as pointed out by @Sundiata. This patch thus renames the Nuba village to Noba camp, and fixes all occurrences in the simulation and maps folders. While at it, also renames the “clubman” to a “maceman”, since its weapon is clearly a mace.
Art files could be renamed in a future patch (too many and too complicated for including here and now).

Test Plan

Check for completeness and correctness.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
SeverityLocationCodeMessage
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:222ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:223ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:224ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:225ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:226ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:234ESLintBear (no-multi-spaces)ESLintBear (no-multi-spaces)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:243ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:244ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:245ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:246ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:247ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:435ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:436ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:437ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:438ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:439ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:440ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:479ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:480ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:482ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:484ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:485ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:486ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:487ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/maps/random/jebel_barkal.js:488ESLintBear (indent)ESLintBear (indent)
Unit
No Unit Test Coverage
Build Status
Buildable 13249
Build 26462: Vulcan BuildJenkins
Build 26461: Vulcan Build (macOS)Jenkins
Build 26460: Vulcan Build (Windows)Jenkins
Build 26459: arc lint + arc unit

Event Timeline

Nescio created this revision.Sep 26 2020, 12:11 PM
Owners added subscribers: Restricted Owners Package, Restricted Owners Package, Restricted Owners Package, Restricted Owners Package.Sep 26 2020, 12:11 PM
Nescio updated this revision to Diff 13548.Sep 26 2020, 12:15 PM
Nescio removed subscribers: Restricted Owners Package, Restricted Owners Package.
  • Identity.js
Owners added a subscriber: Restricted Owners Package.Sep 26 2020, 12:16 PM
Nescio requested review of this revision.Sep 26 2020, 12:20 PM
Nescio removed a reviewer: Silier.Sep 26 2020, 12:29 PM
Nescio removed a subscriber: Restricted Owners Package.
Freagarach accepted this revision.Nov 14 2020, 10:28 AM
Freagarach added a subscriber: Freagarach.

Complete, I assume correctness.

This revision is now accepted and ready to land.Nov 14 2020, 10:28 AM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Nov 18 2020, 9:13 PM