Page MenuHomeWildfire Games

Fix handling of fixed ai defined by map after rP23419
ClosedPublic

Authored by Silier on Oct 15 2020, 8:13 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP24109: Fix handling of fixed ai defined by map after rP23419
Trac Tickets
#5844
Summary

Gamesetup fails to handle cases with fixed ai rP23419.
Removing wrong 'this' and checking for 'undefined' to fix additional warnings when switching maps.

Discussed with elexis.

Test Plan

Take map from ticket and play with it in gamesetup.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 13348
Build 26772: Vulcan BuildJenkins
Build 26771: Vulcan Build (macOS)Jenkins
Build 26770: Vulcan Build (Windows)Jenkins
Build 26769: arc lint + arc unit

Event Timeline

Silier published this revision for review.Oct 15 2020, 8:13 PM
Silier created this revision.
Silier edited the summary of this revision. (Show Details)Oct 15 2020, 8:16 PM
Freagarach added inline comments.
binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AIDifficulty.js
44–46

Linter and perhaps split the condition over multiple lines for readability?

Silier updated this revision to Diff 13637.Oct 16 2020, 5:46 PM

make linter and Freagarach happy

Silier planned changes to this revision.Oct 17 2020, 10:12 AM
Silier updated this revision to Diff 13643.Oct 17 2020, 12:53 PM

more linter

This revision was not accepted when it landed; it landed in state Needs Review.Oct 24 2020, 2:14 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Oct 24 2020, 2:14 PM