Migrate ScriptRuntime to ScriptContext Base the ScriptEngine safeguard on contexts and not runtimes
ClosedPublic
Actions

Authored by wraitii on Nov 11 2020, 12:02 PM.

Details

Reviewers: None
Commits: rP24181: Rename ScriptRuntime to ScriptContext
Trac Tickets: #4893

Summary

SM52 essentially replaces JSRuntime with JSContext (though JSContext itself was replaced with JSCompartment).
To prepare for this migration, rename all Runtime-related wrappers to Context.

Patch by @Itms
Part of the SM52 migration, stage: SM45 compatible.

Test Plan

Compile and compare.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 13628
Build 27774: Vulcan Build	Jenkins
Build 27773: Vulcan Build (macOS)	Jenkins
Build 27772: Vulcan Build (Windows)	Jenkins
Build 27771: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	0 ms	Jenkins > cxxtest-release.xml::Release Build & Tests / [empty] Test report file /Users/wfg/Jenkins/workspace/macos-differential/cxxtest-release.xml was length 0
	0 ms	Jenkins > TestAllocators::Debug Build & Tests / test_da
	0 ms	Jenkins > TestAllocators::Debug: Test / test_da
	0 ms	Jenkins > TestAllocators::Release: Test / test_da
	0 ms	Jenkins > TestAtlasObjectXML::Debug Build & Tests / test_parse_attributes1
		View Full Test Results (1 Failed · 1,022 Passed)

Event Timeline

wraitii created this revision.Nov 11 2020, 12:02 PM

Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Nov 11 2020, 12:02 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3486/display/redirect

wraitii added parent revisions: D3090: Promote compartments in ScriptInterface, D3087: Encapsulate runtime creation..Nov 11 2020, 12:03 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/2933/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1834/display/redirect

Harbormaster completed remote builds in B13573: Diff 13852.Nov 11 2020, 12:05 PM

wraitii requested review of this revision.Nov 11 2020, 12:05 PM

Stan added a subscriber: Stan.Nov 11 2020, 12:19 PM

Stan added inline comments.

source/graphics/MapGenerator.cpp
43	constexpr.
source/ps/Replay.cpp
205	Shouldn't those be constexpr globals like the others?
source/simulation2/tests/test_ComponentManager.h
373	Still accurate ?

wraitii added inline comments.Nov 11 2020, 1:02 PM

source/simulation2/tests/test_ComponentManager.h
373	I'm pretty sure the error reported is deleted entirely, but I'll need to check.

wraitii added a child revision: D3094: [SM52] Spidermonkey Upgrade 1/2 : build system upgrade to 52.9.1.Nov 11 2020, 8:20 PM

Rebase for CI

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3523/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
../../../source/simulation2/scripting/JSInterface_Simulation.cpp:152:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        CFixedVector2D(-halfSize.X, -halfSize.Y),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
In file included from ../../../source/graphics/tests/test_Camera.cpp:17:
/Users/wfg/Jenkins/workspace/macos-differential/source/graphics/tests/test_Camera.h:168:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        CVector3D(-101.0f, -101.0f, 101.0f),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
In file included from ../../../source/simulation2/tests/test_SerializeTemplates.cpp:17:
/Users/wfg/Jenkins/workspace/macos-differential/source/simulation2/tests/test_SerializeTemplates.h:39:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        3, 0, 1, 4, 1, 5
                        ^~~~~~~~~~~~~~~~
                        {               }
1 warning generated.
builderr-release-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby.a(precompiled.o) has no symbols
../../../source/simulation2/scripting/JSInterface_Simulation.cpp:152:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        CFixedVector2D(-halfSize.X, -halfSize.Y),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libscriptinterface.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui.a(precompiled.o) has no symbols
In file included from ../../../source/graphics/tests/test_Camera.cpp:17:
/Users/wfg/Jenkins/workspace/macos-differential/source/graphics/tests/test_Camera.h:168:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        CVector3D(-101.0f, -101.0f, 101.0f),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
In file included from ../../../source/simulation2/tests/test_SerializeTemplates.cpp:17:
/Users/wfg/Jenkins/workspace/macos-differential/source/simulation2/tests/test_SerializeTemplates.h:39:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        3, 0, 1, 4, 1, 5
                        ^~~~~~~~~~~~~~~~
                        {               }
1 warning generated.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1870/display/redirect

Harbormaster completed remote builds in B13628: Diff 13901.Nov 14 2020, 10:47 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3524/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3527/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3530/display/redirect

This revision was not accepted when it landed; it landed in state Needs Review.Nov 14 2020, 11:58 AM

This revision was landed with ongoing or failed builds.

Closed by commit rP24181: Rename ScriptRuntime to ScriptContext (authored by wraitii). · Explain Why

This revision was automatically updated to reflect the committed changes.