Replaces yyyy-mm dropdown by textbox. Can be used to filter by yyyy, yyyy-mm, yyyy-mm-dd,..... replay time.
Details
- Reviewers
- None
- Trac Tickets
- #4249
In Replays window, type yyyy... to filter by year, month or day,...
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
Build has FAILED
Link to build: http://jw:8080/job/phabricator/837/
See console output for more information: http://jw:8080/job/phabricator/837/console
Should explain the user how to use it, there was also some CInput.cpp patch that would allow showing a gray text that doesn't have an effect, like YYYY-MM-DD, would be nice to wait for that. Otherwise looks good at first sight
Since rP20091 we also have the TextEdit GUI event, so we don't require the user anymore to press enter.
Unfortunately it's laggy, so it should be optional, or simply not used.
Actually I found it more comfortable to have a dropdown with months when changing the filter repeatedly. You almost always have to type the same year, which are 5 keystrokes where in the other case one click and 5 mousewheel scrolls (i.e. 5x the same button), which is considerably easier and relevant when repeating it often.
Also we can't search for specific patterns, like *-12-* or only -12-.