Heroes already have a lot more armour, health, and attack damage than champions or other soldiers, and they benefit from the existing armour and attack technologies and auras, thus there is really no need for a technology giving them another +2 armour (i.e. equivalent to +23.457% health). This patch therefore deletes the armor_hero_01.json technology.
Details
- Reviewers
borg- ValihrAnt wraitii - Group Reviewers
Balancing - Commits
- rP24679: [gameplay] Delete armor_hero_01 technology
Agree this is an improvement.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 13789 Build 28346: Vulcan Build Jenkins Build 28345: Vulcan Build (macOS) Jenkins Build 28344: Vulcan Build (Windows) Jenkins Build 28343: arc lint + arc unit
Time | Test | |
---|---|---|
0 ms | Jenkins > cxxtest_debug.xml::[failed-to-read] Failed to read test report file E:\Jenkins\workspace\vs2015-differential\cxxtest_debug.xml
org.dom4j.DocumentException: Error on line 346 of document : Content is not allowed in trailing section.
at org.dom4j.io.SAXReader.read(SAXReader.java:511)
| |
0 ms | Jenkins > TestAllocators::Debug Build & Tests / test_da | |
0 ms | Jenkins > TestAllocators::Release Build & Tests / test_da | |
0 ms | Jenkins > TestAllocators::test_da | |
0 ms | Jenkins > TestAllocators::test_da | |
View Full Test Results (1 Failed · 1,694 Passed) |
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2900/display/redirect
Just remember to bring back this tech if we ever reduce the heroes health as seems to be probably happening.
If we have a patch that the hero cant be training after he is dead, then this type of tech is interesting, but not generic like this.
More opnions?
It's a tech I've never used and see no real point in, at least not currently.
Now the code for limiting a hero to once per match is committed, that is one template change away: D3265.
With D3265 this technology becomes useful, but I still disagree with how it works, a health gain or other attribute seems to me better than armor.
Even though they're now limited to only once each, heroes already have a lot of health and benefit from ordinary technologies, therefore I still think removing this technology (which makes them 25% harder to kill) is an improvement.
Sounds weird to ask for verification on the same (unchanged) patch, but the meta _has_ changed ;)
So, still agree?
Remembering also that the health of the cavalry and elephant heroes has been reduced, so it seems fair to me to keep a specific technology for them. it doesn't necessarily have to be only health, they can reduce the cost and time of training for example, and give a small gain of 5% of health.
I'd prefer an HP gain over an armour gain, tbh, I think it makes more sense given the specificity of the tech.
Your call on whether we should still delete this or not.
I think a tech for one unit is a bit odd in the current gameplay. IMO heroes already come with better armour and HP and that should be enough, particularly since they unlock in City phase already. I don't think our gameplay is hero-centric enough that they warrant further upgrades.
+23% HP is also rather underwhelming on the whole IMO.
I'll move forward with deleting this soon unless there's strong disagreement.
Ehhh, I think it would make sense for a Forge tech to increase armor rather than health, but that's not really the focus of this patch.
If it's a tech no one ever researches anyway, then no one will miss it if it's removed.
But then one can wonder why folks don't research this tech. It's either too expensive or not impactful enough for the cost.
(Also, every time armour is replaced with health, the entities doing fire damage are nerfed.)