Page MenuHomeWildfire Games

[gameplay] tweak citizen soldier health increases
ClosedPublic

Authored by Nescio on Jan 10 2021, 3:50 PM.

Details

Summary

Currently citizen soldiers get:

+20% health from advancing to the town phase
+10% health from advancing to the city phase
+10% health from promoting to the advanced rank
+10% health from promoting to the elite rank

This patch removes the free health increases from the phase advances (other units or structures don't get this either), raises the rank bonuses to +25% each, and updates the tooltips.
The final difference is minor, previously +59.72%, now +56.25%. (For comparison, champions have +100%.)

Test Plan

Apply the patch and play-test a few games.

Event Timeline

Nescio created this revision.Jan 10 2021, 3:50 PM
Owners added a subscriber: Restricted Owners Package.Jan 10 2021, 3:50 PM
Nescio edited the summary of this revision. (Show Details)Jan 10 2021, 3:51 PM
Nescio removed a subscriber: Restricted Owners Package.

Owners added a subscriber: O11: Templates.

This patch does not include any simulation templates, only technology files, therefore adding this group seems wrong.

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2747/display/redirect for more details.

Nescio requested review of this revision.Jan 10 2021, 3:56 PM
borg- added a comment.Jan 11 2021, 3:27 AM

Summary says +25% and techs +20%.

I prefer like this. Some players may feel that this does not encourage a phase change, which does not seem real to me. We have technologies and constructions for that, dont need increase health. In addition, this gives a greater chance for players who are late to win the game.

wraitii accepted this revision.Jan 11 2021, 12:01 PM
wraitii added a subscriber: wraitii.

I like this conceptually. It reduces the snowball of phasing up, and makes other stuff more valuable by comparison (e.g. armour techs & the 'start CS at rank X' techs which I think we still have?).
I also wasn't really aware that CS had more HP when passing up :P

I do see how it would make phasing up less valuable, but to be honest I think that's a problem of capabilities more than a problem of stats.

(Accepting to show approval, if somebody disagrees, please request changes)

This revision is now accepted and ready to land.Jan 11 2021, 12:01 PM

Summary says +25% and techs +20%.

Oops, apparently I uploaded the wrong version.

Nescio updated this revision to Diff 15120.Jan 11 2021, 12:33 PM
  • rebased and corrected
Owners added a subscriber: Restricted Owners Package.Jan 11 2021, 12:33 PM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//For

See https://jenkins.wildfiregames.com/job/macos-differential/2757/display/redirect for more details.

borg- accepted this revision.Jan 11 2021, 12:50 PM
Stan added a subscriber: Stan.Jan 11 2021, 12:54 PM

Checkrefs failed can you check locally if it passes @Nescio

Nescio added inline comments.Jan 11 2021, 1:01 PM
binaries/data/mods/public/simulation/data/technologies/phase_city_generic.json
26

Oops, removed one line too many when updating.

Nescio updated this revision to Diff 15124.Jan 11 2021, 1:03 PM
  • restore erroneously deleted line

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2760/display/redirect for more details.

This comment was removed by Nescio.
Stan added a comment.Jan 11 2021, 1:26 PM

Wonder if there should be a tip for it(another patch)

That's quick!