Paths

Table of Contentst

Differential D3850

Fix translation of damage types
ClosedPublic
Actions

Authored by nwtour on Apr 14 2021, 12:57 AM.

Details

Reviewers

Freagarach

Commits

rP25265: Fix translation of damage types.

Summary

Broken in https://code.wildfiregames.com/D3276

Test Plan

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

nwtour requested review of this revision.Apr 14 2021, 12:57 AM

nwtour created this revision.

Stan added a reviewer: Freagarach.Apr 14 2021, 8:11 AM

Thanks for catching this :)
While at it, you can include the DamageTypes globalscript also.

In D3850#166505, @Freagarach wrote:

While at it, you can include the DamageTypes globalscript also.

binaries/data/mods/public/globalscripts/DamageTypes.js ?
I did not find any translation lines there

Nah, there are no translation lines there, only a template_helpers that needs to be removed. (And that is needed for proper translation.)

remove "template_helper" in DamageTypes.js

Correct.
Compleat.

Thanks for the patch!

This revision is now accepted and ready to land.Apr 14 2021, 12:26 PM

Closed by commit rP25265: Fix translation of damage types. (authored by Freagarach). · Explain WhyApr 15 2021, 7:48 AM

This revision was automatically updated to reflect the committed changes.

Freagarach added a commit: rP25265: Fix translation of damage types..

Revision Contents
Changeset List

Path

Size

binaries/

data/

mods/

public/

globalscripts/

DamageTypes.js

2 lines

l10n/

messages.json

2 lines

Diff 17082

View Options

binaries/data/mods/public/globalscripts/DamageTypes.js