Page MenuHomeWildfire Games

Show full games by default, change it to "Filter open games"
ClosedPublic

Authored by elexis on Mar 12 2017, 11:45 PM.

Details

Summary

The "Show full games" filter is a relic of old times when the lobby had different characteristics:

  1. Kicking / banning players was not impossible, so one had to ask trolls friendly to stop instead of being able to take care oneself.
  2. The client limit was 8, so if the server was full and one of the players was not welcome, the other player people waited for could not join. Now 40 clients can join.
  3. Observing wasn't a thing, due to the client limit and broke observer implementation. Nowadays a significant portion of the games are joined by late observers and for many if not most players, the first action after logging in is to uncheck that filter to see all games.

Furthermore the "full games" filter still shows running games where some players left,
while the intention was to only show games that are waiting in the gamesetup for more players to become assigned.

Therefore proposing to change the "Show Full Games" filter to "Filter Open Games" and have that disabled by default.
The use case of that filter is now to only list games that are waiting for players.

Test Plan

In case of having three accounts, join the lobby with one account, host a game,
join the lobby with the second account and check that changing the player count and gamestate has the correct effect.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1801
Build 2851: Vulcan BuildJenkins
Build 2850: arc lint + arc unit

Event Timeline

elexis created this revision.Mar 12 2017, 11:45 PM

2013-11-10-QuakeNet-#0ad.log

22:15 < scythetwirler> alpha123: I think show full servers should be checked by default.
22:15 < alpha123> scythetwirler: I don't.
22:15 < scythetwirler> it feels weird to have a have disappear on you?
22:15 < scythetwirler> as if the host quit?
22:16 <@leper> It makes no sense to show full games
22:16 < Oimat> +1 leper
22:16 <@leper> (as joining them and starting will not make the game happy)
22:16 <@leper> (which isn't a good argument for hiding it, but preventing crashes that are bound to happen is a nice side effect)
22:17 < scythetwirler> alpha123's game just disappeared :P I think that's misleading.
22:17 < scythetwirler> I'd rather just gray out the join game button if it is full.
22:18 < scythetwirler> (or has started)
22:19 < scythetwirler> It's easier to see who is in what game.
22:19 < scythetwirler> (also I'd like to be able to see games that have started)

From 2014-11-16-QuakeNet-#0ad-dev.log

22:40 < WildfireBot> News from 0adsvn: Revision 15978: The show full games filter in the lobby should be off by default. http://trac.wildfiregames.com/changeset/15978/ps
22:41 <@leper> alpha123: ^ why?
22:41 <@leper> so users complain about the lobby being dead again?
22:41 < alpha123> leper: Because otherwise people end up joining full games
22:42 <@leper> oh full games, not ongoing
22:42 < alpha123> right
22:42 <@leper> does that change anything about ongoing games?
22:42 < alpha123> no, I don't think those are ever displayed
22:42 <@leper> You might want to start A17 sometime
22:42 < alpha123> I just installed it
22:43 <@leper> go in the lobby and check :P
22:43 < alpha123> (and opened the lobby and noticed that Show Full Games was still on by default, so I looked and changed it in SVN :P )
22:43 <@leper> We display them because otherwise users complain a lot about no games
22:43 < alpha123> Is there a way to kick players from a game yet?
22:44 <@leper> If ongoing (even if full) games aren't shown now I'd consider that a bug
22:44 <@leper> no
22:44 < alpha123> otherwise I think we should leave it off, as it's somewhat annoying when people are trying to have a duel and 3 more people jump in
22:44 <@leper> you can set them as an observer or do other things but nothing in-game
22:44 < alpha123> granted that doesn't crash the game anymore so it's not a big deal
22:45 < alpha123> If they complain about there being no games, I think they're more likely meaning no *open* games
22:45 <@leper> I have no issue with not showing full games that are not yet started
22:45 <@leper> alpha123: hanging around in the lobby might change that
22:45 <@leper> if there are in-progress games you at least see activity and not just some people with a busy status

http://trac.wildfiregames.com/ticket/3143#comment:1

"Filter open games" seems a bit ambiguous (filter out?). Perhaps "Only show open games"?

"Filter open games" seems a bit ambiguous (filter out?). Perhaps "Only show open games"?

What could it realistically be confused with?

Vulcan added a subscriber: Vulcan.Mar 13 2017, 12:32 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/511/ for more details.

"Filter out open games" or "filter by leaving only the open games in."

"Filter out open games" or "filter by leaving only the open games in."

Would users realistically expect that checking the "Filter open games" button shows all games that are not open?
"Show open games" would solve it?

scythetwirler added a comment.EditedMar 13 2017, 2:16 AM

Would make it easier for the translators (and anyone who isn't fluent in English)

Show only open games would be more precise.

elexis updated this revision to Diff 785.Mar 13 2017, 2:20 AM

String change to "Show only open games"

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/512/ for more details.

leper resigned from this revision.Mar 22 2017, 10:09 PM
elexis updated this revision to Diff 2023.May 19 2017, 2:06 PM

Forgot to include the XML file

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1249/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1250/ for more details.

mapkoc added a subscriber: mapkoc.EditedMay 20 2017, 6:35 PM

I tested this patch and it works as expected.
By default it shows all games when you join the lobby.
When you check the "Show only open games" filter, it hides all games already started plus all full games still in setup.

I find this feature convenient. I always check full games as soon as log in. I guess new players might prefer filtering to see only available games to join.

I tested by first login in to a21 lobby with pidgin and then to a22 with pyrogenesis, so that I can see the a21 list of ongoing games. (Rev 19611)

When joining:


After filtering:

Interesting hack to fill the svn gamelist with games from the most recent release. Thanks for the testing.

mapkoc accepted this revision.May 20 2017, 6:56 PM
This revision is now accepted and ready to land.May 20 2017, 6:56 PM
This revision was automatically updated to reflect the committed changes.

If there are players who are solely interested in joinin open games and hence always check this checkbox, we can also save this flag in the config and restore it upon login. I'm convinced this is a small minority and that this default is the correct decision.
Even those players may want to check the running games in the lobby to wait for other players to finish their game (as they can now see if someone is defeated or offline in the game selection).