Update the teamboni in civ.jsons (This can be seen in the History tab and the gamesetup civinfo.
Details
- Reviewers
fatherbushido - Commits
- rP19673: Update teamboni in civ.jsons
- Trac Tickets
- #4082
Look at it.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- https://svn.wildfiregames.com/svn/ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 1916 Build 3030: Vulcan Build (Windows) Jenkins Build 3029: Vulcan Build Jenkins Build 3028: arc lint + arc unit
Event Timeline
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/1094/ for more details.
binaries/data/mods/public/simulation/data/civs/brit.json | ||
---|---|---|
73 | Please don't follow what previous people have done to our loading screen tooltips and civ files. |
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/1277/ for more details.
binaries/data/mods/public/simulation/data/civs/maur.json | ||
---|---|---|
71 | name was changed | |
binaries/data/mods/public/simulation/data/civs/rome.json | ||
65–66 | You can use that (source: Design Doc) |
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/1323/ for more details.
Build is green
Executing section Default... Executing section Source... Executing section JS... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/16/ for more details.
Thanks for the update.
I would perhaps update also a bit the Athenian and the Ptolemian ones. (And while at it remove the history and put the effect in their related aura files). Sorry I should have said it before :/
You did the choice to put numbers in those files, it's ok imo for the moment as it's the only place where that could be shown.
Was the last comment, I promise ;-)
I already changed too much strings, translators will hate me :/
I'm not that good with the english language, so I thought you might do that better... ;)
What should be updated?
(And while at it remove the history and put the effect in their related aura files). Sorry I should have said it before :/
Huh? You mean I should fully remove the History and Description of those civ.jsons?
You did the choice to put numbers in those files, it's ok imo for the moment as it's the only place where that could be shown.
I would perhaps update also a bit the Athenian and the Ptolemian ones.
What should be updated?
(And while at it remove the history and put the effect in their related aura files). Sorry I should have said it before :/
Huh? You mean I should fully remove the History and Description of those civ.jsons?
No No, in the team bonus aura json files
The aura files have no history. From where should the effect be put into the aura files?
(Sorry, I don't understand, what you want...)
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/63/ for more details.
Build has FAILED
Link to build: http://jw:8080/job/phabricator/1384/
See console output for more information: http://jw:8080/job/phabricator/1384/console