As mentioned in #3734, some fields of the appdata file (which is used for various software centers) can be corrected.
Details
- Reviewers
elexis - Commits
- rP21809: Update AppData, fixes #5006, refs #3734.
- Trac Tickets
- #3734
The specs can be found at https://www.freedesktop.org/software/appstream/docs/
Relevant are:
2.1. Generic Component 2.2. Desktop Applications
It can be validated with
appstream-util validate-strict build/resources/0ad.appdata.xml
and
appstreamcli validate build/resources/0ad.appdata.xml
The appstream version used is very crucial, as I tested with three versions and all of them complain about different things.
I'm not sure about the id and launchable tag and the filename of the desktop file.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 2424 Build 4061: Vulcan Build (Windows) Jenkins Build 4060: Vulcan Build Jenkins Build 4059: arc lint + arc unit
Event Timeline
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1638/ for more details.
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/244/ for more details.
build/resources/0ad.appdata.xml | ||
---|---|---|
7 | Notice <name> may not end with a period |
changed project and metadata license, added ssl
Validation output of AppStream CLI tool version: 0.11.0:
#W - 0ad.appdata.xml:com.wildfiregames.0ad:9 Found invalid tag: 'launchable'. Non-standard tags must be prefixed with "x-". Validation failed: warnings: 1
though the specs recommend that field.
There is at least a link with http that should be changed to https (the first screenshot one).
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI... Executing section Python... Executing section Perl...
http://jw:8080/job/phabricator_lint/246/ for more details.
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1641/ for more details.
build/resources/0ad.appdata.xml | ||
---|---|---|
36 | http -> https |
I figured that from the last comment already ;-)
What I still really would like input on would be the id and launchable field.
build/resources/0ad.appdata.xml | ||
---|---|---|
7 | Periods at the end allowed, they just trigger an "info":
https://github.com/ximion/appstream/commit/03c03425f7502878f8054c9231a3858a2f8940ac |
build/resources/0ad.appdata.xml | ||
---|---|---|
41 | Gnee. |
Fixed a tag, used a smaller screenshot, added Kushites.
The validation tool only complains about a missing <translation> tag but seeing the specification has a placeholder example and states it is optional, I think we don't need it.
Checked all entries against the specs, reads correct.
All properties in the specs are defined, except <icon>, <releases/>, provides, requires, recommends, project_group, developer_name, translation, suggests which seem nonessential.
Still not sure if the launchable and id part is what it wants to and I didn't run the validator tool.
build/resources/0ad.appdata.xml | ||
---|---|---|
2–9 | not sure if we need the XML comment, the url and license are present below, we could add WFG in the "developer_name" section | |
5 | would be nice to add an atlas launchable some day | |
9 | Real-time strategy? https://en.wikipedia.org/wiki/Real-time_strategy | |
14 | 13 | |
70 | Not sure if its really intense violence "Defined as characters not easily distinguishable from reality.", maybe moderate does too | |
87 | This section is giving me interesting ideas |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/450/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/451/display/redirect
Fixed things based on your comments, thanks! ?
build/resources/0ad.appdata.xml | ||
---|---|---|
2–9 | I find it nice to have such a comment, I didn't bother fixing that. | |
5 | We have it! It's in the 0ad.desktop file. | |
70 | Well realistic models of people die in mass, so... I think moderate would apply to some video game with realistic graphics where one character dies in the course of a narration. This is a game centered on war otoh. | |
87 | ? |