Page MenuHomeWildfire Games

Adjust accuracy (spread multiplier) in technologies
ClosedPublic

Authored by temple on Aug 24 2017, 11:11 PM.

Details

Summary

The spread calculation was changed in a22 but the related technologies were not. The spread used to be divided by the max range (now it's divided by a constant 100m), so when units got an increase in range they also got an increase in accuracy.

The two changes in this patch are advanced and elite promotions, changing the spread from -5% to -10%; and archery tradition, using -20% spread.

Here are some graphs showing the changes with infantry archers and slingers. (I think skirms need an accuracy nerf.) I tried to match the accuracy increases that were in a21 (because a21 seemed okay).

The other tech that directly affects spread is "bolt accuracy", which I haven't changed (at -20%). Bolt shooters are a lot more accurate in a22, but they also have a bugged splash damage. So I think we could leave it alone for now.

It's also worth considering adjusting things that change the max range, since that used to change the accuracy. For example, going from 80 to 88 max range used to multiply the spread by 80/88 = 0.91. Here are the relevant auras/techs/units: Mace hero Demetrius +10% siege range, "arrow shooters" +8 range for defense towers, and Roman siege +8 range. (There's also a relic with +20% range for skirms, or about +5 range.)

Test Plan

See if the changes are reasonable.
Let me know if we should make a spread adjustment with the other auras/techs/units/relics too.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

temple created this revision.Aug 24 2017, 11:11 PM
elexis added a subscriber: elexis.Aug 24 2017, 11:58 PM

I wonder if we should format the whitespace beforehand (only one propery per line) to make the diffs only contain that one changed line instead of some 20 lines (each time someone wants to change a number).
and then ask Grugnas and borg-, maybe PhyZic and causative for review.

Among the author (temple) and the reviewers (borg-, Grugnas) who will commit that?

Since archers shooting from longer distance have same accuracy as before, the first summary lane is self explanatory and honestly i don't feel the need of a spread increase for such a technology, while i agree that having higher accuracy as reward for promotion is reasonable despite the fact that ranged units doesn't seem to have accuracy issues even at basic rank.

fatherbushido requested changes to this revision.Oct 23 2017, 4:18 PM

ok

binaries/data/mods/public/simulation/data/technologies/advanced_unit_bonus.json
4

I would let the number (at least the 4m, the second one seems indeed dubious)

16

Not critical (I read arguments), but why not

22

(Editing that file is always... (I don't know the word.))

binaries/data/mods/public/simulation/data/technologies/elite_unit_bonus.json
4

I would add the numbers here

binaries/data/mods/public/simulation/data/technologies/mauryans/special_archery_tradition.json
9

And better accuracy

13

That's a good idea

binaries/data/mods/public/simulation/data/technologies/persians/special_archery_tradition.json
19

(same comments)

binaries/data/mods/public/simulation/data/technologies/siege_bolt_accuracy.json
19

(If we keep number here, let's keep above)

This revision now requires changes to proceed.Oct 23 2017, 4:18 PM
temple updated this revision to Diff 3950.Oct 23 2017, 7:24 PM

(Just thinking in general, it might be nice to have the tooltips not reference particular values, so that translators wouldn't have to change the strings every time we changed the values. Units have "detailed tooltips" that show their health, attack, armor, etc., so maybe we can do a similar thing with technologies and their modifications. Some players might want to know that the range was increased by exactly 4m, and others players might not.

Some technologies have a "description", but I can't find where in the game to see that?)

In D834#38159, @temple wrote:

(Just thinking in general, it might be nice to have the tooltips not reference particular values, so that translators wouldn't have to change the strings every time we changed the values. Units have "detailed tooltips" that show their health, attack, armor, etc., so maybe we can do a similar thing with technologies and their modifications. Some players might want to know that the range was increased by exactly 4m, and others players might not.

Sure all that have been discussed since years.
Currently it's done to have values in, so let values in.
It's more or less planed to have automatic modifications tooltip (which has pros and cons, the pro is what you are talking about).

Some technologies have a "description", but I can't find where in the game to see that?)

Nowhere.
I remembered having discussed of that with @s0600204, perhaps it will be included in the whole history thing.
(Same thing sh(c)ould be done for auras)

temple marked 8 inline comments as done.Nov 1 2017, 9:03 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 19 2018, 10:12 PM
This revision was automatically updated to reflect the committed changes.