Differential D1112

Move `hasSameMods` into an own file
AbandonedPublic
Actions

Authored by Imarok on Dec 5 2017, 8:04 PM.

Details

Reviewers

elexis

Summary

This will also be the place where the code of validatemods.js from D1093 will go to

Test Plan

...

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

https://svn.wildfiregames.com/public/ps/trunk

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3965
Build 6946: Vulcan Build (Windows)	Jenkins
Build 6945: Vulcan Build	Jenkins
Build 6944: arc lint + arc unit

Event Timeline

Imarok created this revision.Dec 5 2017, 8:04 PM

Executing section Default...
Executing section Source...
Executing section JS...

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

Harbormaster completed remote builds in B3965: Diff 4574.Dec 5 2017, 9:46 PM

Imarok added a child revision: D931: Filter lobby games by mod.Dec 6 2017, 12:56 PM

Imarok edited child revisions, added: D955: Check for and save mod version for savegames and replays; removed: D931: Filter lobby games by mod.

I didn't mean a single patch with move in "advance", but if your patch already changes about every line in that function, it might just as well add those in the final place.

Do that in D955

Revision Contents
Changeset List

Path

Size

binaries/

data/

mods/

mod/

gui/

common/

mod.js

22 lines

public/

gui/

common/

functions_utility_loadsave.js

23 lines

Diff 4574

View Options

binaries/data/mods/mod/gui/common/mod.js