Differential D441
D13 collateral 5: automated test-map for pathfinder and UnitMotion behavior Authored by wraitii on May 7 2017, 10:31 AM.
Details
This is a map I've created for D13. It uses trigger script to try and test some edge cases in the pathfinder. As you can see from running it, our current implementation does not pass. Should/Could be integrated in the unit tests at some points I suppose. Start the map. Report that it works as expected.
Diff Detail
Event TimelineComment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! http://jw:8080/job/phabricator/1047/ for more details. Comment Actions @elexis: do you mind if I commit this as-is? Code isn't super clean, but it's a debug map and it doesn't use rmgen or that kind of thing. Alternatively I could wait for the modifiers manager to remove the XXXtreme hack. Comment Actions The map doesn't load properly: ERROR: Failed to load entity template 'gaia/fauna_chicken' I downloaded the raw diff and the pmp file (not included in the diff). Comment Actions
What is the purpose of adding a test if it's not ensuring that our current implementation works? Adding a testmap sounds good. But it shouldn't be part of the public mod, should it? We do have special test mods: _test.sim, also some in source/.
Comment Actions
Well the purpose of this map was to show that SVN fails and D13 passes, of course. So if we commit as is, SVN still fails. That's kind of the whole point. Our pathfindre/UnitMotion implementation is a failure.
Comment Actions Upload PmP, fix the map. It doesn't actually work that well since I can't properly detect when units stop moving without D13, so that's annoying. Test 211 also succeeds when it should fail, and some tests don't fail explicitly because of the moving thing. But you can still notice a unit manages to get inside an impassable forest and another can't manager to get around a wall of unit. Comment Actions Executing section Default... Executing section Source... Executing section JS... binaries/data/mods/public/maps/scenarios/Pathfinding_integrated_testmap_triggers.js | 105| » } | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/maps/scenarios/Pathfinding_integrated_testmap_triggers.js | 197| » } | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/maps/scenarios/Pathfinding_integrated_testmap_triggers.js | 198| }·(Trigger)) | | [NORMAL] JSHintBear: | | Missing semicolon. Comment Actions Successful build - Chance fights ever on the side of the prudent. Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Checking XML files... Comment Actions I did apply the patch and added the raw pmp file from this ticket. Or where should I get the pmp file from? Tested the 2nd patch with the the proper base revision r20628 and it still throws with similar errors: ERROR: RelaxNGValidator: Validation error: units/maur_infantry_archer_b:1: Element Entity has extra content: RangeOverlayRenderer ERROR: RelaxNGValidator: Validation failed for '(null)' ERROR: Failed to validate entity template 'units/maur_infantry_archer_b' ERROR: Failed to load entity template 'units/maur_infantry_archer_b' ERROR: RelaxNGValidator: Validation error: structures/maur_house:1: Did not expect element RangeOverlayRenderer there ERROR: RelaxNGValidator: Validation error: structures/maur_house:1: Element Entity has extra content: RangeOverlayRenderer ERROR: RelaxNGValidator: Validation failed for '(null)' ERROR: Failed to validate entity template 'structures/maur_house' ERROR: Failed to load entity template 'structures/maur_house' Comment Actions My fault, didn't compile, sry. Test 393 fails while the other 19 succeed. Requested changes:
I wonder about the seemingly arbitrary test numbers. Is it the unit ID? In general I find such a map useful to detect flaws in future pathfinding related patches. | ||||||||||||||||||||||||||||||||||||||||