Page MenuHomeWildfire Games

Optional highlight user and buddies in lobby
Changes PlannedPublic

Authored by ffffffff on Aug 18 2017, 4:49 PM.

Details

Reviewers
elexis
Trac Tickets
#4967
Summary

Now colors configurable in user config (suggesting buddy colors in default.cfg).

Priorize user in buddy sorted playerlist to the highest position (according to sort order ofc) and make buddies to default sort.

Also priorize user player in status and buddy sorted playerlist. Put user player among players with same status or buddy status to the highest/lowest position (according to the sort order).

Highlight the user status und rating with a user color (blue). (user symbol ("‣") abandon atm).

Highlight game, where the user is listed as player in blue color and keep the game in first position in gamelist, so the user can easily find the game back, where he has been playing in, if he got disconnect (This could be also be done by D1091).

Highlight buddies and their games in highlighted color (pastel like).

Priorize user and user games in list to the first position when in sort got same

appears (nice color : ) )

option

Test Plan

discuss

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ffffffff created this revision.Aug 18 2017, 4:49 PM
elexis edited edge metadata.Aug 18 2017, 5:26 PM

Didn't understand what it does. It displays the currently logged in user as a buddy of himself?

In D799#31768, @elexis wrote:

Didn't understand what it does. It displays the currently logged in user as a buddy of himself?

it displays you and when you were in a game it display that game in the gamelist with the user symbol so you easy find the game.

if you got disconnect from a game, its then very easy to refind the game in the gamelist and to reconnect to it.

ffffffff edited the summary of this revision. (Show Details)Aug 18 2017, 5:38 PM
ffffffff retitled this revision from Having user icon in playerlist and gamelist to Highlight user and user games in lobby in buddy column.Sep 7 2017, 5:52 PM
ffffffff edited the summary of this revision. (Show Details)
ffffffff added a reviewer: temple.
ffffffff retitled this revision from Highlight user and user games in lobby in buddy column to Highlight user and user games in lobby.
ffffffff retitled this revision from Highlight user and user games in lobby to Highlight user and user games (in the lobby).
ffffffff edited the summary of this revision. (Show Details)
ffffffff edited the summary of this revision. (Show Details)Sep 7 2017, 5:59 PM
temple added a comment.Sep 7 2017, 9:00 PM

If the goal is to alert a player to the game they were disconnected from (or quit), I think a better way would be to put the game name in a different color (e.g. blue), because the triangle is too similar to the dot. Could do both, of course.

For the triangle in the user list, I guess it's okay (but it should be first in the list when you sort by buddies), but it's probably only relevant for people who log in with multiple names and forget who they are. :)

For D378, I don't think colored dots are appropriate, since dots now denote buddies. Grayed-out chat is the better thing to do (white if online, gray if busy/away/offline).
For D801, I don't like the buddy numbers or the observer column, it's too much clutter. You can click on a game to get the same information in the side panel.
For D857, I like idea of a teams column but what if there's an eight-person free-for-all? "1v1v1v1v1v1v1v1"? So I think I'm against that too.
But that's just my opinions, I don't feel too strongly about any of them.

The idea I mentioned to you last night was to add for example a chat message when you join a game that says the title of the game, like "ffffffff's game". Sometimes people say "no walls, no wonders" and that type of stuff, but once you join the game you don't see the title anywhere. Hmm, maybe add an option to retitle the game, too? Just some ideas.

If the idea is to find the game where the player was playing, i think it would be better to display a pop-up to reconnect to the game when the player is in the lobby.

ffffffff updated this revision to Diff 4466.EditedNov 30 2017, 3:09 PM

as wished by temple made username and game in where user went offline in 'blue' color

ffffffff edited the summary of this revision. (Show Details)Nov 30 2017, 3:12 PM
ffffffff edited the summary of this revision. (Show Details)Dec 4 2017, 7:07 PM
ffffffff updated this revision to Diff 4737.Dec 12 2017, 2:12 AM
ffffffff retitled this revision from Highlight user and user games (in the lobby) to Highlight user and user games and priorize them in list (in the lobby).
ffffffff retitled this revision from Highlight user and user games and priorize them in list (in the lobby) to Priorize user in lobby playerlist to the top and give user color.Dec 13 2017, 12:23 PM
ffffffff edited the summary of this revision. (Show Details)
ffffffff edited the test plan for this revision. (Show Details)
ffffffff updated this revision to Diff 4796.Dec 16 2017, 1:54 PM

Optional user highlight in lobby

ffffffff retitled this revision from Priorize user in lobby playerlist to the top and give user color to Optional user highlight in lobby.Dec 16 2017, 1:55 PM
ffffffff edited the summary of this revision. (Show Details)
ffffffff updated this revision to Diff 4797.Dec 16 2017, 1:58 PM
temple resigned from this revision.Dec 16 2017, 4:21 PM

Blue looks nice. But I don't have a strong enough opinion about these things to review.

yea np lets see if interest

ffffffff retitled this revision from Optional user highlight in lobby to Optional user highlight in lobby and priorize user in status and buddy sort to first and user games to first.Dec 23 2017, 4:49 PM
ffffffff edited the summary of this revision. (Show Details)
ffffffff edited the test plan for this revision. (Show Details)
ffffffff added a subscriber: mapkoc.

Can the blue game (you are offline from) appear first in the list? That would be even more useful.

Yes. Indeed. This is happening in line 950-952 in lobby.js. It's priorizing the user's game, where he is offline. So you find immediately your game back, where you dropped or disconnected.

OK. Sorry i had no way to test dropping of anyone's game and see list sorted (since svn lobby empty.)

ffffffff updated this revision to Diff 5044.Jan 2 2018, 6:32 PM
ffffffff retitled this revision from Optional user highlight in lobby and priorize user in status and buddy sort to first and user games to first to Optional highlight user and buddies in lobby and priorize user and user games in list.
ffffffff edited the summary of this revision. (Show Details)

Buddies highlight.

ffffffff removed a reviewer: temple.Jan 2 2018, 6:32 PM
ffffffff added a subscriber: Dunedan.
ffffffff added a subscriber: user1.Jan 2 2018, 6:38 PM
mapkoc added a comment.Jan 2 2018, 7:58 PM

It is very hard to read dark blue on dark background (our own nick)

ffffffff added a comment.EditedJan 2 2018, 9:13 PM

yea its from first player slot color likely. but the nick is not colored only status and rating.

u like more light pink for user player color? or yellow. XD maybe golden

gentz added a subscriber: gentz.Jan 4 2018, 4:27 AM
ffffffff updated this revision to Diff 5253.Jan 12 2018, 7:26 PM
ffffffff retitled this revision from Optional highlight user and buddies in lobby and priorize user and user games in list to Optional highlight user and buddies in lobby.
ffffffff edited the summary of this revision. (Show Details)

make colors configurable in user config -> suggesting colors in default.cfg

ffffffff updated this revision to Diff 5254.EditedJan 12 2018, 7:29 PM

Suggesting brighter colors from feedback from players.

different sorts to look colors: https://imgur.com/a/6j9EN

ffffffff edited the summary of this revision. (Show Details)Jan 12 2018, 7:30 PM
ffffffff edited the summary of this revision. (Show Details)Jan 13 2018, 6:42 PM

Now the colors are nice. Thanks

ffffffff updated the Trac tickets for this revision.Jan 18 2018, 7:10 AM
elexis added inline comments.Jan 27 2018, 12:34 AM
binaries/data/config/default.cfg
413

What if someone sets a non-color attribute? If we do this kind of thing it should not fall apart. Then we need a default color in JS again. Plus code to test if a color is valid. Complexity..

binaries/data/mods/public/gui/lobby/lobby.js
33

Can be moved to default.cfg too if the other ones are there too I suppose

409

duplication / hardcoding. Use for i in g_GameColors...

412

same

605

I believe the default value must be deleted as it is a relic from buggycode times.
XML should specify the default.

622

Can't we do the buddy test here?

673

Don't colorize the empty string

949

I didn't know we had a way to tag players as users.

1006

coloredText redundant with guiTags, ought to be deprecated

binaries/data/mods/public/gui/lobby/lobby_panels.xml
13

keep

binaries/data/mods/public/gui/options/options.json
417

Highlight buddies

ffffffff marked 9 inline comments as done.EditedJan 29 2018, 10:06 AM

ok default name sort ofc buddy not everyone use

binaries/data/mods/public/gui/common/global.xml
111 ↗(On Diff #5572)

part of test

not working

will delete

binaries/data/mods/public/gui/lobby/lobby.js
406

some valdidate color test

408

this is sadfuly not working fall apart anyway

622

what do you mean with buddy test? L737? why not there?

elexis added inline comments.Feb 1 2018, 9:59 PM
binaries/data/mods/public/gui/lobby/lobby.js
622

I think I misread the patch, nevermind unless I recall what I meant eventually.

ffffffff updated this revision to Diff 5634.Feb 1 2018, 10:13 PM
ffffffff added inline comments.
binaries/data/mods/public/gui/common/color.js
154 ↗(On Diff #5634)

maybe name getValidColor
can be done by the commiter though

ffffffff added inline comments.Feb 5 2018, 9:08 AM
binaries/data/mods/public/gui/lobby/lobby.js
622

np
further comments?

maybe making this color highlighting default and rid off option from options but keep user config?

ffffffff planned changes to this revision.Feb 10 2018, 6:45 PM
ffffffff added inline comments.
binaries/data/mods/public/gui/lobby/lobby.js
32

remove empty attributes or set them default color