Page MenuHomeWildfire Games
Differential D1111

setFont(text, font) function suggestion
Needs ReviewPublic
Actions

Authored by ffffffff on Dec 5 2017, 7:08 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Replace all '[font="font-name"]' + text + '[/font]' tags by single function setFont().

Add setColorFont(text, color, font) function.

Test Plan

test

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ffffffff created this revision.Dec 5 2017, 7:08 PM
ffffffff added inline comments.
binaries/data/mods/mod/gui/common/guitags.js
4

only suggestion with extra font parameter, not used now (on this function)

12

only suggestion with extra color parameter, not used now (on this function)

elexis added inline comments.Dec 5 2017, 7:13 PM
binaries/data/mods/mod/gui/common/guitags.js
12

setColor, setFont and setFontColor(text, font, color)?

ffffffff added inline comments.Dec 5 2017, 7:46 PM
binaries/data/mods/mod/gui/common/guitags.js
12

Y!:)

elexis resigned from this revision.Dec 12 2017, 8:38 PM
ffffffff updated this revision to Diff 4872.Dec 22 2017, 2:24 AM
ffffffff retitled this revision from fontText(text, font) function suggestion to setFont(text, font) function suggestion.
ffffffff edited the summary of this revision. (Show Details)
ffffffff removed a reviewer: elexis.
ffffffff added a subscriber: elexis.
ffffffff updated this revision to Diff 4873.Dec 22 2017, 2:28 AM

add setColorFont() function

ffffffff edited the summary of this revision. (Show Details)Dec 22 2017, 2:29 AM
ffffffff updated this revision to Diff 4876.Dec 22 2017, 2:41 AM
elexis added a comment.Dec 27 2017, 3:24 PM

The function from D1167 should be used and all font values should become globals IMO.

binaries/data/mods/public/gui/common/tooltips.js
714

can we kill fontStart fontEnd?

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
mod/
gui/
common/
8 lines
public/
gui/
civinfo/
6 lines
common/
2 lines
4 lines
21 lines
credits/
12 lines
gamesetup/
2 lines
lobby/
2 lines
pregame/
12 lines
session/
6 lines
8 lines
8 lines
5 lines

Diff 4876

View Options

binaries/data/mods/mod/gui/common/guitags.js

Loading...
View Options

binaries/data/mods/public/gui/civinfo/civinfo.js

Loading...
View Options

binaries/data/mods/public/gui/common/functions_global_object.js

Loading...
View Options

binaries/data/mods/public/gui/common/gamedescription.js

Loading...
View Options

binaries/data/mods/public/gui/common/tooltips.js

Loading...
View Options

binaries/data/mods/public/gui/credits/credits.js

Loading...
View Options

binaries/data/mods/public/gui/gamesetup/gamesetup.js

Loading...
View Options

binaries/data/mods/public/gui/lobby/lobby.js

Loading...
View Options

binaries/data/mods/public/gui/pregame/mainmenu.js

Loading...
View Options

binaries/data/mods/public/gui/session/selection_details.js

Loading...
View Options

binaries/data/mods/public/gui/session/selection_panels.js

Loading...
View Options

binaries/data/mods/public/gui/session/selection_panels_helpers.js

Loading...
View Options

binaries/data/mods/public/gui/session/session.js

Loading...
Wildfire Games · Phabricator