Page MenuHomeWildfire Games

Allow to lock teams in scenarios
Needs ReviewPublic

Authored by mimo on Jan 22 2018, 6:48 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Trac Tickets
#4817
Summary

see discussion on #4817

Test Plan

check that the patch does what it is supposed to do

Diff Detail

Event Timeline

mimo created this revision.Jan 22 2018, 6:48 PM
Owners added a subscriber: Restricted Owners Package.Jan 22 2018, 6:48 PM
elexis added a subscriber: elexis.Feb 19 2018, 5:38 PM

I'm reluctant with this. The idea of scenario maps must have been at one point to let the map lock every setting.
But Im not sure anymore if we can't delete the maptype altogether eventually and let every map support or not support any property.
Then it would remain consistent for all properties.

In D1246#53684, @elexis wrote:

I'm reluctant with this. The idea of scenario maps must have been at one point to let the map lock every setting.

Exactly. Team/diplomacy settings weren't supposed to change at all. It's a scenario after all, so if there are teams, that is enforced by the scenario config.