Page MenuHomeWildfire Games

Rated game column in lobby
Needs ReviewPublic

Authored by ffffffff on Jan 19 2018, 12:41 AM.

Details

Reviewers
elexis
Summary

Maybe needs update only interesting for 1v1 atm.

Test Plan

test

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ffffffff created this revision.Jan 19 2018, 12:41 AM
ffffffff edited the summary of this revision. (Show Details)
elexis requested changes to this revision.Jan 25 2018, 9:22 PM

I'm not sure if we want it, but ok if it's optional.
It must become optional or dependent on the graphics size. As seen on the screenshot its not ideal for 1024x768.

binaries/data/mods/public/gui/lobby/lobby.js
489

See here. I wouldn't be surprised if the magic numbers here are now wrong. Vladislav has a patch for C++ column sizing, but it was never finished.

This revision now requires changes to proceed.Jan 25 2018, 9:22 PM
ffffffff updated this revision to Diff 5562.Jan 29 2018, 5:49 AM

@elexis You think i can combine this with the rating game column showing option in the lobby?

ffffffff updated this revision to Diff 5564.Jan 29 2018, 6:02 AM

maybe we should go only for 1v1 rated so number of player check from game if == 2 as this are the only games that gets rated atm