Currently build with --without-pch and/or with HAVE_PCH 0 does not build on windows because of missing includes
Details
- Reviewers
vladislavbelov - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP21964: Fix build without PCH for some targets.
test that it builds with --without-pch falg and on windows also set HAVE_PCH 0 in \source\lib\sysdep\compiler.h
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 6081 Build 10125: Vulcan Build Jenkins Build 10124: arc lint + arc unit
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/173/display/redirect
source/graphics/ShaderDefines.h | ||
---|---|---|
25 | last change to this file was rP15481 2014-07-03, I thought build without PCH was working at least last year sometime? Itms, leper and Imarok had compiled with that too afaik. Maybe it's only on windows. |
source/graphics/ShaderDefines.h | ||
---|---|---|
25 | to this file maybe, but it is possible that precompiled politic changed, because when HAVE PCH is 0, the file with <map> and other includes is whole ignored and not included |
source/graphics/ShaderDefines.h | ||
---|---|---|
25 | Yeah I guess it did compile with a peculiar bug, or maybe they didn't have it by then so it compiled fine :) |
source/graphics/ShaderDefines.h | ||
---|---|---|
25 | next thing about date when it broke is that h files are not compiled directly but included to the cpp and they are compiled so since they had missing includes or used pch it worked. But this h file requiers map to work correctly so I gave it here instead before every include of this h in cpp |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/198/display/redirect
update wnuma.cpp because year in file have changed
and could we have this pushed pls? Another patch is waiting for this.
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/508/display/redirect
@Angen does the test project build for you without pch ?
When setting (→ is for replacing)
In lib/config.h
# define CONFIG_ENABLE_PCH 1 → 0 // improve build performance
and in lib/sysdep/compiler.h
// are PreCompiled Headers supported? #if MSC_VERSION # define HAVE_PCH 1 → 0 #elif defined(USING_PCH) # define HAVE_PCH 1 → 0 #else # define HAVE_PCH 0 #endif
I get four C2317 errors about missing try catch in the test project