Page MenuHomeWildfire Games
Differential D1814

Unused iterator in Xeromyces
ClosedPublic
Actions

Authored by Silier on Apr 3 2019, 9:28 PM.

Details

Reviewers
vladislavbelov
Commits
rP22170: Removes unused iterator in Xeromyces. Its usage was removed in rP16888.
Summary

"std::set<std::string>::iterator it" is local variable which is never used or initialised in its scope

iterator functionality removed in rP16888

Test Plan

:)

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7096
Build 11583: Vulcan BuildJenkins
Build 11582: arc lint + arc unit

Event Timeline

Silier created this revision.Apr 3 2019, 9:28 PM
Vulcan added a subscriber: Vulcan.Apr 3 2019, 9:30 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1164/display/redirect

Harbormaster completed remote builds in B7096: Diff 7663.Apr 3 2019, 9:30 PM
Silier added a reviewer: vladislavbelov.Apr 4 2019, 7:12 AM
Silier edited the summary of this revision. (Show Details)Apr 6 2019, 6:21 PM
Silier edited the summary of this revision. (Show Details)
vladislavbelov accepted this revision.Apr 7 2019, 8:21 PM

I tested the patch and it works. Since the problem is reported by cppcheck (probably by some compiler too) I don't see a reason to refactor the whole file, because it's a bit other problem.

This revision is now accepted and ready to land.Apr 7 2019, 8:21 PM
Closed by commit rP22170: Removes unused iterator in Xeromyces. Its usage was removed in rP16888. (authored by vladislavbelov). · Explain WhyApr 7 2019, 8:23 PM
This revision was automatically updated to reflect the committed changes.
vladislavbelov added a comment.Apr 7 2019, 9:31 PM

@Angen thank you for the patch!

Revision Contents
Changeset List

PathSize
source/
ps/
XML/
3 lines

Diff 7663

View Options

source/ps/XML/Xeromyces.cpp

Loading...
Wildfire Games · Phabricator