It improves readability of the code when a function that seems like it does a simple check actually only does a simple check and the caller is the one changing state.
I think I could actually make it const now, need to check.
Differential D1884
UnitMotion - improve the name of a function and move stateful effects at the caller. wraitii on May 13 2019, 9:05 PM. Authored by Tags None Subscribers None
Details
It improves readability of the code when a function that seems like it does a simple check actually only does a simple check and the caller is the one changing state. I think I could actually make it const now, need to check. Look at the code.
Diff Detail
Event TimelineComment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/1395/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/1444/display/redirect |