This uses trigger to create some scientific test cases for unit motion (the whole unitAI->Motion->Pathfinders stack)
On SVN we get some units stuck.
Differential D1892
Add unit motion integration test map wraitii on May 15 2019, 9:16 PM. Authored by
Details
This uses trigger to create some scientific test cases for unit motion (the whole unitAI->Motion->Pathfinders stack) On SVN we get some units stuck. Review code
Diff Detail
Event TimelineComment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (dot-notation): | | ["single_unit"] is better written in dot notation. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 25| 25| | 26| 26| var experiments = {}; | 27| 27| | 28| |-experiments["single_unit"] = { | | 28|+experiments.single_unit = { | 29| 29| "spawn": () => { | 30| 30| WalkTo(100, 200, QuickSpawn(gx, 100, "units/athen_infantry_marine_archer_b")); | 31| 31| } | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 29| 29| "spawn": () => { | 30| 30| WalkTo(100, 200, QuickSpawn(gx, 100, "units/athen_infantry_marine_archer_b")); | 31| 31| } | 32| |-} | | 32|+}; | 33| 33| | 34| 34| experiments["two_followers"] = { | 35| 35| "spawn": () => { | | [NORMAL] ESLintBear (dot-notation): | | ["two_followers"] is better written in dot notation. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 31| 31| } | 32| 32| } | 33| 33| | 34| |-experiments["two_followers"] = { | | 34|+experiments.two_followers = { | 35| 35| "spawn": () => { | 36| 36| WalkTo(gx, 200, QuickSpawn(gx, 100, "units/athen_infantry_marine_archer_b")); | 37| 37| WalkTo(gx, 204, QuickSpawn(gx, 104, "units/athen_infantry_marine_archer_b")); | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 36| 36| WalkTo(gx, 200, QuickSpawn(gx, 100, "units/athen_infantry_marine_archer_b")); | 37| 37| WalkTo(gx, 204, QuickSpawn(gx, 104, "units/athen_infantry_marine_archer_b")); | 38| 38| } | 39| |-} | | 39|+}; | 40| 40| | 41| 41| experiments["follow_faster"] = { | 42| 42| "spawn": () => { | | [NORMAL] ESLintBear (dot-notation): | | ["follow_faster"] is better written in dot notation. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 38| 38| } | 39| 39| } | 40| 40| | 41| |-experiments["follow_faster"] = { | | 41|+experiments.follow_faster = { | 42| 42| "spawn": () => { | 43| 43| WalkTo(gx, 200, QuickSpawn(gx, 100, "units/athen_cavalry_swordsman_a")); | 44| 44| WalkTo(gx, 204, QuickSpawn(gx, 104, "units/athen_infantry_marine_archer_b")); | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 43| 43| WalkTo(gx, 200, QuickSpawn(gx, 100, "units/athen_cavalry_swordsman_a")); | 44| 44| WalkTo(gx, 204, QuickSpawn(gx, 104, "units/athen_infantry_marine_archer_b")); | 45| 45| } | 46| |-} | | 46|+}; | 47| 47| | 48| 48| experiments["group"] = { | 49| 49| "spawn": () => { | | [NORMAL] ESLintBear (dot-notation): | | ["group"] is better written in dot notation. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 45| 45| } | 46| 46| } | 47| 47| | 48| |-experiments["group"] = { | | 48|+experiments.group = { | 49| 49| "spawn": () => { | 50| 50| WalkTo(gx, 200, QuickSpawn(gx, 100, "units/athen_infantry_marine_archer_b")); | 51| 51| WalkTo(gx, 200, QuickSpawn(gx, 101, "units/athen_infantry_marine_archer_b")); | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 59| 59| WalkTo(gx, 200, QuickSpawn(gx+3, 100, "units/athen_infantry_marine_archer_b")); | 60| 60| WalkTo(gx, 200, QuickSpawn(gx+3, 101, "units/athen_infantry_marine_archer_b")); | 61| 61| } | 62| |-} | | 62|+}; | 63| 63| | 64| 64| experiments["single_unit_building"] = { | 65| 65| "spawn": () => { | | [NORMAL] ESLintBear (dot-notation): | | ["single_unit_building"] is better written in dot notation. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 61| 61| } | 62| 62| } | 63| 63| | 64| |-experiments["single_unit_building"] = { | | 64|+experiments.single_unit_building = { | 65| 65| "spawn": () => { | 66| 66| QuickSpawn(gx, 140, "structures/athen_house") | 67| 67| WalkTo(gx, 200, QuickSpawn(gx, 100, "units/athen_infantry_marine_archer_b")); | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 63| 63| | 64| 64| experiments["single_unit_building"] = { | 65| 65| "spawn": () => { | 66| |- QuickSpawn(gx, 140, "structures/athen_house") | | 66|+ QuickSpawn(gx, 140, "structures/athen_house"); | 67| 67| WalkTo(gx, 200, QuickSpawn(gx, 100, "units/athen_infantry_marine_archer_b")); | 68| 68| } | 69| 69| } | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 66| 66| QuickSpawn(gx, 140, "structures/athen_house") | 67| 67| WalkTo(gx, 200, QuickSpawn(gx, 100, "units/athen_infantry_marine_archer_b")); | 68| 68| } | 69| |-} | | 69|+}; | 70| 70| | 71| 71| experiments["single_unit_pass_nopass"] = { | 72| 72| "spawn": () => { | | [NORMAL] ESLintBear (dot-notation): | | ["single_unit_pass_nopass"] is better written in dot notation. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 68| 68| } | 69| 69| } | 70| 70| | 71| |-experiments["single_unit_pass_nopass"] = { | | 71|+experiments.single_unit_pass_nopass = { | 72| 72| "spawn": () => { | 73| 73| WalkTo(gx, 200, QuickSpawn(gx, 100, "units/athen_infantry_marine_archer_b")); | 74| 74| QuickSpawn(gx-10, 140, "structures/athen_house") | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 71| 71| experiments["single_unit_pass_nopass"] = { | 72| 72| "spawn": () => { | 73| 73| WalkTo(gx, 200, QuickSpawn(gx, 100, "units/athen_infantry_marine_archer_b")); | 74| |- QuickSpawn(gx-10, 140, "structures/athen_house") | | 74|+ QuickSpawn(gx-10, 140, "structures/athen_house"); | 75| 75| QuickSpawn(gx+10, 140, "structures/athen_house") | 76| 76| QuickSpawn(gx-8, 170, "structures/athen_house") | 77| 77| QuickSpawn(gx+8, 170, "structures/athen_house") | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 72| 72| "spawn": () => { | 73| 73| WalkTo(gx, 200, QuickSpawn(gx, 100, "units/athen_infantry_marine_archer_b")); | 74| 74| QuickSpawn(gx-10, 140, "structures/athen_house") | 75| |- QuickSpawn(gx+10, 140, "structures/athen_house") | | 75|+ QuickSpawn(gx+10, 140, "structures/athen_house"); | 76| 76| QuickSpawn(gx-8, 170, "structures/athen_house") | 77| 77| QuickSpawn(gx+8, 170, "structures/athen_house") | 78| 78| WalkTo(gx, 200, QuickSpawn(gx, 90, "units/athen_infantry_marine_archer_b")); | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 73| 73| WalkTo(gx, 200, QuickSpawn(gx, 100, "units/athen_infantry_marine_archer_b")); | 74| 74| QuickSpawn(gx-10, 140, "structures/athen_house") | 75| 75| QuickSpawn(gx+10, 140, "structures/athen_house") | 76| |- QuickSpawn(gx-8, 170, "structures/athen_house") | | 76|+ QuickSpawn(gx-8, 170, "structures/athen_house"); | 77| 77| QuickSpawn(gx+8, 170, "structures/athen_house") | 78| 78| WalkTo(gx, 200, QuickSpawn(gx, 90, "units/athen_infantry_marine_archer_b")); | 79| 79| } | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 74| 74| QuickSpawn(gx-10, 140, "structures/athen_house") | 75| 75| QuickSpawn(gx+10, 140, "structures/athen_house") | 76| 76| QuickSpawn(gx-8, 170, "structures/athen_house") | 77| |- QuickSpawn(gx+8, 170, "structures/athen_house") | | 77|+ QuickSpawn(gx+8, 170, "structures/athen_house"); | 78| 78| WalkTo(gx, 200, QuickSpawn(gx, 90, "units/athen_infantry_marine_archer_b")); | 79| 79| } | 80| 80| } | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 77| 77| QuickSpawn(gx+8, 170, "structures/athen_house") | 78| 78| WalkTo(gx, 200, QuickSpawn(gx, 90, "units/athen_infantry_marine_archer_b")); | 79| 79| } | 80| |-} | | 80|+}; | 81| 81| | 82| 82| | 83| 83| experiments["units_dense_forest"] = { | | [NORMAL] ESLintBear (dot-notation): | | ["units_dense_forest"] is better written in dot notation. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 80| 80| } | 81| 81| | 82| 82| | 83| |-experiments["units_dense_forest"] = { | | 83|+experiments.units_dense_forest = { | 84| 84| "spawn": () => { | 85| 85| WalkTo(gx, 200, QuickSpawn(gx, 100, "units/athen_infantry_marine_archer_b")); | 86| 86| WalkTo(gx, 200, QuickSpawn(gx-2, 100, "units/athen_infantry_marine_archer_b")); | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 96| 96| WalkTo(gx, 200, QuickSpawn(gx-2, 80, "units/athen_infantry_marine_archer_b")); | 97| 97| WalkTo(gx, 200, QuickSpawn(gx+2, 82, "units/athen_infantry_marine_archer_b")); | 98| 98| } | 99| |-} | | 99|+}; | 100| 100| | 101| 101| experiments["units_sparse_forest"] = { | 102| 102| "spawn": () => { | | [NORMAL] ESLintBear (dot-notation): | | ["units_sparse_forest"] is better written in dot notation. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 98| 98| } | 99| 99| } | 100| 100| | 101| |-experiments["units_sparse_forest"] = { | | 101|+experiments.units_sparse_forest = { | 102| 102| "spawn": () => { | 103| 103| gx += 10; | 104| 104| for (let i = -4; i <= 4; i += 2) | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 113| 113| for (let j = -4; j <= 4; j += 2) | 114| 114| WalkTo(gx, 200, QuickSpawn(gx+i, 80+j, "units/athen_infantry_marine_archer_b")); | 115| 115| } | 116| |-} | | 116|+}; | 117| 117| | 118| 118| | 119| 119| experiments["units_running_into_eachoter"] = { | | [NORMAL] ESLintBear (dot-notation): | | ["units_running_into_eachoter"] is better written in dot notation. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 116| 116| } | 117| 117| | 118| 118| | 119| |-experiments["units_running_into_eachoter"] = { | | 119|+experiments.units_running_into_eachoter = { | 120| 120| "spawn": () => { | 121| 121| for (let i = -4; i <= 4; i += 2) | 122| 122| for (let j = -4; j <= 4; j += 2) | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 125| 125| for (let j = -4; j <= 4; j += 2) | 126| 126| WalkTo(gx, 100, QuickSpawn(gx+i, 200+j, "units/athen_infantry_marine_archer_b")); | 127| 127| } | 128| |-} | | 128|+}; | 129| 129| | 130| 130| var gx = 100; | 131| 131| binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 28| experiments["single_unit"]·=·{ | | [NORMAL] JSHintBear: | | ['single_unit'] is better written in dot notation. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 32| } | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 34| experiments["two_followers"]·=·{ | | [NORMAL] JSHintBear: | | ['two_followers'] is better written in dot notation. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 39| } | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 41| experiments["follow_faster"]·=·{ | | [NORMAL] JSHintBear: | | ['follow_faster'] is better written in dot notation. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 46| } | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 48| experiments["group"]·=·{ | | [NORMAL] JSHintBear: | | ['group'] is better written in dot notation. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 62| } | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 64| experiments["single_unit_building"]·=·{ | | [NORMAL] JSHintBear: | | ['single_unit_building'] is better written in dot notation. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 66| » » QuickSpawn(gx,·140,·"structures/athen_house") | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 69| } | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 71| experiments["single_unit_pass_nopass"]·=·{ | | [NORMAL] JSHintBear: | | ['single_unit_pass_nopass'] is better written in dot notation. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 74| » » QuickSpawn(gx-10,·140,·"structures/athen_house") | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 75| » » QuickSpawn(gx+10,·140,·"structures/athen_house") | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 76| » » QuickSpawn(gx-8,·170,·"structures/athen_house") | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 77| » » QuickSpawn(gx+8,·170,·"structures/athen_house") | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 80| } | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 83| experiments["units_dense_forest"]·=·{ | | [NORMAL] JSHintBear: | | ['units_dense_forest'] is better written in dot notation. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 99| } | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 101| experiments["units_sparse_forest"]·=·{ | | [NORMAL] JSHintBear: | | ['units_sparse_forest'] is better written in dot notation. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 116| } | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 119| experiments["units_running_into_eachoter"]·=·{ | | [NORMAL] JSHintBear: | | ['units_running_into_eachoter'] is better written in dot notation. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 128| } | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 130| var·gx·=·100; | | [NORMAL] JSHintBear: | | 'gx' was used before it was defined. Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1409/display/redirect Comment Actions Add more test cases, including formations and gathering and a labyrinth-y one. Fix linter. Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (quote-props): | | Unquoted property 'target' found. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 235| 235| { | 236| 236| for (let j = -2; j <= 3; j += 1) | 237| 237| WalkTo(gx, gy + 100, QuickSpawn(gx + i, gy + j - 5, "units/athen_infantry_marine_archer_b")); | 238| |- Do("gather", { target: tree }, QuickSpawn(gx + i, gy - 3 - 5, "units/athen_infantry_marine_archer_b")); | | 238|+ Do("gather", { "target": tree }, QuickSpawn(gx + i, gy - 3 - 5, "units/athen_infantry_marine_archer_b")); | 239| 239| } | 240| 240| } | 241| 241| }; | | [NORMAL] ESLintBear (quote-props): | | Unquoted property 'target' found. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 249| 249| if (Math.abs(j) == 3 || Math.abs(i) == 3) | 250| 250| QuickSpawn(gx + i, gy + j + 50, "units/athen_infantry_marine_archer_b"); | 251| 251| | 252| |- Do("gather", { target: tree }, QuickSpawn(gx, gy, "units/athen_infantry_marine_archer_b")); | | 252|+ Do("gather", { "target": tree }, QuickSpawn(gx, gy, "units/athen_infantry_marine_archer_b")); | 253| 253| } | 254| 254| }; | 255| 255| | | [NORMAL] ESLintBear (quote-props): | | Unquoted property 'name' found. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 259| 259| for (let i = -3; i <= 3; ++i) | 260| 260| for (let j = -3; j <= 3; ++j) | 261| 261| ents.push(QuickSpawn(gx + i * 2, gy + j * 2, "units/athen_infantry_marine_archer_b")); | 262| |- Do("formation", { name: "special/formations/box" }, ents); | | 262|+ Do("formation", { "name": "special/formations/box" }, ents); | 263| 263| WalkTo(gx, gy + 100, ents); | 264| 264| } | 265| 265| }; | | [NORMAL] ESLintBear (quote-props): | | Unquoted property 'name' found. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 270| 270| for (let i = -3; i <= 3; ++i) | 271| 271| for (let j = -3; j <= 3; ++j) | 272| 272| ents.push(QuickSpawn(gx + i * 2, gy + j * 2, "units/athen_infantry_marine_archer_b")); | 273| |- Do("formation", { name: "special/formations/box" }, ents); | | 273|+ Do("formation", { "name": "special/formations/box" }, ents); | 274| 274| Do("attack", { target: 5 }, ents); | 275| 275| } | 276| 276| }; | | [NORMAL] ESLintBear (quote-props): | | Unquoted property 'target' found. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/scenarios/pathfinding_integration_test.js | 271| 271| for (let j = -3; j <= 3; ++j) | 272| 272| ents.push(QuickSpawn(gx + i * 2, gy + j * 2, "units/athen_infantry_marine_archer_b")); | 273| 273| Do("formation", { name: "special/formations/box" }, ents); | 274| |- Do("attack", { target: 5 }, ents); | | 274|+ Do("attack", { "target": 5 }, ents); | 275| 275| } | 276| 276| }; | 277| 277| Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1440/display/redirect Comment Actions Renamed to unit motion since it's more explicit, slight code cleanup and fix linter comments. Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/1473/display/redirect |