Details

Reviewers

Silier

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP23409: Allow to garrison animals.

Trac Tickets

#1907

Summary

This patch gives animals that can be controlled, the opportunity to garrison a building.

This will give modders e.g. the opportunity to use the corral for a trickle of food when an animal is garrisoned.

Test Plan

Make sure the building to be garrisoned has the right class in GarrisonHolder (or the animal has the right class to garrison) and you can place an animal in the building without errors.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 8592
Build 14070: Vulcan Build	Jenkins
Build 14069: arc lint + arc unit

Event Timeline

Freagarach created this revision.Jun 8 2019, 8:07 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
| 352| 352| 		var cmpPosition = Engine.QueryInterface(this.entity, IID_Position);
| 353| 353| 		if (this.lastShorelinePosition && cmpPosition && (this.lastShorelinePosition.x == cmpPosition.GetPosition().x)
| 354| 354| 		    && (this.lastShorelinePosition.z == cmpPosition.GetPosition().z))
| 355|    |-		{
|    | 355|+		
| 356| 356| 			// we were already on the shoreline, and have not moved since
| 357| 357| 			if (DistanceBetweenEntities(this.entity, this.order.data.target) < 50)
| 358| 358| 				needToMove = false;
| 359|    |-		}
|    | 359|+		
| 360| 360| 
| 361| 361| 		if (needToMove)
| 362| 362| 			this.SetNextState("INDIVIDUAL.PICKUP.APPROACHING");
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
| 350| 350| 		// Check if we need to move     TODO implement a better way to know if we are on the shoreline
| 351| 351| 		var needToMove = true;
| 352| 352| 		var cmpPosition = Engine.QueryInterface(this.entity, IID_Position);
| 353|    |-		if (this.lastShorelinePosition && cmpPosition && (this.lastShorelinePosition.x == cmpPosition.GetPosition().x)
| 354|    |-		    && (this.lastShorelinePosition.z == cmpPosition.GetPosition().z))
|    | 353|+		if (this.lastShorelinePosition && cmpPosition && (this.lastShorelinePosition.x == cmpPosition.GetPosition().x) &&
|    | 354|+		    (this.lastShorelinePosition.z == cmpPosition.GetPosition().z))
| 355| 355| 		{
| 356| 356| 			// we were already on the shoreline, and have not moved since
| 357| 357| 			if (DistanceBetweenEntities(this.entity, this.order.data.target) < 50)
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'else'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
| 515| 515| 					this.PushOrderFront("Walk", this.order.data.lastPos);
| 516| 516| 				}
| 517| 517| 				else
| 518|    |-				{
|    | 518|+				
| 519| 519| 					// We couldn't move there, or the target moved away
| 520| 520| 					this.FinishOrder();
| 521|    |-				}
|    | 521|+				
| 522| 522| 				return;
| 523| 523| 			}
| 524| 524| 
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
| 732| 732| 			}
| 733| 733| 			// Check if we are already in range, otherwise walk there
| 734| 734| 			if (!this.CheckGarrisonRange(msg.data.target))
| 735|    |-			{
|    | 735|+			
| 736| 736| 				if (!this.CheckTargetVisible(msg.data.target))
| 737| 737| 				{
| 738| 738| 					this.FinishOrder();
| 743| 743| 					this.SetNextState("GARRISON.APPROACHING");
| 744| 744| 					return;
| 745| 745| 				}
| 746|    |-			}
|    | 746|+			
| 747| 747| 
| 748| 748| 			this.SetNextState("GARRISON.GARRISONING");
| 749| 749| 		},
|    | [NORMAL] ESLintBear (no-else-return):
|    | Unnecessary 'else' after 'return'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
| 738| 738| 					this.FinishOrder();
| 739| 739| 					return;
| 740| 740| 				}
| 741|    |-				else
| 742|    |-				{
|    | 741|+				
| 743| 742| 					this.SetNextState("GARRISON.APPROACHING");
| 744| 743| 					return;
| 745|    |-				}
|    | 744|+				
| 746| 745| 			}
| 747| 746| 
| 748| 747| 			this.SetNextState("GARRISON.GARRISONING");
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'else'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
| 761| 761| 						this.PushOrderFront("Walk", msg.data.lastPos);
| 762| 762| 					}
| 763| 763| 					else
| 764|    |-					{
|    | 764|+					
| 765| 765| 						// We couldn't move there, or the target moved away
| 766| 766| 						this.FinishOrder();
| 767|    |-					}
|    | 767|+					
| 768| 768| 					return;
| 769| 769| 				}
| 770| 770| 
|    | [NORMAL] ESLintBear (key-spacing):
|    | Missing space before value for key 'GARRISON'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
| 992| 992| 			},
| 993| 993| 		},
| 994| 994| 
| 995|    |-		"GARRISON":{
|    | 995|+		"GARRISON": {
| 996| 996| 			"enter": function() {
| 997| 997| 				// If the garrisonholder should pickup, warn it so it can take needed action
| 998| 998| 				var cmpGarrisonHolder = Engine.QueryInterface(this.order.data.target, IID_GarrisonHolder);
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|1203|1203| 			// If the controller handled an order but some members rejected it,
|1204|1204| 			// they will have no orders and be in the FORMATIONMEMBER.IDLE state.
|1205|1205| 			if (this.orderQueue.length)
|1206|    |-			{
|    |1206|+			
|1207|1207| 				// We're leaving the formation, so stop our FormationWalk order
|1208|1208| 				if (this.FinishOrder())
|1209|1209| 					return;
|1210|    |-			}
|    |1210|+			
|1211|1211| 
|1212|1212| 			// No orders left, we're an individual now
|1213|1213| 			if (this.IsAnimal())
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|1231|1231| 			// Move a tile outside the building
|1232|1232| 			let range = 4;
|1233|1233| 			if (this.CheckTargetRangeExplicit(msg.data.target, range, range))
|1234|    |-			{
|    |1234|+			
|1235|1235| 				// We are already at the target, or can't move at all
|1236|1236| 				this.FinishOrder();
|1237|    |-			}
|    |1237|+			
|1238|1238| 			else
|1239|1239| 			{
|1240|1240| 				this.order.data.min = range;
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|1446|1446| 
|1447|1447| 			"LosRangeUpdate": function(msg) {
|1448|1448| 				if (this.GetStance().targetVisibleEnemies)
|1449|    |-				{
|    |1449|+				
|1450|1450| 					// Start attacking one of the newly-seen enemy (if any)
|1451|1451| 					this.AttackEntitiesByPreference(msg.data.added);
|1452|    |-				}
|    |1452|+				
|1453|1453| 			},
|1454|1454| 
|1455|1455| 			"LosHealRangeUpdate": function(msg) {
|    | [NORMAL] ESLintBear (space-before-function-paren):
|    | Unexpected space before function parentheses.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|1479|1479| 				this.SelectAnimation("move");
|1480|1480| 			},
|1481|1481| 
|1482|    |-			"leave": function () {
|    |1482|+			"leave": function() {
|1483|1483| 				this.SelectAnimation("idle");
|1484|1484| 				this.StopMoving();
|1485|1485| 			},
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|1655|1655| 						// if nothing better to do, check if the guarded needs to be healed or repaired
|1656|1656| 						var cmpHealth = Engine.QueryInterface(this.isGuardOf, IID_Health);
|1657|1657| 						if (cmpHealth && cmpHealth.IsInjured())
|1658|    |-						{
|    |1658|+						
|1659|1659| 							if (this.CanHeal(this.isGuardOf))
|1660|1660| 								this.PushOrderFront("Heal", { "target": this.isGuardOf, "force": false });
|1661|1661| 							else if (this.CanRepair(this.isGuardOf))
|1662|1662| 								this.PushOrderFront("Repair", { "target": this.isGuardOf, "autocontinue": false, "force": false });
|1663|    |-						}
|    |1663|+						
|1664|1664| 					}
|1665|1665| 				},
|1666|1666| 
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|1758|1758| 				"MoveCompleted": function() {
|1759|1759| 
|1760|1760| 					if (this.CheckTargetAttackRange(this.order.data.target, this.order.data.attackType))
|1761|    |-					{
|    |1761|+					
|1762|1762| 						// If the unit needs to unpack, do so
|1763|1763| 						if (this.CanUnpack())
|1764|1764| 						{
|1767|1767| 						}
|1768|1768| 						else
|1769|1769| 							this.SetNextState("ATTACKING");
|1770|    |-					}
|    |1770|+					
|1771|1771| 					else
|1772|1772| 					{
|1773|1773| 						if (this.MoveToTargetAttackRange(this.order.data.target, this.order.data.attackType))
|    | [NORMAL] ESLintBear (no-else-return):
|    | Unnecessary 'else' after 'return'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|1765|1765| 							this.PushOrderFront("Unpack", { "force": true });
|1766|1766| 							return;
|1767|1767| 						}
|1768|    |-						else
|1769|    |-							this.SetNextState("ATTACKING");
|    |1768|+						this.SetNextState("ATTACKING");
|1770|1769| 					}
|1771|1770| 					else
|1772|1771| 					{
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'else'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|1769|1769| 							this.SetNextState("ATTACKING");
|1770|1770| 					}
|1771|1771| 					else
|1772|    |-					{
|    |1772|+					
|1773|1773| 						if (this.MoveToTargetAttackRange(this.order.data.target, this.order.data.attackType))
|1774|1774| 						{
|1775|1775| 							this.SetNextState("APPROACHING");
|1779|1779| 							// Give up
|1780|1780| 							this.FinishOrder();
|1781|1781| 						}
|1782|    |-					}
|    |1782|+					
|1783|1783| 				},
|1784|1784| 			},
|1785|1785| 
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|1771|1771| 					else
|1772|1772| 					{
|1773|1773| 						if (this.MoveToTargetAttackRange(this.order.data.target, this.order.data.attackType))
|1774|    |-						{
|    |1774|+						
|1775|1775| 							this.SetNextState("APPROACHING");
|1776|    |-						}
|    |1776|+						
|1777|1777| 						else
|1778|1778| 						{
|1779|1779| 							// Give up
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'else'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|1775|1775| 							this.SetNextState("APPROACHING");
|1776|1776| 						}
|1777|1777| 						else
|1778|    |-						{
|    |1778|+						
|1779|1779| 							// Give up
|1780|1780| 							this.FinishOrder();
|1781|    |-						}
|    |1781|+						
|1782|1782| 					}
|1783|1783| 				},
|1784|1784| 			},
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|1796|1796| 					}
|1797|1797| 					// Check the target is still alive and attackable
|1798|1798| 					if (this.CanAttack(target) && !this.CheckTargetAttackRange(target, this.order.data.attackType))
|1799|    |-					{
|    |1799|+					
|1800|1800| 						// Can't reach it - try to chase after it
|1801|1801| 						if (this.ShouldChaseTargetedEntity(target, this.order.data.force))
|1802|1802| 						{
|1811|1811| 								return true;
|1812|1812| 							}
|1813|1813| 						}
|1814|    |-					}
|    |1814|+					
|1815|1815| 
|1816|1816| 					this.StopMoving();
|1817|1817| 
|    | [NORMAL] ESLintBear (no-unneeded-ternary):
|    | Unnecessary use of boolean literals in conditional expression.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|1844|1844| 					// TODO: we should probably only bother syncing projectile attacks, not melee
|1845|1845| 
|1846|1846| 					// If using a non-default prepare time, re-sync the animation when the timer runs.
|1847|    |-					this.resyncAnimation = (prepare != this.attackTimers.prepare) ? true : false;
|    |1847|+					this.resyncAnimation = (prepare != this.attackTimers.prepare);
|1848|1848| 
|1849|1849| 					this.FaceTowardsTarget(this.order.data.target);
|1850|1850| 
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|1973|1973| 
|1974|1974| 				"Attacked": function(msg) {
|1975|1975| 					// If we are capturing and are attacked by something that we would not capture, attack that entity instead
|1976|    |-					if (this.order.data.attackType == "Capture" && (this.GetStance().targetAttackersAlways || !this.order.data.force)
|1977|    |-						&& this.order.data.target != msg.data.attacker && this.GetBestAttackAgainst(msg.data.attacker, true) != "Capture")
|    |1976|+					if (this.order.data.attackType == "Capture" && (this.GetStance().targetAttackersAlways || !this.order.data.force) &&
|    |1977|+						this.order.data.target != msg.data.attacker && this.GetBestAttackAgainst(msg.data.attacker, true) != "Capture")
|1978|1978| 						this.RespondToTargetedEntities([msg.data.attacker]);
|1979|1979| 				},
|1980|1980| 			},
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|1993|1993| 					this.SelectAnimation("move");
|1994|1994| 					var cmpUnitAI = Engine.QueryInterface(this.order.data.target, IID_UnitAI);
|1995|1995| 					if (cmpUnitAI && cmpUnitAI.IsFleeing())
|1996|    |-					{
|    |1996|+					
|1997|1997| 						// Run after a fleeing target
|1998|1998| 						this.SetSpeedMultiplier(this.GetRunMultiplier());
|1999|    |-					}
|    |1999|+					
|2000|2000| 					this.StartTimer(1000, 1000);
|2001|2001| 				},
|2002|2002| 
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|2176|2176| 
|2177|2177| 					var cmpSupply = Engine.QueryInterface(this.gatheringTarget, IID_ResourceSupply);
|2178|2178| 					if (cmpSupply && cmpSupply.IsAvailable(cmpOwnership.GetOwner(), this.entity))
|2179|    |-					{
|    |2179|+					
|2180|2180| 						// Check we can still reach and gather from the target
|2181|2181| 						if (this.CheckTargetRange(this.gatheringTarget, IID_ResourceGatherer) && this.CanGather(this.gatheringTarget))
|2182|2182| 						{
|2241|2241| 								return;
|2242|2242| 							}
|2243|2243| 						}
|2244|    |-					}
|    |2244|+					
|2245|2245| 
|2246|2246| 					// We're already in range, can't get anywhere near it or the target is exhausted.
|2247|2247| 
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '||' should be placed at the end of the line.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|2267|2267| 					// Also don't switch to a different type of huntable animal
|2268|2268| 					var nearby = this.FindNearbyResource(function(ent, type, template) {
|2269|2269| 						return (
|2270|    |-							(type.generic == "treasure" && resourceType.generic == "treasure")
|2271|    |-							|| (type.specific == resourceType.specific
|    |2270|+							(type.generic == "treasure" && resourceType.generic == "treasure") ||
|    |2271|+							(type.specific == resourceType.specific
|2272|2272| 							&& (type.specific != "meat" || resourceTemplate == template))
|2273|2273| 						);
|2274|2274| 					});
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|2268|2268| 					var nearby = this.FindNearbyResource(function(ent, type, template) {
|2269|2269| 						return (
|2270|2270| 							(type.generic == "treasure" && resourceType.generic == "treasure")
|2271|    |-							|| (type.specific == resourceType.specific
|2272|    |-							&& (type.specific != "meat" || resourceTemplate == template))
|    |2271|+							|| (type.specific == resourceType.specific &&
|    |2272|+							(type.specific != "meat" || resourceTemplate == template))
|2273|2273| 						);
|2274|2274| 					});
|2275|2275| 					if (nearby)
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|2333|2333| 
|2334|2334| 				"Timer": function(msg) {
|2335|2335| 					if (this.ShouldAbandonChase(this.order.data.target, this.order.data.force, IID_Heal, null))
|2336|    |-					{
|    |2336|+					
|2337|2337| 						// Return to our original position unless we have a better order.
|2338|2338| 						if (!this.FinishOrder() && this.GetStance().respondHoldGround)
|2339|2339| 							this.WalkToHeldPosition();
|2340|    |-					}
|    |2340|+					
|2341|2341| 				},
|2342|2342| 
|2343|2343| 				"MoveCompleted": function() {
|    | [NORMAL] ESLintBear (no-unneeded-ternary):
|    | Unnecessary use of boolean literals in conditional expression.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|2367|2367| 					this.StartTimer(prepare, this.healTimers.repeat);
|2368|2368| 
|2369|2369| 					// If using a non-default prepare time, re-sync the animation when the timer runs.
|2370|    |-					this.resyncAnimation = (prepare != this.healTimers.prepare) ? true : false;
|    |2370|+					this.resyncAnimation = (prepare != this.healTimers.prepare);
|2371|2371| 
|2372|2372| 					this.FaceTowardsTarget(this.order.data.target);
|2373|2373| 				},
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|2579|2579| 					{
|2580|2580| 						// The building was already finished/fully repaired before we arrived;
|2581|2581| 						// let the ConstructionFinished handler handle this.
|2582|    |-						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget});
|    |2582|+						this.OnGlobalConstructionFinished({ "entity": this.repairTarget, "newentity": this.repairTarget});
|2583|2583| 						return true;
|2584|2584| 					}
|2585|2585| 
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|2579|2579| 					{
|2580|2580| 						// The building was already finished/fully repaired before we arrived;
|2581|2581| 						// let the ConstructionFinished handler handle this.
|2582|    |-						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget});
|    |2582|+						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget });
|2583|2583| 						return true;
|2584|2584| 					}
|2585|2585| 
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|2622|2622| 					if (!inRange && this.MoveToTargetRange(this.repairTarget, IID_Builder))
|2623|2623| 						this.SetNextState("APPROACHING");
|2624|2624| 					else if (!inRange)
|2625|    |-						this.FinishOrder(); //can't approach and isn't in reach
|    |2625|+						this.FinishOrder(); // can't approach and isn't in reach
|2626|2626| 				},
|2627|2627| 			},
|2628|2628| 
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|2709|2709| 
|2710|2710| 				// Unit was approaching and there's nothing to do now, so switch to walking
|2711|2711| 				if (oldState === "INDIVIDUAL.REPAIR.APPROACHING")
|2712|    |-				{
|    |2712|+				
|2713|2713| 					// We're already walking to the given point, so add this as a order.
|2714|2714| 					this.WalkToTarget(msg.data.newentity, true);
|2715|    |-				}
|    |2715|+				
|2716|2716| 			},
|2717|2717| 		},
|2718|2718| 
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|2774|2774| 
|2775|2775| 					// Check that we can garrison here
|2776|2776| 					if (this.CanGarrison(target))
|2777|    |-					{
|    |2777|+					
|2778|2778| 						// Check that we're in range of the garrison target
|2779|2779| 						if (this.CheckGarrisonRange(target))
|2780|2780| 						{
|2853|2853| 								return false;
|2854|2854| 							}
|2855|2855| 						}
|2856|    |-					}
|    |2856|+					
|2857|2857| 					// Garrisoning failed for some reason, so finish the order
|2858|2858| 					this.FinishOrder();
|2859|2859| 					return true;
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|2974|2974| 		"Attacked": function(msg) {
|2975|2975| 			if (this.template.NaturalBehaviour == "skittish" ||
|2976|2976| 			    this.template.NaturalBehaviour == "passive")
|2977|    |-			{
|    |2977|+			
|2978|2978| 				this.Flee(msg.data.attacker, false);
|2979|    |-			}
|    |2979|+			
|2980|2980| 			else if (this.IsDangerousAnimal() || this.template.NaturalBehaviour == "defensive")
|2981|2981| 			{
|2982|2982| 				if (this.CanAttack(msg.data.attacker))
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|2983|2983| 					this.Attack(msg.data.attacker, false);
|2984|2984| 			}
|2985|2985| 			else if (this.template.NaturalBehaviour == "domestic")
|2986|    |-			{
|    |2986|+			
|2987|2987| 				// Never flee, stop what we were doing
|2988|2988| 				this.SetNextState("IDLE");
|2989|    |-			}
|    |2989|+			
|2990|2990| 		},
|2991|2991| 
|2992|2992| 		"Order.LeaveFoundation": function(msg) {
|    | [NORMAL] ESLintBear (no-else-return):
|    | Unnecessary 'else' after 'return'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|2997|2997| 				this.FinishOrder();
|2998|2998| 				return;
|2999|2999| 			}
|3000|    |-			else
|3001|    |-			{
|    |3000|+			
|3002|3001| 				this.order.data.min = range;
|3003|3002| 				this.SetNextState("WALKING");
|3004|    |-			}
|    |3003|+			
|3005|3004| 		},
|3006|3005| 
|3007|3006| 		"IDLE": {
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3041|3041| 				}
|3042|3042| 				// Start attacking one of the newly-seen enemy (if any)
|3043|3043| 				else if (this.IsDangerousAnimal())
|3044|    |-				{
|    |3044|+				
|3045|3045| 					this.AttackVisibleEntity(msg.data.added);
|3046|    |-				}
|    |3046|+				
|3047|3047| 
|3048|3048| 				// TODO: if two units enter our range together, we'll attack the
|3049|3049| 				// first and then the second won't trigger another LosRangeUpdate
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3084|3084| 				}
|3085|3085| 				// Start attacking one of the newly-seen enemy (if any)
|3086|3086| 				else if (this.template.NaturalBehaviour == "violent")
|3087|    |-				{
|    |3087|+				
|3088|3088| 					this.AttackVisibleEntity(msg.data.added);
|3089|    |-				}
|    |3089|+				
|3090|3090| 			},
|3091|3091| 
|3092|3092| 			"MoveCompleted": function() { },
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 2 tabs but found 7.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3101|3101| 		"COMBAT": "INDIVIDUAL.COMBAT", // reuse the same combat behaviour for animals
|3102|3102| 
|3103|3103| 		"WALKING": "INDIVIDUAL.WALKING",	// reuse the same walking behaviour for animals
|3104|    |-							// only used for domestic animals
|    |3104|+		// only used for domestic animals
|3105|3105| 
|3106|3106| 		"GARRISON": "INDIVIDUAL.GARRISON.APPROACHING", // reuse the same garrison behaviour for animals
|3107|3107| 
|    | [NORMAL] ESLintBear (no-unneeded-ternary):
|    | Unnecessary use of boolean literals in conditional expression.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3162|3162| 
|3163|3163| UnitAI.prototype.IsAnimal = function()
|3164|3164| {
|3165|    |-	return (this.template.NaturalBehaviour ? true : false);
|    |3165|+	return (!!this.template.NaturalBehaviour);
|3166|3166| };
|3167|3167| 
|3168|3168| UnitAI.prototype.IsDangerousAnimal = function()
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3200|3200| UnitAI.prototype.GetGarrisonHolder = function()
|3201|3201| {
|3202|3202| 	if (this.IsGarrisoned())
|3203|    |-	{
|    |3203|+	
|3204|3204| 		for (let order of this.orderQueue)
|3205|3205| 			if (order.type == "Garrison")
|3206|3206| 				return order.data.target;
|3207|    |-	}
|    |3207|+	
|3208|3208| 	return INVALID_ENTITY;
|3209|3209| };
|3210|3210| 
|    | [NORMAL] ESLintBear (comma-spacing):
|    | A space is required after ','.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3278|3278| 		{
|3279|3279| 			let index = this.GetCurrentState().indexOf(".");
|3280|3280| 			if (index != -1)
|3281|    |-				this.UnitFsm.SwitchToNextState(this, this.GetCurrentState().slice(0,index));
|    |3281|+				this.UnitFsm.SwitchToNextState(this, this.GetCurrentState().slice(0, index));
|3282|3282| 			this.Stop(false);
|3283|3283| 		}
|3284|3284| 
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3334|3334| 		if (this.orderQueue[i].type != "PickupUnit" || this.orderQueue[i].data.target != msg.entity)
|3335|3335| 			continue;
|3336|3336| 		if (i == 0)
|3337|    |-			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg});
|    |3337|+			this.UnitFsm.ProcessMessage(this, { "type": "PickupCanceled", "data": msg});
|3338|3338| 		else
|3339|3339| 			this.orderQueue.splice(i, 1);
|3340|3340| 		Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3334|3334| 		if (this.orderQueue[i].type != "PickupUnit" || this.orderQueue[i].data.target != msg.entity)
|3335|3335| 			continue;
|3336|3336| 		if (i == 0)
|3337|    |-			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg});
|    |3337|+			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg });
|3338|3338| 		else
|3339|3339| 			this.orderQueue.splice(i, 1);
|3340|3340| 		Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3418|3418| };
|3419|3419| 
|3420|3420| 
|3421|    |-//// FSM linkage functions ////
|    |3421|+// // FSM linkage functions ////
|3422|3422| 
|3423|3423| // Setting the next state to the current state will leave/re-enter the top-most substate.
|3424|3424| UnitAI.prototype.SetNextState = function(state)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3590|3590| 				continue;
|3591|3591| 			if (this.orderQueue[i].type == type)
|3592|3592| 				continue;
|3593|    |-			this.orderQueue.splice(i, 0, {"type": type, "data": data});
|    |3593|+			this.orderQueue.splice(i, 0, { "type": type, "data": data});
|3594|3594| 			Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|3595|3595| 			return;
|3596|3596| 		}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3590|3590| 				continue;
|3591|3591| 			if (this.orderQueue[i].type == type)
|3592|3592| 				continue;
|3593|    |-			this.orderQueue.splice(i, 0, {"type": type, "data": data});
|    |3593|+			this.orderQueue.splice(i, 0, {"type": type, "data": data });
|3594|3594| 			Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|3595|3595| 			return;
|3596|3596| 		}
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3604|3604| {
|3605|3605| 	// Remember the previous work orders to be able to go back to them later if required
|3606|3606| 	if (data && data.force)
|3607|    |-	{
|    |3607|+	
|3608|3608| 		if (this.IsFormationController())
|3609|3609| 			this.CallMemberFunction("UpdateWorkOrders", [type]);
|3610|3610| 		else
|3611|3611| 			this.UpdateWorkOrders(type);
|3612|    |-	}
|    |3612|+	
|3613|3613| 
|3614|3614| 	let garrisonHolder = this.IsGarrisoned() && type != "Ungarrison" ? this.GetGarrisonHolder() : null;
|3615|3615| 
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3681|3681| 	{
|3682|3682| 		var cmpUnitAI = Engine.QueryInterface(this.formationController, IID_UnitAI);
|3683|3683| 		if (cmpUnitAI)
|3684|    |-		{
|    |3684|+		
|3685|3685| 			for (var i = 0; i < cmpUnitAI.orderQueue.length; ++i)
|3686|3686| 			{
|3687|3687| 				if (isWorkType(cmpUnitAI.orderQueue[i].type))
|3690|3690| 					return;
|3691|3691| 				}
|3692|3692| 			}
|3693|    |-		}
|    |3693|+		
|3694|3694| 	}
|3695|3695| 
|3696|3696| 	// If nothing found, take the unit orders
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'for' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3683|3683| 		if (cmpUnitAI)
|3684|3684| 		{
|3685|3685| 			for (var i = 0; i < cmpUnitAI.orderQueue.length; ++i)
|3686|    |-			{
|    |3686|+			
|3687|3687| 				if (isWorkType(cmpUnitAI.orderQueue[i].type))
|3688|3688| 				{
|3689|3689| 					this.workOrders = cmpUnitAI.orderQueue.slice(i);
|3690|3690| 					return;
|3691|3691| 				}
|3692|    |-			}
|    |3692|+			
|3693|3693| 		}
|3694|3694| 	}
|3695|3695| 
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'for' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3695|3695| 
|3696|3696| 	// If nothing found, take the unit orders
|3697|3697| 	for (var i = 0; i < this.orderQueue.length; ++i)
|3698|    |-	{
|    |3698|+	
|3699|3699| 		if (isWorkType(this.orderQueue[i].type))
|3700|3700| 		{
|3701|3701| 			this.workOrders = this.orderQueue.slice(i);
|3702|3702| 			return;
|3703|3703| 		}
|3704|    |-	}
|    |3704|+	
|3705|3705| };
|3706|3706| 
|3707|3707| UnitAI.prototype.BackToWork = function()
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3761|3761| 	if (data.timerRepeat === undefined)
|3762|3762| 		this.timer = undefined;
|3763|3763| 
|3764|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness});
|    |3764|+	this.UnitFsm.ProcessMessage(this, { "type": "Timer", "data": data, "lateness": lateness});
|3765|3765| };
|3766|3766| 
|3767|3767| /**
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3761|3761| 	if (data.timerRepeat === undefined)
|3762|3762| 		this.timer = undefined;
|3763|3763| 
|3764|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness});
|    |3764|+	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness });
|3765|3765| };
|3766|3766| 
|3767|3767| /**
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3796|3796| 	this.timer = undefined;
|3797|3797| };
|3798|3798| 
|3799|    |-//// Message handlers /////
|    |3799|+// // Message handlers /////
|3800|3800| 
|3801|3801| UnitAI.prototype.OnMotionChanged = function(msg)
|3802|3802| {
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3808|3808| 	// TODO: This is a bit inefficient since every unit listens to every
|3809|3809| 	// construction message - ideally we could scope it to only the one we're building
|3810|3810| 
|3811|    |-	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg});
|    |3811|+	this.UnitFsm.ProcessMessage(this, { "type": "ConstructionFinished", "data": msg});
|3812|3812| };
|3813|3813| 
|3814|3814| UnitAI.prototype.OnGlobalEntityRenamed = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3808|3808| 	// TODO: This is a bit inefficient since every unit listens to every
|3809|3809| 	// construction message - ideally we could scope it to only the one we're building
|3810|3810| 
|3811|    |-	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg});
|    |3811|+	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg });
|3812|3812| };
|3813|3813| 
|3814|3814| UnitAI.prototype.OnGlobalEntityRenamed = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3833|3833| 
|3834|3834| UnitAI.prototype.OnAttacked = function(msg)
|3835|3835| {
|3836|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg});
|    |3836|+	this.UnitFsm.ProcessMessage(this, { "type": "Attacked", "data": msg});
|3837|3837| };
|3838|3838| 
|3839|3839| UnitAI.prototype.OnGuardedAttacked = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3833|3833| 
|3834|3834| UnitAI.prototype.OnAttacked = function(msg)
|3835|3835| {
|3836|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg});
|    |3836|+	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg });
|3837|3837| };
|3838|3838| 
|3839|3839| UnitAI.prototype.OnGuardedAttacked = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3838|3838| 
|3839|3839| UnitAI.prototype.OnGuardedAttacked = function(msg)
|3840|3840| {
|3841|    |-	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data});
|    |3841|+	this.UnitFsm.ProcessMessage(this, { "type": "GuardedAttacked", "data": msg.data});
|3842|3842| };
|3843|3843| 
|3844|3844| UnitAI.prototype.OnHealthChanged = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3838|3838| 
|3839|3839| UnitAI.prototype.OnGuardedAttacked = function(msg)
|3840|3840| {
|3841|    |-	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data});
|    |3841|+	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data });
|3842|3842| };
|3843|3843| 
|3844|3844| UnitAI.prototype.OnHealthChanged = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3843|3843| 
|3844|3844| UnitAI.prototype.OnHealthChanged = function(msg)
|3845|3845| {
|3846|    |-	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to});
|    |3846|+	this.UnitFsm.ProcessMessage(this, { "type": "HealthChanged", "from": msg.from, "to": msg.to});
|3847|3847| };
|3848|3848| 
|3849|3849| UnitAI.prototype.OnRangeUpdate = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3843|3843| 
|3844|3844| UnitAI.prototype.OnHealthChanged = function(msg)
|3845|3845| {
|3846|    |-	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to});
|    |3846|+	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to });
|3847|3847| };
|3848|3848| 
|3849|3849| UnitAI.prototype.OnRangeUpdate = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3849|3849| UnitAI.prototype.OnRangeUpdate = function(msg)
|3850|3850| {
|3851|3851| 	if (msg.tag == this.losRangeQuery)
|3852|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|    |3852|+		this.UnitFsm.ProcessMessage(this, { "type": "LosRangeUpdate", "data": msg});
|3853|3853| 	else if (msg.tag == this.losHealRangeQuery)
|3854|3854| 		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|3855|3855| };
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3849|3849| UnitAI.prototype.OnRangeUpdate = function(msg)
|3850|3850| {
|3851|3851| 	if (msg.tag == this.losRangeQuery)
|3852|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|    |3852|+		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg });
|3853|3853| 	else if (msg.tag == this.losHealRangeQuery)
|3854|3854| 		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|3855|3855| };
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3851|3851| 	if (msg.tag == this.losRangeQuery)
|3852|3852| 		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|3853|3853| 	else if (msg.tag == this.losHealRangeQuery)
|3854|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|    |3854|+		this.UnitFsm.ProcessMessage(this, { "type": "LosHealRangeUpdate", "data": msg});
|3855|3855| };
|3856|3856| 
|3857|3857| UnitAI.prototype.OnPackFinished = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3851|3851| 	if (msg.tag == this.losRangeQuery)
|3852|3852| 		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|3853|3853| 	else if (msg.tag == this.losHealRangeQuery)
|3854|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|    |3854|+		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg });
|3855|3855| };
|3856|3856| 
|3857|3857| UnitAI.prototype.OnPackFinished = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3856|3856| 
|3857|3857| UnitAI.prototype.OnPackFinished = function(msg)
|3858|3858| {
|3859|    |-	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|    |3859|+	this.UnitFsm.ProcessMessage(this, { "type": "PackFinished", "packed": msg.packed});
|3860|3860| };
|3861|3861| 
|3862|3862| //// Helper functions to be called by the FSM ////
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3856|3856| 
|3857|3857| UnitAI.prototype.OnPackFinished = function(msg)
|3858|3858| {
|3859|    |-	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|    |3859|+	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed });
|3860|3860| };
|3861|3861| 
|3862|3862| //// Helper functions to be called by the FSM ////
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3859|3859| 	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|3860|3860| };
|3861|3861| 
|3862|    |-//// Helper functions to be called by the FSM ////
|    |3862|+// // Helper functions to be called by the FSM ////
|3863|3863| 
|3864|3864| UnitAI.prototype.GetWalkSpeed = function()
|3865|3865| {
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|3961|3961| 	if (!cmpOwnership || cmpOwnership.GetOwner() == INVALID_PLAYER)
|3962|3962| 		return undefined;
|3963|3963| 
|3964|    |-	let cmpPosition = Engine.QueryInterface(this.entity, IID_Position)
|    |3964|+	let cmpPosition = Engine.QueryInterface(this.entity, IID_Position);
|3965|3965| 	if (!cmpPosition || !cmpPosition.IsInWorld())
|3966|3966| 		return undefined;
|3967|3967| 
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'else'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4046|4046| 			PlaySound(name, member);
|4047|4047| 	}
|4048|4048| 	else
|4049|    |-	{
|    |4049|+	
|4050|4050| 		// Otherwise use our own sounds
|4051|4051| 		PlaySound(name, this.entity);
|4052|    |-	}
|    |4052|+	
|4053|4053| };
|4054|4054| 
|4055|4055| /*
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4142|4142| UnitAI.prototype.MoveTo = function(data, iid, type)
|4143|4143| {
|4144|4144| 	if (data["target"])
|4145|    |-	{
|    |4145|+	
|4146|4146| 		if (data["min"] || data["max"])
|4147|4147| 			return this.MoveToTargetRangeExplicit(data.target, data.min || -1, data.max || -1);
|4148|4148| 		else
|4152|4152| 			else
|4153|4153| 				return this.MoveToTargetRange(data.target, iid, type);
|4154|4154| 		}
|4155|    |-	}
|    |4155|+	
|4156|4156| 	else
|4157|4157| 	{
|4158|4158| 		if (data["min"] || data["max"])
|    | [NORMAL] ESLintBear (dot-notation):
|    | ["target"] is better written in dot notation.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4141|4141|  */
|4142|4142| UnitAI.prototype.MoveTo = function(data, iid, type)
|4143|4143| {
|4144|    |-	if (data["target"])
|    |4144|+	if (data.target)
|4145|4145| 	{
|4146|4146| 		if (data["min"] || data["max"])
|4147|4147| 			return this.MoveToTargetRangeExplicit(data.target, data.min || -1, data.max || -1);
|    | [NORMAL] ESLintBear (dot-notation):
|    | ["min"] is better written in dot notation.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4143|4143| {
|4144|4144| 	if (data["target"])
|4145|4145| 	{
|4146|    |-		if (data["min"] || data["max"])
|    |4146|+		if (data.min || data["max"])
|4147|4147| 			return this.MoveToTargetRangeExplicit(data.target, data.min || -1, data.max || -1);
|4148|4148| 		else
|4149|4149| 		{
|    | [NORMAL] ESLintBear (dot-notation):
|    | ["max"] is better written in dot notation.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4143|4143| {
|4144|4144| 	if (data["target"])
|4145|4145| 	{
|4146|    |-		if (data["min"] || data["max"])
|    |4146|+		if (data["min"] || data.max)
|4147|4147| 			return this.MoveToTargetRangeExplicit(data.target, data.min || -1, data.max || -1);
|4148|4148| 		else
|4149|4149| 		{
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'else'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4146|4146| 		if (data["min"] || data["max"])
|4147|4147| 			return this.MoveToTargetRangeExplicit(data.target, data.min || -1, data.max || -1);
|4148|4148| 		else
|4149|    |-		{
|    |4149|+		
|4150|4150| 			if (!iid)
|4151|4151| 				return this.MoveToTarget(data.target);
|4152|4152| 			else
|4153|4153| 				return this.MoveToTargetRange(data.target, iid, type);
|4154|    |-		}
|    |4154|+		
|4155|4155| 	}
|4156|4156| 	else
|4157|4157| 	{
|    | [NORMAL] ESLintBear (no-else-return):
|    | Unnecessary 'else' after 'return'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4145|4145| 	{
|4146|4146| 		if (data["min"] || data["max"])
|4147|4147| 			return this.MoveToTargetRangeExplicit(data.target, data.min || -1, data.max || -1);
|4148|    |-		else
|4149|    |-		{
|    |4148|+		
|4150|4149| 			if (!iid)
|4151|4150| 				return this.MoveToTarget(data.target);
|4152|4151| 			else
|4153|4152| 				return this.MoveToTargetRange(data.target, iid, type);
|4154|    |-		}
|    |4153|+		
|4155|4154| 	}
|4156|4155| 	else
|4157|4156| 	{
|    | [NORMAL] ESLintBear (no-else-return):
|    | Unnecessary 'else' after 'return'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4149|4149| 		{
|4150|4150| 			if (!iid)
|4151|4151| 				return this.MoveToTarget(data.target);
|4152|    |-			else
|4153|    |-				return this.MoveToTargetRange(data.target, iid, type);
|    |4152|+			return this.MoveToTargetRange(data.target, iid, type);
|4154|4153| 		}
|4155|4154| 	}
|4156|4155| 	else
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'else'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4154|4154| 		}
|4155|4155| 	}
|4156|4156| 	else
|4157|    |-	{
|    |4157|+	
|4158|4158| 		if (data["min"] || data["max"])
|4159|4159| 			return this.MoveToPointRange(data.x, data.z, data.min || -1, data.max || -1);
|4160|4160| 		else
|4161|4161| 			return this.MoveToPoint(data.x, data.z);
|4162|    |-	}
|    |4162|+	
|4163|4163| }
|4164|4164| 
|4165|4165| UnitAI.prototype.MoveToPoint = function(x, z)
|    | [NORMAL] ESLintBear (dot-notation):
|    | ["min"] is better written in dot notation.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4155|4155| 	}
|4156|4156| 	else
|4157|4157| 	{
|4158|    |-		if (data["min"] || data["max"])
|    |4158|+		if (data.min || data["max"])
|4159|4159| 			return this.MoveToPointRange(data.x, data.z, data.min || -1, data.max || -1);
|4160|4160| 		else
|4161|4161| 			return this.MoveToPoint(data.x, data.z);
|    | [NORMAL] ESLintBear (dot-notation):
|    | ["max"] is better written in dot notation.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4155|4155| 	}
|4156|4156| 	else
|4157|4157| 	{
|4158|    |-		if (data["min"] || data["max"])
|    |4158|+		if (data["min"] || data.max)
|4159|4159| 			return this.MoveToPointRange(data.x, data.z, data.min || -1, data.max || -1);
|4160|4160| 		else
|4161|4161| 			return this.MoveToPoint(data.x, data.z);
|    | [NORMAL] ESLintBear (no-else-return):
|    | Unnecessary 'else' after 'return'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4157|4157| 	{
|4158|4158| 		if (data["min"] || data["max"])
|4159|4159| 			return this.MoveToPointRange(data.x, data.z, data.min || -1, data.max || -1);
|4160|    |-		else
|4161|    |-			return this.MoveToPoint(data.x, data.z);
|    |4160|+		return this.MoveToPoint(data.x, data.z);
|4162|4161| 	}
|4163|4162| }
|4164|4163| 
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4160|4160| 		else
|4161|4161| 			return this.MoveToPoint(data.x, data.z);
|4162|4162| 	}
|4163|    |-}
|    |4163|+};
|4164|4164| 
|4165|4165| UnitAI.prototype.MoveToPoint = function(x, z)
|4166|4166| {
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4244|4244| 	else
|4245|4245| 		// return false? Or hope you come close enough?
|4246|4246| 		var parabolicMaxRange = 0;
|4247|    |-		//return false;
|    |4247|+		// return false;
|4248|4248| 
|4249|4249| 	// the parabole changes while walking, take something in the middle
|4250|4250| 	var guessedMaxRange = (range.max + parabolicMaxRange)/2;
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4309|4309| 	if (this.IsFormationMember())
|4310|4310| 	{
|4311|4311| 		var cmpFormationUnitAI = Engine.QueryInterface(this.formationController, IID_UnitAI);
|4312|    |-		if (cmpFormationUnitAI && cmpFormationUnitAI.IsAttackingAsFormation()
|4313|    |-			&& cmpFormationUnitAI.order.data.target == target)
|    |4312|+		if (cmpFormationUnitAI && cmpFormationUnitAI.IsAttackingAsFormation() &&
|    |4313|+			cmpFormationUnitAI.order.data.target == target)
|4314|4314| 			return true;
|4315|4315| 	}
|4316|4316| 
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4477|4477| UnitAI.prototype.AttackEntityInZone = function(ents)
|4478|4478| {
|4479|4479| 	var target = ents.find(target =>
|4480|    |-		this.CanAttack(target)
|4481|    |-		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|    |4480|+		this.CanAttack(target) &&
|    |4481|+		this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|4482|4482| 		&& (this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|4483|4483| 	);
|4484|4484| 	if (!target)
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4478|4478| {
|4479|4479| 	var target = ents.find(target =>
|4480|4480| 		this.CanAttack(target)
|4481|    |-		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|4482|    |-		&& (this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|    |4481|+		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true)) &&
|    |4482|+		(this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|4483|4483| 	);
|4484|4484| 	if (!target)
|4485|4485| 		return false;
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before 'Engine'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4542|4542| 	// If we are guarding/escorting, don't abandon as long as the guarded unit is in target range of the attacker
|4543|4543| 	if (this.isGuardOf)
|4544|4544| 	{
|4545|    |-		var cmpUnitAI =  Engine.QueryInterface(target, IID_UnitAI);
|    |4545|+		var cmpUnitAI = Engine.QueryInterface(target, IID_UnitAI);
|4546|4546| 		var cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4547|4547| 		if (cmpUnitAI && cmpAttack &&
|4548|4548| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4546|4546| 		var cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4547|4547| 		if (cmpUnitAI && cmpAttack &&
|4548|4548| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|4549|    |-				return false;
|    |4549|+			return false;
|4550|4550| 	}
|4551|4551| 
|4552|4552| 	// Stop if we're in hold-ground mode and it's too far from the holding point
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4551|4551| 
|4552|4552| 	// Stop if we're in hold-ground mode and it's too far from the holding point
|4553|4553| 	if (this.GetStance().respondHoldGround)
|4554|    |-	{
|    |4554|+	
|4555|4555| 		if (!this.CheckTargetDistanceFromHeldPosition(target, iid, type))
|4556|4556| 			return true;
|4557|    |-	}
|    |4557|+	
|4558|4558| 
|4559|4559| 	// Stop if it's left our vision range, unless we're especially persistent
|4560|4560| 	if (!this.GetStance().respondChaseBeyondVision)
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4558|4558| 
|4559|4559| 	// Stop if it's left our vision range, unless we're especially persistent
|4560|4560| 	if (!this.GetStance().respondChaseBeyondVision)
|4561|    |-	{
|    |4561|+	
|4562|4562| 		if (!this.CheckTargetIsInVisionRange(target))
|4563|4563| 			return true;
|4564|    |-	}
|    |4564|+	
|4565|4565| 
|4566|4566| 	// (Note that CCmpUnitMotion will detect if the target is lost in FoW,
|4567|4567| 	// and will continue moving to its last seen position and then stop)
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before 'Engine'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4584|4584| 	// If we are guarding/escorting, chase at least as long as the guarded unit is in target range of the attacker
|4585|4585| 	if (this.isGuardOf)
|4586|4586| 	{
|4587|    |-		let cmpUnitAI =  Engine.QueryInterface(target, IID_UnitAI);
|    |4587|+		let cmpUnitAI = Engine.QueryInterface(target, IID_UnitAI);
|4588|4588| 		let cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4589|4589| 		if (cmpUnitAI && cmpAttack &&
|4590|4590| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4597|4597| 	return false;
|4598|4598| };
|4599|4599| 
|4600|    |-//// External interface functions ////
|    |4600|+// // External interface functions ////
|4601|4601| 
|4602|4602| UnitAI.prototype.SetFormationController = function(ent)
|4603|4603| {
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4607|4607| 	// of our own formation (or ourself if not in formation)
|4608|4608| 	var cmpObstruction = Engine.QueryInterface(this.entity, IID_Obstruction);
|4609|4609| 	if (cmpObstruction)
|4610|    |-	{
|    |4610|+	
|4611|4611| 		if (ent == INVALID_ENTITY)
|4612|4612| 			cmpObstruction.SetControlGroup(this.entity);
|4613|4613| 		else
|4614|4614| 			cmpObstruction.SetControlGroup(ent);
|4615|    |-	}
|    |4615|+	
|4616|4616| 
|4617|4617| 	// If we were removed from a formation, let the FSM switch back to INDIVIDUAL
|4618|4618| 	if (ent == INVALID_ENTITY)
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4750|4750| 	// if we already had an old guard order, do nothing if the target is the same
|4751|4751| 	// and the order is running, otherwise remove the previous order
|4752|4752| 	if (this.isGuardOf)
|4753|    |-	{
|    |4753|+	
|4754|4754| 		if (this.isGuardOf == target && this.order && this.order.type == "Guard")
|4755|4755| 			return;
|4756|4756| 		else
|4757|4757| 			this.RemoveGuard();
|4758|    |-	}
|    |4758|+	
|4759|4759| 
|4760|4760| 	this.AddOrder("Guard", { "target": target, "force": false }, queued);
|4761|4761| };
|    | [NORMAL] ESLintBear (no-else-return):
|    | Unnecessary 'else' after 'return'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4753|4753| 	{
|4754|4754| 		if (this.isGuardOf == target && this.order && this.order.type == "Guard")
|4755|4755| 			return;
|4756|    |-		else
|4757|    |-			this.RemoveGuard();
|    |4756|+		this.RemoveGuard();
|4758|4757| 	}
|4759|4758| 
|4760|4759| 	this.AddOrder("Guard", { "target": target, "force": false }, queued);
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|4924|4924| 			this.WalkToTarget(target, queued);
|4925|4925| 		return;
|4926|4926| 	}
|4927|    |-	this.AddOrder("Attack", { "target": target, "force": true, "allowCapture": allowCapture}, queued);
|    |4927|+	this.AddOrder("Attack", { "target": target, "force": true, "allowCapture": allowCapture }, queued);
|4928|4928| };
|4929|4929| 
|4930|4930| /**
|    | [NORMAL] ESLintBear (no-trailing-spaces):
|    | Trailing spaces not allowed.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|5073|5073| 	    this.workOrders.length && this.workOrders[0].type == "Trade")
|5074|5074| 	{
|5075|5075| 		let cmpTrader = Engine.QueryInterface(this.entity, IID_Trader);
|5076|    |-		if (cmpTrader.HasBothMarkets() && 
|    |5076|+		if (cmpTrader.HasBothMarkets() &&
|5077|5077| 		   (cmpTrader.GetFirstMarket() == target && cmpTrader.GetSecondMarket() == source ||
|5078|5078| 		    cmpTrader.GetFirstMarket() == source && cmpTrader.GetSecondMarket() == target))
|5079|5079| 		{
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|5354|5354| 				{
|5355|5355| 					var cmpIdentity = Engine.QueryInterface(targ, IID_Identity);
|5356|5356| 					var targetClasses = this.order.data.targetClasses;
|5357|    |-					if (targetClasses.attack && cmpIdentity
|5358|    |-						&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|    |5357|+					if (targetClasses.attack && cmpIdentity &&
|    |5358|+						!MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5359|5359| 						continue;
|5360|5360| 					if (targetClasses.avoid && cmpIdentity
|5361|5361| 						&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|5357|5357| 					if (targetClasses.attack && cmpIdentity
|5358|5358| 						&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5359|5359| 						continue;
|5360|    |-					if (targetClasses.avoid && cmpIdentity
|5361|    |-						&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    |5360|+					if (targetClasses.avoid && cmpIdentity &&
|    |5361|+						MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|5362|5362| 						continue;
|5363|5363| 					// Only used by the AIs to prevent some choices of targets
|5364|5364| 					if (targetClasses.vetoEntities && targetClasses.vetoEntities[targ])
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|5380|5380| 		{
|5381|5381| 			var cmpIdentity = Engine.QueryInterface(targ, IID_Identity);
|5382|5382| 			var targetClasses = this.order.data.targetClasses;
|5383|    |-			if (cmpIdentity && targetClasses.attack
|5384|    |-				&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|    |5383|+			if (cmpIdentity && targetClasses.attack &&
|    |5384|+				!MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5385|5385| 				continue;
|5386|5386| 			if (cmpIdentity && targetClasses.avoid
|5387|5387| 				&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|5383|5383| 			if (cmpIdentity && targetClasses.attack
|5384|5384| 				&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5385|5385| 				continue;
|5386|    |-			if (cmpIdentity && targetClasses.avoid
|5387|    |-				&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    |5386|+			if (cmpIdentity && targetClasses.avoid &&
|    |5387|+				MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|5388|5388| 				continue;
|5389|5389| 			// Only used by the AIs to prevent some choices of targets
|5390|5390| 			if (targetClasses.vetoEntities && targetClasses.vetoEntities[targ])
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|5526|5526| 
|5527|5527| UnitAI.prototype.SetHeldPosition = function(x, z)
|5528|5528| {
|5529|    |-	this.heldPosition = {"x": x, "z": z};
|    |5529|+	this.heldPosition = { "x": x, "z": z};
|5530|5530| };
|5531|5531| 
|5532|5532| UnitAI.prototype.SetHeldPositionOnEntity = function(entity)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|5526|5526| 
|5527|5527| UnitAI.prototype.SetHeldPosition = function(x, z)
|5528|5528| {
|5529|    |-	this.heldPosition = {"x": x, "z": z};
|    |5529|+	this.heldPosition = {"x": x, "z": z };
|5530|5530| };
|5531|5531| 
|5532|5532| UnitAI.prototype.SetHeldPositionOnEntity = function(entity)
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|5553|5553| 	return false;
|5554|5554| };
|5555|5555| 
|5556|    |-//// Helper functions ////
|    |5556|+// // Helper functions ////
|5557|5557| 
|5558|5558| UnitAI.prototype.CanAttack = function(target)
|5559|5559| {
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|5751|5751| 	return cmpPack && cmpPack.IsPacking();
|5752|5752| };
|5753|5753| 
|5754|    |-//// Formation specific functions ////
|    |5754|+// // Formation specific functions ////
|5755|5755| 
|5756|5756| UnitAI.prototype.IsAttackingAsFormation = function()
|5757|5757| {
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|5756|5756| UnitAI.prototype.IsAttackingAsFormation = function()
|5757|5757| {
|5758|5758| 	var cmpAttack = Engine.QueryInterface(this.entity, IID_Attack);
|5759|    |-	return cmpAttack && cmpAttack.CanAttackAsFormation()
|5760|    |-		&& this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|    |5759|+	return cmpAttack && cmpAttack.CanAttackAsFormation() &&
|    |5760|+		this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|5761|5761| };
|5762|5762| 
|5763|5763| //// Animal specific functions ////
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/UnitAI.js
|5760|5760| 		&& this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|5761|5761| };
|5762|5762| 
|5763|    |-//// Animal specific functions ////
|    |5763|+// // Animal specific functions ////
|5764|5764| 
|5765|5765| UnitAI.prototype.MoveRandomly = function(distance)
|5766|5766| {

binaries/data/mods/public/simulation/components/UnitAI.js
| 327| »   »   »   return·true;
|    | [NORMAL] ESLintBear (consistent-return):
|    | Method 'Order.WalkToTarget' expected no return value.

binaries/data/mods/public/simulation/components/UnitAI.js
| 887| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
| 909| »   »   »   "enter":·function(msg)·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
| 956| »   »   »   »   »   return·true;
|    | [NORMAL] ESLintBear (consistent-return):
|    | Method 'enter' expected no return value.

binaries/data/mods/public/simulation/components/UnitAI.js
|1017| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1052| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1082| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1292| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1473| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1493| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1522| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1675| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1725| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1811| »   »   »   »   »   »   »   »   return·true;
|    | [NORMAL] ESLintBear (consistent-return):
|    | Method 'enter' expected no return value.

binaries/data/mods/public/simulation/components/UnitAI.js
|1983| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2074| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2257| »   »   »   »   »   »   let·nearby·=·this.FindNearestDropsite(resourceType.generic);
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'nearby' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|2312| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2430| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2495| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2532| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2741| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2930| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|3666| »   var·isWorkType·=·type·=>·type·==·"Gather"·||·type·==·"Trade"·||·type·==·"Repair"·||·type·==·"ReturnResource";
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'type' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4464| »   var·target·=·ents.find(target·=>·this.CanAttack(target));
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'target' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4479| »   var·target·=·ents.find(target·=>
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'target' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4525| »   var·ent·=·ents.find(ent·=>·this.CanHeal(ent));
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'ent' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4548| »   »   ····cmpAttack.GetAttackTypes().some(type·=>·cmpUnitAI.CheckTargetAttackRange(this.isGuardOf,·type)))
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'type' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|5004| »   var·lastPos·=·undefined;
|    | [NORMAL] ESLintBear (no-undef-init):
|    | It's not necessary to initialize 'lastPos' to undefined.

binaries/data/mods/public/simulation/components/UnitAI.js
| 354| »   »   ····&&·(this.lastShorelinePosition.z·==·cmpPosition.GetPosition().z))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|1836| »   »   »   »   »   »   var·cmpFormation·=·Engine.QueryInterface(this.formationController,·IID_Formation);
|    | [NORMAL] JSHintBear:
|    | 'cmpFormation' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|1977| »   »   »   »   »   »   &&·this.order.data.target·!=·msg.data.attacker·&&·this.GetBestAttackAgainst(msg.data.attacker,·true)·!=·"Capture")
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|2252| »   »   »   »   »   var·cmpResourceGatherer·=·Engine.QueryInterface(this.entity,·IID_ResourceGatherer);
|    | [NORMAL] JSHintBear:
|    | 'cmpResourceGatherer' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|2268| »   »   »   »   »   var·nearby·=·this.FindNearbyResource(function(ent,·type,·template)·{
|    | [NORMAL] JSHintBear:
|    | 'nearby' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|2271| »   »   »   »   »   »   »   ||·(type.specific·==·resourceType.specific
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '||'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|2272| »   »   »   »   »   »   »   &&·(type.specific·!=·"meat"·||·resourceTemplate·==·template))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|2292| »   »   »   »   »   var·nearby·=·this.FindNearestDropsite(resourceType.generic);
|    | [NORMAL] JSHintBear:
|    | 'nearby' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|2472| »   »   »   »   »   var·cmpResourceGatherer·=·Engine.QueryInterface(this.entity,·IID_ResourceGatherer);
|    | [NORMAL] JSHintBear:
|    | 'cmpResourceGatherer' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|2688| »   »   »   »   »   var·cmpResourceDropsite·=·Engine.QueryInterface(msg.data.newentity,·IID_ResourceDropsite);
|    | [NORMAL] JSHintBear:
|    | 'cmpResourceDropsite' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|2776| »   »   »   »   »   if·(this.CanGarrison(target))
|    | [NORMAL] JSHintBear:
|    | 'target' used out of scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|2779| »   »   »   »   »   »   if·(this.CheckGarrisonRange(target))
|    | [NORMAL] JSHintBear:
|    | 'target' used out of scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|2781| »   »   »   »   »   »   »   var·cmpGarrisonHolder·=·Engine.QueryInterface(target,·IID_GarrisonHolder);
|    | [NORMAL] JSHintBear:
|    | 'target' used out of scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|2803| »   »   »   »   »   »   »   »   var·cmpResourceDropsite·=·Engine.QueryInterface(target,·IID_ResourceDropsite);
|    | [NORMAL] JSHintBear:
|    | 'target' used out of scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|2804| »   »   »   »   »   »   »   »   if·(cmpResourceDropsite·&&·this.CanReturnResource(target,·true))
|    | [NORMAL] JSHintBear:
|    | 'target' used out of scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|2819| »   »   »   »   »   »   »   »   »   var·cmpHolderPosition·=·Engine.QueryInterface(target,·IID_Position);
|    | [NORMAL] JSHintBear:
|    | 'target' used out of scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|2820| »   »   »   »   »   »   »   »   »   var·cmpHolderUnitAI·=·Engine.QueryInterface(target,·IID_UnitAI);
|    | [NORMAL] JSHintBear:
|    | 'target' used out of scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|2847| »   »   »   »   »   »   »   if·(!this.CheckTargetRangeExplicit(target,·0,·0)·&&·this.MoveToTarget(target))
|    | [NORMAL] JSHintBear:
|    | 'target' used out of scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|2847| »   »   »   »   »   »   »   if·(!this.CheckTargetRangeExplicit(target,·0,·0)·&&·this.MoveToTarget(target))
|    | [NORMAL] JSHintBear:
|    | 'target' used out of scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|3628| »   »   var·order·=·{·"type":·type,·"data":·data·};
|    | [NORMAL] JSHintBear:
|    | 'order' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|3697| »   for·(var·i·=·0;·i·<·this.orderQueue.length;·++i)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|3964| »   let·cmpPosition·=·Engine.QueryInterface(this.entity,·IID_Position)
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/UnitAI.js
|4144| »   if·(data["target"])
|    | [NORMAL] JSHintBear:
|    | ['target'] is better written in dot notation.

binaries/data/mods/public/simulation/components/UnitAI.js
|4146| »   »   if·(data["min"]·||·data["max"])
|    | [NORMAL] JSHintBear:
|    | ['min'] is better written in dot notation.

binaries/data/mods/public/simulation/components/UnitAI.js
|4146| »   »   if·(data["min"]·||·data["max"])
|    | [NORMAL] JSHintBear:
|    | ['max'] is better written in dot notation.

binaries/data/mods/public/simulation/components/UnitAI.js
|4158| »   »   if·(data["min"]·||·data["max"])
|    | [NORMAL] JSHintBear:
|    | ['min'] is better written in dot notation.

binaries/data/mods/public/simulation/components/UnitAI.js
|4158| »   »   if·(data["min"]·||·data["max"])
|    | [NORMAL] JSHintBear:
|    | ['max'] is better written in dot notation.

binaries/data/mods/public/simulation/components/UnitAI.js
|4163| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/UnitAI.js
|4246| »   »   var·parabolicMaxRange·=·0;
|    | [NORMAL] JSHintBear:
|    | 'parabolicMaxRange' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|4250| »   var·guessedMaxRange·=·(range.max·+·parabolicMaxRange)/2;
|    | [NORMAL] JSHintBear:
|    | 'parabolicMaxRange' used out of scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4257| »   return·cmpUnitMotion.MoveToTargetRange(target,·range.min,·Math.min(range.max,·parabolicMaxRange));
|    | [NORMAL] JSHintBear:
|    | 'parabolicMaxRange' used out of scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4313| »   »   »   &&·cmpFormationUnitAI.order.data.target·==·target)
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|4481| »   »   &&·this.CheckTargetDistanceFromHeldPosition(target,·IID_Attack,·this.GetBestAttackAgainst(target,·true))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|4482| »   »   &&·(this.GetStance().respondChaseBeyondVision·||·this.CheckTargetIsInVisionRange(target))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5004| »   var·lastPos·=·undefined;
|    | [NORMAL] JSHintBear:
|    | It's not necessary to initialize 'lastPos' to 'undefined'.

binaries/data/mods/public/simulation/components/UnitAI.js
|5358| »   »   »   »   »   »   &&·!MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.attack))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5361| »   »   »   »   »   »   &&·MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.avoid))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5374| »   var·targets·=·this.GetTargetsFromUnit();
|    | [NORMAL] JSHintBear:
|    | 'targets' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5375| »   for·(var·targ·of·targets)
|    | [NORMAL] JSHintBear:
|    | 'targ' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5381| »   »   »   var·cmpIdentity·=·Engine.QueryInterface(targ,·IID_Identity);
|    | [NORMAL] JSHintBear:
|    | 'cmpIdentity' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5382| »   »   »   var·targetClasses·=·this.order.data.targetClasses;
|    | [NORMAL] JSHintBear:
|    | 'targetClasses' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5384| »   »   »   »   &&·!MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.attack))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5387| »   »   »   »   &&·MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.avoid))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5462| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5465| »   »   var·range·=·cmpVision.GetRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5470| »   »   var·cmpRanged·=·Engine.QueryInterface(this.entity,·iid);
|    | [NORMAL] JSHintBear:
|    | 'cmpRanged' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5473| »   »   var·range·=·iid·!==·IID_Attack·?·cmpRanged.GetRange()·:·cmpRanged.GetFullAttackRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5474| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5484| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5487| »   »   var·range·=·cmpVision.GetRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5487| »   »   var·range·=·cmpVision.GetRange();
|    | [MAJOR] JSHintBear:
|    | Too many errors. (93% scanned).
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/differential/1664/display/redirect

Harbormaster completed remote builds in B7850: Diff 8389.Jun 8 2019, 8:09 PM

wowgetoffyourcellphone added a subscriber: wowgetoffyourcellphone.Jun 8 2019, 11:31 PM

Freagarach added a subscriber: Restricted Owners Package.Jun 11 2019, 5:34 PM

wraitii added a reviewer: Restricted Owners Package.Jun 11 2019, 5:42 PM

Silier added a subscriber: Silier.Jul 24 2019, 7:34 PM

Silier added inline comments.

binaries/data/mods/public/simulation/components/UnitAI.js
2946	could you keep names of states consistant with units? thank you

Consistent naming. (Was unable to get that working at first, I don't know why, it's simple.)

Freagarach added inline comments.Jul 25 2019, 4:00 PM

binaries/data/mods/public/simulation/components/UnitAI.js
3194–3196	I should have changed comments...

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (no-else-return):
|    | Unnecessary 'else' after 'return'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
| 758| 758| 					this.FinishOrder();
| 759| 759| 					return;
| 760| 760| 				}
| 761|    |-				else
| 762|    |-				{
|    | 761|+				
| 763| 762| 					this.SetNextState("GARRISON.APPROACHING");
| 764| 763| 					return;
| 765|    |-				}
|    | 764|+				
| 766| 765| 			}
| 767| 766| 
| 768| 767| 			this.SetNextState("GARRISON.GARRISONING");
|    | [NORMAL] ESLintBear (key-spacing):
|    | Missing space before value for key 'GARRISON'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|1020|1020| 			},
|1021|1021| 		},
|1022|1022| 
|1023|    |-		"GARRISON":{
|    |1023|+		"GARRISON": {
|1024|1024| 			"enter": function() {
|1025|1025| 				// If the garrisonholder should pickup, warn it so it can take needed action
|1026|1026| 				var cmpGarrisonHolder = Engine.QueryInterface(this.order.data.target, IID_GarrisonHolder);
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|1981|1981| 
|1982|1982| 				"Attacked": function(msg) {
|1983|1983| 					// If we are capturing and are attacked by something that we would not capture, attack that entity instead
|1984|    |-					if (this.order.data.attackType == "Capture" && (this.GetStance().targetAttackersAlways || !this.order.data.force)
|1985|    |-						&& this.order.data.target != msg.data.attacker && this.GetBestAttackAgainst(msg.data.attacker, true) != "Capture")
|    |1984|+					if (this.order.data.attackType == "Capture" && (this.GetStance().targetAttackersAlways || !this.order.data.force) &&
|    |1985|+						this.order.data.target != msg.data.attacker && this.GetBestAttackAgainst(msg.data.attacker, true) != "Capture")
|1986|1986| 						this.RespondToTargetedEntities([msg.data.attacker]);
|1987|1987| 				},
|1988|1988| 			},
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|2670|2670| 					{
|2671|2671| 						// The building was already finished/fully repaired before we arrived;
|2672|2672| 						// let the ConstructionFinished handler handle this.
|2673|    |-						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget});
|    |2673|+						this.OnGlobalConstructionFinished({ "entity": this.repairTarget, "newentity": this.repairTarget});
|2674|2674| 						return true;
|2675|2675| 					}
|2676|2676| 
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|2670|2670| 					{
|2671|2671| 						// The building was already finished/fully repaired before we arrived;
|2672|2672| 						// let the ConstructionFinished handler handle this.
|2673|    |-						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget});
|    |2673|+						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget });
|2674|2674| 						return true;
|2675|2675| 					}
|2676|2676| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 2 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3188|3188| 		"COMBAT": "INDIVIDUAL.COMBAT", // reuse the same combat behaviour for animals
|3189|3189| 
|3190|3190| 		"WALKING": "INDIVIDUAL.WALKING",	// reuse the same walking behaviour for animals
|3191|    |-							// only used for domestic animals
|    |3191|+		// only used for domestic animals
|3192|3192| 
|3193|3193| 		"GARRISON": {
|3194|3194| 			"APPROACHING": "INDIVIDUAL.GARRISON.APPROACHING", // reuse the same garrison behaviour for animals
|    | [NORMAL] ESLintBear (no-unneeded-ternary):
|    | Unnecessary use of boolean literals in conditional expression.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3251|3251| 
|3252|3252| UnitAI.prototype.IsAnimal = function()
|3253|3253| {
|3254|    |-	return (this.template.NaturalBehaviour ? true : false);
|    |3254|+	return (!!this.template.NaturalBehaviour);
|3255|3255| };
|3256|3256| 
|3257|3257| UnitAI.prototype.IsDangerousAnimal = function()
|    | [NORMAL] ESLintBear (comma-spacing):
|    | A space is required after ','.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3367|3367| 		{
|3368|3368| 			let index = this.GetCurrentState().indexOf(".");
|3369|3369| 			if (index != -1)
|3370|    |-				this.UnitFsm.SwitchToNextState(this, this.GetCurrentState().slice(0,index));
|    |3370|+				this.UnitFsm.SwitchToNextState(this, this.GetCurrentState().slice(0, index));
|3371|3371| 			this.Stop(false);
|3372|3372| 		}
|3373|3373| 
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3423|3423| 		if (this.orderQueue[i].type != "PickupUnit" || this.orderQueue[i].data.target != msg.entity)
|3424|3424| 			continue;
|3425|3425| 		if (i == 0)
|3426|    |-			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg});
|    |3426|+			this.UnitFsm.ProcessMessage(this, { "type": "PickupCanceled", "data": msg});
|3427|3427| 		else
|3428|3428| 			this.orderQueue.splice(i, 1);
|3429|3429| 		Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3423|3423| 		if (this.orderQueue[i].type != "PickupUnit" || this.orderQueue[i].data.target != msg.entity)
|3424|3424| 			continue;
|3425|3425| 		if (i == 0)
|3426|    |-			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg});
|    |3426|+			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg });
|3427|3427| 		else
|3428|3428| 			this.orderQueue.splice(i, 1);
|3429|3429| 		Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3507|3507| };
|3508|3508| 
|3509|3509| 
|3510|    |-//// FSM linkage functions ////
|    |3510|+// // FSM linkage functions ////
|3511|3511| 
|3512|3512| // Setting the next state to the current state will leave/re-enter the top-most substate.
|3513|3513| UnitAI.prototype.SetNextState = function(state)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3677|3677| 				continue;
|3678|3678| 			if (this.orderQueue[i].type == type)
|3679|3679| 				continue;
|3680|    |-			this.orderQueue.splice(i, 0, {"type": type, "data": data});
|    |3680|+			this.orderQueue.splice(i, 0, { "type": type, "data": data});
|3681|3681| 			Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|3682|3682| 			return;
|3683|3683| 		}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3677|3677| 				continue;
|3678|3678| 			if (this.orderQueue[i].type == type)
|3679|3679| 				continue;
|3680|    |-			this.orderQueue.splice(i, 0, {"type": type, "data": data});
|    |3680|+			this.orderQueue.splice(i, 0, {"type": type, "data": data });
|3681|3681| 			Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|3682|3682| 			return;
|3683|3683| 		}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3848|3848| 	if (data.timerRepeat === undefined)
|3849|3849| 		this.timer = undefined;
|3850|3850| 
|3851|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness});
|    |3851|+	this.UnitFsm.ProcessMessage(this, { "type": "Timer", "data": data, "lateness": lateness});
|3852|3852| };
|3853|3853| 
|3854|3854| /**
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3848|3848| 	if (data.timerRepeat === undefined)
|3849|3849| 		this.timer = undefined;
|3850|3850| 
|3851|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness});
|    |3851|+	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness });
|3852|3852| };
|3853|3853| 
|3854|3854| /**
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3893|3893| 	// TODO: This is a bit inefficient since every unit listens to every
|3894|3894| 	// construction message - ideally we could scope it to only the one we're building
|3895|3895| 
|3896|    |-	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg});
|    |3896|+	this.UnitFsm.ProcessMessage(this, { "type": "ConstructionFinished", "data": msg});
|3897|3897| };
|3898|3898| 
|3899|3899| UnitAI.prototype.OnGlobalEntityRenamed = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3893|3893| 	// TODO: This is a bit inefficient since every unit listens to every
|3894|3894| 	// construction message - ideally we could scope it to only the one we're building
|3895|3895| 
|3896|    |-	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg});
|    |3896|+	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg });
|3897|3897| };
|3898|3898| 
|3899|3899| UnitAI.prototype.OnGlobalEntityRenamed = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3918|3918| 
|3919|3919| UnitAI.prototype.OnAttacked = function(msg)
|3920|3920| {
|3921|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg});
|    |3921|+	this.UnitFsm.ProcessMessage(this, { "type": "Attacked", "data": msg});
|3922|3922| };
|3923|3923| 
|3924|3924| UnitAI.prototype.OnGuardedAttacked = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3918|3918| 
|3919|3919| UnitAI.prototype.OnAttacked = function(msg)
|3920|3920| {
|3921|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg});
|    |3921|+	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg });
|3922|3922| };
|3923|3923| 
|3924|3924| UnitAI.prototype.OnGuardedAttacked = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3923|3923| 
|3924|3924| UnitAI.prototype.OnGuardedAttacked = function(msg)
|3925|3925| {
|3926|    |-	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data});
|    |3926|+	this.UnitFsm.ProcessMessage(this, { "type": "GuardedAttacked", "data": msg.data});
|3927|3927| };
|3928|3928| 
|3929|3929| UnitAI.prototype.OnHealthChanged = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3923|3923| 
|3924|3924| UnitAI.prototype.OnGuardedAttacked = function(msg)
|3925|3925| {
|3926|    |-	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data});
|    |3926|+	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data });
|3927|3927| };
|3928|3928| 
|3929|3929| UnitAI.prototype.OnHealthChanged = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3928|3928| 
|3929|3929| UnitAI.prototype.OnHealthChanged = function(msg)
|3930|3930| {
|3931|    |-	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to});
|    |3931|+	this.UnitFsm.ProcessMessage(this, { "type": "HealthChanged", "from": msg.from, "to": msg.to});
|3932|3932| };
|3933|3933| 
|3934|3934| UnitAI.prototype.OnRangeUpdate = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3928|3928| 
|3929|3929| UnitAI.prototype.OnHealthChanged = function(msg)
|3930|3930| {
|3931|    |-	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to});
|    |3931|+	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to });
|3932|3932| };
|3933|3933| 
|3934|3934| UnitAI.prototype.OnRangeUpdate = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3934|3934| UnitAI.prototype.OnRangeUpdate = function(msg)
|3935|3935| {
|3936|3936| 	if (msg.tag == this.losRangeQuery)
|3937|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|    |3937|+		this.UnitFsm.ProcessMessage(this, { "type": "LosRangeUpdate", "data": msg});
|3938|3938| 	else if (msg.tag == this.losHealRangeQuery)
|3939|3939| 		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|3940|3940| };
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3934|3934| UnitAI.prototype.OnRangeUpdate = function(msg)
|3935|3935| {
|3936|3936| 	if (msg.tag == this.losRangeQuery)
|3937|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|    |3937|+		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg });
|3938|3938| 	else if (msg.tag == this.losHealRangeQuery)
|3939|3939| 		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|3940|3940| };
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3936|3936| 	if (msg.tag == this.losRangeQuery)
|3937|3937| 		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|3938|3938| 	else if (msg.tag == this.losHealRangeQuery)
|3939|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|    |3939|+		this.UnitFsm.ProcessMessage(this, { "type": "LosHealRangeUpdate", "data": msg});
|3940|3940| };
|3941|3941| 
|3942|3942| UnitAI.prototype.OnPackFinished = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3936|3936| 	if (msg.tag == this.losRangeQuery)
|3937|3937| 		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|3938|3938| 	else if (msg.tag == this.losHealRangeQuery)
|3939|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|    |3939|+		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg });
|3940|3940| };
|3941|3941| 
|3942|3942| UnitAI.prototype.OnPackFinished = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3941|3941| 
|3942|3942| UnitAI.prototype.OnPackFinished = function(msg)
|3943|3943| {
|3944|    |-	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|    |3944|+	this.UnitFsm.ProcessMessage(this, { "type": "PackFinished", "packed": msg.packed});
|3945|3945| };
|3946|3946| 
|3947|3947| //// Helper functions to be called by the FSM ////
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3941|3941| 
|3942|3942| UnitAI.prototype.OnPackFinished = function(msg)
|3943|3943| {
|3944|    |-	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|    |3944|+	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed });
|3945|3945| };
|3946|3946| 
|3947|3947| //// Helper functions to be called by the FSM ////
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3944|3944| 	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|3945|3945| };
|3946|3946| 
|3947|    |-//// Helper functions to be called by the FSM ////
|    |3947|+// // Helper functions to be called by the FSM ////
|3948|3948| 
|3949|3949| UnitAI.prototype.GetWalkSpeed = function()
|3950|3950| {
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4597|4597| UnitAI.prototype.AttackEntityInZone = function(ents)
|4598|4598| {
|4599|4599| 	var target = ents.find(target =>
|4600|    |-		this.CanAttack(target)
|4601|    |-		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|    |4600|+		this.CanAttack(target) &&
|    |4601|+		this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|4602|4602| 		&& (this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|4603|4603| 	);
|4604|4604| 	if (!target)
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4598|4598| {
|4599|4599| 	var target = ents.find(target =>
|4600|4600| 		this.CanAttack(target)
|4601|    |-		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|4602|    |-		&& (this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|    |4601|+		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true)) &&
|    |4602|+		(this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|4603|4603| 	);
|4604|4604| 	if (!target)
|4605|4605| 		return false;
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before 'Engine'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4662|4662| 	// If we are guarding/escorting, don't abandon as long as the guarded unit is in target range of the attacker
|4663|4663| 	if (this.isGuardOf)
|4664|4664| 	{
|4665|    |-		var cmpUnitAI =  Engine.QueryInterface(target, IID_UnitAI);
|    |4665|+		var cmpUnitAI = Engine.QueryInterface(target, IID_UnitAI);
|4666|4666| 		var cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4667|4667| 		if (cmpUnitAI && cmpAttack &&
|4668|4668| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4666|4666| 		var cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4667|4667| 		if (cmpUnitAI && cmpAttack &&
|4668|4668| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|4669|    |-				return false;
|    |4669|+			return false;
|4670|4670| 	}
|4671|4671| 
|4672|4672| 	// Stop if we're in hold-ground mode and it's too far from the holding point
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before 'Engine'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4704|4704| 	// If we are guarding/escorting, chase at least as long as the guarded unit is in target range of the attacker
|4705|4705| 	if (this.isGuardOf)
|4706|4706| 	{
|4707|    |-		let cmpUnitAI =  Engine.QueryInterface(target, IID_UnitAI);
|    |4707|+		let cmpUnitAI = Engine.QueryInterface(target, IID_UnitAI);
|4708|4708| 		let cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4709|4709| 		if (cmpUnitAI && cmpAttack &&
|4710|4710| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4717|4717| 	return false;
|4718|4718| };
|4719|4719| 
|4720|    |-//// External interface functions ////
|    |4720|+// // External interface functions ////
|4721|4721| 
|4722|4722| UnitAI.prototype.SetFormationController = function(ent)
|4723|4723| {
|    | [NORMAL] ESLintBear (no-else-return):
|    | Unnecessary 'else' after 'return'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4873|4873| 	{
|4874|4874| 		if (this.isGuardOf == target && this.order && this.order.type == "Guard")
|4875|4875| 			return;
|4876|    |-		else
|4877|    |-			this.RemoveGuard();
|    |4876|+		this.RemoveGuard();
|4878|4877| 	}
|4879|4878| 
|4880|4879| 	this.AddOrder("Guard", { "target": target, "force": false }, queued);
|    | [NORMAL] ESLintBear (no-trailing-spaces):
|    | Trailing spaces not allowed.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5205|5205| 	    this.workOrders.length && this.workOrders[0].type == "Trade")
|5206|5206| 	{
|5207|5207| 		let cmpTrader = Engine.QueryInterface(this.entity, IID_Trader);
|5208|    |-		if (cmpTrader.HasBothMarkets() && 
|    |5208|+		if (cmpTrader.HasBothMarkets() &&
|5209|5209| 		   (cmpTrader.GetFirstMarket() == target && cmpTrader.GetSecondMarket() == source ||
|5210|5210| 		    cmpTrader.GetFirstMarket() == source && cmpTrader.GetSecondMarket() == target))
|5211|5211| 		{
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5486|5486| 				{
|5487|5487| 					var cmpIdentity = Engine.QueryInterface(targ, IID_Identity);
|5488|5488| 					var targetClasses = this.order.data.targetClasses;
|5489|    |-					if (targetClasses.attack && cmpIdentity
|5490|    |-						&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|    |5489|+					if (targetClasses.attack && cmpIdentity &&
|    |5490|+						!MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5491|5491| 						continue;
|5492|5492| 					if (targetClasses.avoid && cmpIdentity
|5493|5493| 						&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5489|5489| 					if (targetClasses.attack && cmpIdentity
|5490|5490| 						&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5491|5491| 						continue;
|5492|    |-					if (targetClasses.avoid && cmpIdentity
|5493|    |-						&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    |5492|+					if (targetClasses.avoid && cmpIdentity &&
|    |5493|+						MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|5494|5494| 						continue;
|5495|5495| 					// Only used by the AIs to prevent some choices of targets
|5496|5496| 					if (targetClasses.vetoEntities && targetClasses.vetoEntities[targ])
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5512|5512| 		{
|5513|5513| 			var cmpIdentity = Engine.QueryInterface(targ, IID_Identity);
|5514|5514| 			var targetClasses = this.order.data.targetClasses;
|5515|    |-			if (cmpIdentity && targetClasses.attack
|5516|    |-				&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|    |5515|+			if (cmpIdentity && targetClasses.attack &&
|    |5516|+				!MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5517|5517| 				continue;
|5518|5518| 			if (cmpIdentity && targetClasses.avoid
|5519|5519| 				&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5515|5515| 			if (cmpIdentity && targetClasses.attack
|5516|5516| 				&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5517|5517| 				continue;
|5518|    |-			if (cmpIdentity && targetClasses.avoid
|5519|    |-				&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    |5518|+			if (cmpIdentity && targetClasses.avoid &&
|    |5519|+				MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|5520|5520| 				continue;
|5521|5521| 			// Only used by the AIs to prevent some choices of targets
|5522|5522| 			if (targetClasses.vetoEntities && targetClasses.vetoEntities[targ])
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5672|5672| 
|5673|5673| UnitAI.prototype.SetHeldPosition = function(x, z)
|5674|5674| {
|5675|    |-	this.heldPosition = {"x": x, "z": z};
|    |5675|+	this.heldPosition = { "x": x, "z": z};
|5676|5676| };
|5677|5677| 
|5678|5678| UnitAI.prototype.SetHeldPositionOnEntity = function(entity)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5672|5672| 
|5673|5673| UnitAI.prototype.SetHeldPosition = function(x, z)
|5674|5674| {
|5675|    |-	this.heldPosition = {"x": x, "z": z};
|    |5675|+	this.heldPosition = {"x": x, "z": z };
|5676|5676| };
|5677|5677| 
|5678|5678| UnitAI.prototype.SetHeldPositionOnEntity = function(entity)
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5699|5699| 	return false;
|5700|5700| };
|5701|5701| 
|5702|    |-//// Helper functions ////
|    |5702|+// // Helper functions ////
|5703|5703| 
|5704|5704| UnitAI.prototype.CanAttack = function(target)
|5705|5705| {
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5897|5897| 	return cmpPack && cmpPack.IsPacking();
|5898|5898| };
|5899|5899| 
|5900|    |-//// Formation specific functions ////
|    |5900|+// // Formation specific functions ////
|5901|5901| 
|5902|5902| UnitAI.prototype.IsAttackingAsFormation = function()
|5903|5903| {
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5902|5902| UnitAI.prototype.IsAttackingAsFormation = function()
|5903|5903| {
|5904|5904| 	var cmpAttack = Engine.QueryInterface(this.entity, IID_Attack);
|5905|    |-	return cmpAttack && cmpAttack.CanAttackAsFormation()
|5906|    |-		&& this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|    |5905|+	return cmpAttack && cmpAttack.CanAttackAsFormation() &&
|    |5906|+		this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|5907|5907| };
|5908|5908| 
|5909|5909| //// Animal specific functions ////
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5906|5906| 		&& this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|5907|5907| };
|5908|5908| 
|5909|    |-//// Animal specific functions ////
|    |5909|+// // Animal specific functions ////
|5910|5910| 
|5911|5911| UnitAI.prototype.MoveRandomly = function(distance)
|5912|5912| {

binaries/data/mods/public/simulation/components/UnitAI.js
| 331| »   »   »   return·true;
|    | [NORMAL] ESLintBear (consistent-return):
|    | Method 'Order.WalkToTarget' expected no return value.

binaries/data/mods/public/simulation/components/UnitAI.js
| 907| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
| 932| »   »   »   "enter":·function(msg)·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
| 982| »   »   »   »   »   return·true;
|    | [NORMAL] ESLintBear (consistent-return):
|    | Method 'enter' expected no return value.

binaries/data/mods/public/simulation/components/UnitAI.js
|1045| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1081| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1113| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1273| »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1330| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1505| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1527| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1559| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1713| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1763| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1842| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2008| »   »   »   »   »   »   return·true;
|    | [NORMAL] ESLintBear (consistent-return):
|    | Method 'enter' expected no return value.

binaries/data/mods/public/simulation/components/UnitAI.js
|2013| »   »   »   »   »   »   return·true;
|    | [NORMAL] ESLintBear (consistent-return):
|    | Method 'enter' expected no return value.

binaries/data/mods/public/simulation/components/UnitAI.js
|2019| »   »   »   »   »   return·true;
|    | [NORMAL] ESLintBear (consistent-return):
|    | Method 'enter' expected no return value.

binaries/data/mods/public/simulation/components/UnitAI.js
|2024| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2127| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2382| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2415| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2521| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2587| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2626| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2837| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|3023| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|3753| »   var·isWorkType·=·type·=>·type·==·"Gather"·||·type·==·"Trade"·||·type·==·"Repair"·||·type·==·"ReturnResource";
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'type' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4584| »   var·target·=·ents.find(target·=>·this.CanAttack(target));
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'target' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4599| »   var·target·=·ents.find(target·=>
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'target' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4645| »   var·ent·=·ents.find(ent·=>·this.CanHeal(ent));
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'ent' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4668| »   »   ····cmpAttack.GetAttackTypes().some(type·=>·cmpUnitAI.CheckTargetAttackRange(this.isGuardOf,·type)))
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'type' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|1985| »   »   »   »   »   »   &&·this.order.data.target·!=·msg.data.attacker·&&·this.GetBestAttackAgainst(msg.data.attacker,·true)·!=·"Capture")
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|3715| »   »   var·order·=·{·"type":·type,·"data":·data·};
|    | [NORMAL] JSHintBear:
|    | 'order' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|3784| »   for·(var·i·=·0;·i·<·this.orderQueue.length;·++i)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|4601| »   »   &&·this.CheckTargetDistanceFromHeldPosition(target,·IID_Attack,·this.GetBestAttackAgainst(target,·true))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|4602| »   »   &&·(this.GetStance().respondChaseBeyondVision·||·this.CheckTargetIsInVisionRange(target))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5490| »   »   »   »   »   »   &&·!MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.attack))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5493| »   »   »   »   »   »   &&·MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.avoid))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5506| »   var·targets·=·this.GetTargetsFromUnit();
|    | [NORMAL] JSHintBear:
|    | 'targets' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5507| »   for·(var·targ·of·targets)
|    | [NORMAL] JSHintBear:
|    | 'targ' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5513| »   »   »   var·cmpIdentity·=·Engine.QueryInterface(targ,·IID_Identity);
|    | [NORMAL] JSHintBear:
|    | 'cmpIdentity' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5514| »   »   »   var·targetClasses·=·this.order.data.targetClasses;
|    | [NORMAL] JSHintBear:
|    | 'targetClasses' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5516| »   »   »   »   &&·!MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.attack))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5519| »   »   »   »   &&·MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.avoid))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5594| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5597| »   »   var·range·=·cmpVision.GetRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5602| »   »   var·cmpRanged·=·Engine.QueryInterface(this.entity,·iid);
|    | [NORMAL] JSHintBear:
|    | 'cmpRanged' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5605| »   »   var·range·=·iid·!==·IID_Attack·?·cmpRanged.GetRange()·:·cmpRanged.GetFullAttackRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5606| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5616| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5619| »   »   var·range·=·cmpVision.GetRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5906| »   »   &&·this.GetCurrentState()·==·"FORMATIONCONTROLLER.COMBAT.ATTACKING";
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/229/display/redirect

Harbormaster completed remote builds in B8592: Diff 9115.Jul 25 2019, 4:02 PM

Changed comment.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/581/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (no-else-return):
|    | Unnecessary 'else' after 'return'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
| 765| 765| 					this.FinishOrder();
| 766| 766| 					return;
| 767| 767| 				}
| 768|    |-				else
| 769|    |-				{
|    | 768|+				
| 770| 769| 					this.SetNextState("GARRISON.APPROACHING");
| 771| 770| 					return;
| 772|    |-				}
|    | 771|+				
| 773| 772| 			}
| 774| 773| 
| 775| 774| 			this.SetNextState("GARRISON.GARRISONING");
|    | [NORMAL] ESLintBear (key-spacing):
|    | Missing space before value for key 'GARRISON'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|1033|1033| 			},
|1034|1034| 		},
|1035|1035| 
|1036|    |-		"GARRISON":{
|    |1036|+		"GARRISON": {
|1037|1037| 			"enter": function() {
|1038|1038| 				// If the garrisonholder should pickup, warn it so it can take needed action
|1039|1039| 				var cmpGarrisonHolder = Engine.QueryInterface(this.order.data.target, IID_GarrisonHolder);
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|1982|1982| 
|1983|1983| 				"Attacked": function(msg) {
|1984|1984| 					// If we are capturing and are attacked by something that we would not capture, attack that entity instead
|1985|    |-					if (this.order.data.attackType == "Capture" && (this.GetStance().targetAttackersAlways || !this.order.data.force)
|1986|    |-						&& this.order.data.target != msg.data.attacker && this.GetBestAttackAgainst(msg.data.attacker, true) != "Capture")
|    |1985|+					if (this.order.data.attackType == "Capture" && (this.GetStance().targetAttackersAlways || !this.order.data.force) &&
|    |1986|+						this.order.data.target != msg.data.attacker && this.GetBestAttackAgainst(msg.data.attacker, true) != "Capture")
|1987|1987| 						this.RespondToTargetedEntities([msg.data.attacker]);
|1988|1988| 				},
|1989|1989| 			},
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|2710|2710| 					{
|2711|2711| 						// The building was already finished/fully repaired before we arrived;
|2712|2712| 						// let the ConstructionFinished handler handle this.
|2713|    |-						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget});
|    |2713|+						this.OnGlobalConstructionFinished({ "entity": this.repairTarget, "newentity": this.repairTarget});
|2714|2714| 						return true;
|2715|2715| 					}
|2716|2716| 
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|2710|2710| 					{
|2711|2711| 						// The building was already finished/fully repaired before we arrived;
|2712|2712| 						// let the ConstructionFinished handler handle this.
|2713|    |-						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget});
|    |2713|+						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget });
|2714|2714| 						return true;
|2715|2715| 					}
|2716|2716| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 2 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3228|3228| 		"COMBAT": "INDIVIDUAL.COMBAT", // reuse the same combat behaviour for animals
|3229|3229| 
|3230|3230| 		"WALKING": "INDIVIDUAL.WALKING",	// reuse the same walking behaviour for animals
|3231|    |-							// only used for domestic animals
|    |3231|+		// only used for domestic animals
|3232|3232| 
|3233|3233| 		"GARRISON": {
|3234|3234| 			// Reuse the same garrison behaviour for animals.
|    | [NORMAL] ESLintBear (no-unneeded-ternary):
|    | Unnecessary use of boolean literals in conditional expression.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3292|3292| 
|3293|3293| UnitAI.prototype.IsAnimal = function()
|3294|3294| {
|3295|    |-	return (this.template.NaturalBehaviour ? true : false);
|    |3295|+	return (!!this.template.NaturalBehaviour);
|3296|3296| };
|3297|3297| 
|3298|3298| UnitAI.prototype.IsDangerousAnimal = function()
|    | [NORMAL] ESLintBear (comma-spacing):
|    | A space is required after ','.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3408|3408| 		{
|3409|3409| 			let index = this.GetCurrentState().indexOf(".");
|3410|3410| 			if (index != -1)
|3411|    |-				this.UnitFsm.SwitchToNextState(this, this.GetCurrentState().slice(0,index));
|    |3411|+				this.UnitFsm.SwitchToNextState(this, this.GetCurrentState().slice(0, index));
|3412|3412| 			this.Stop(false);
|3413|3413| 		}
|3414|3414| 
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3464|3464| 		if (this.orderQueue[i].type != "PickupUnit" || this.orderQueue[i].data.target != msg.entity)
|3465|3465| 			continue;
|3466|3466| 		if (i == 0)
|3467|    |-			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg});
|    |3467|+			this.UnitFsm.ProcessMessage(this, { "type": "PickupCanceled", "data": msg});
|3468|3468| 		else
|3469|3469| 			this.orderQueue.splice(i, 1);
|3470|3470| 		Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3464|3464| 		if (this.orderQueue[i].type != "PickupUnit" || this.orderQueue[i].data.target != msg.entity)
|3465|3465| 			continue;
|3466|3466| 		if (i == 0)
|3467|    |-			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg});
|    |3467|+			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg });
|3468|3468| 		else
|3469|3469| 			this.orderQueue.splice(i, 1);
|3470|3470| 		Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3548|3548| };
|3549|3549| 
|3550|3550| 
|3551|    |-//// FSM linkage functions ////
|    |3551|+// // FSM linkage functions ////
|3552|3552| 
|3553|3553| // Setting the next state to the current state will leave/re-enter the top-most substate.
|3554|3554| UnitAI.prototype.SetNextState = function(state)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3718|3718| 				continue;
|3719|3719| 			if (this.orderQueue[i].type == type)
|3720|3720| 				continue;
|3721|    |-			this.orderQueue.splice(i, 0, {"type": type, "data": data});
|    |3721|+			this.orderQueue.splice(i, 0, { "type": type, "data": data});
|3722|3722| 			Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|3723|3723| 			return;
|3724|3724| 		}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3718|3718| 				continue;
|3719|3719| 			if (this.orderQueue[i].type == type)
|3720|3720| 				continue;
|3721|    |-			this.orderQueue.splice(i, 0, {"type": type, "data": data});
|    |3721|+			this.orderQueue.splice(i, 0, {"type": type, "data": data });
|3722|3722| 			Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|3723|3723| 			return;
|3724|3724| 		}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3889|3889| 	if (data.timerRepeat === undefined)
|3890|3890| 		this.timer = undefined;
|3891|3891| 
|3892|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness});
|    |3892|+	this.UnitFsm.ProcessMessage(this, { "type": "Timer", "data": data, "lateness": lateness});
|3893|3893| };
|3894|3894| 
|3895|3895| /**
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3889|3889| 	if (data.timerRepeat === undefined)
|3890|3890| 		this.timer = undefined;
|3891|3891| 
|3892|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness});
|    |3892|+	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness });
|3893|3893| };
|3894|3894| 
|3895|3895| /**
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3934|3934| 	// TODO: This is a bit inefficient since every unit listens to every
|3935|3935| 	// construction message - ideally we could scope it to only the one we're building
|3936|3936| 
|3937|    |-	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg});
|    |3937|+	this.UnitFsm.ProcessMessage(this, { "type": "ConstructionFinished", "data": msg});
|3938|3938| };
|3939|3939| 
|3940|3940| UnitAI.prototype.OnGlobalEntityRenamed = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3934|3934| 	// TODO: This is a bit inefficient since every unit listens to every
|3935|3935| 	// construction message - ideally we could scope it to only the one we're building
|3936|3936| 
|3937|    |-	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg});
|    |3937|+	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg });
|3938|3938| };
|3939|3939| 
|3940|3940| UnitAI.prototype.OnGlobalEntityRenamed = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3959|3959| 
|3960|3960| UnitAI.prototype.OnAttacked = function(msg)
|3961|3961| {
|3962|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg});
|    |3962|+	this.UnitFsm.ProcessMessage(this, { "type": "Attacked", "data": msg});
|3963|3963| };
|3964|3964| 
|3965|3965| UnitAI.prototype.OnGuardedAttacked = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3959|3959| 
|3960|3960| UnitAI.prototype.OnAttacked = function(msg)
|3961|3961| {
|3962|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg});
|    |3962|+	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg });
|3963|3963| };
|3964|3964| 
|3965|3965| UnitAI.prototype.OnGuardedAttacked = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3964|3964| 
|3965|3965| UnitAI.prototype.OnGuardedAttacked = function(msg)
|3966|3966| {
|3967|    |-	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data});
|    |3967|+	this.UnitFsm.ProcessMessage(this, { "type": "GuardedAttacked", "data": msg.data});
|3968|3968| };
|3969|3969| 
|3970|3970| UnitAI.prototype.OnHealthChanged = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3964|3964| 
|3965|3965| UnitAI.prototype.OnGuardedAttacked = function(msg)
|3966|3966| {
|3967|    |-	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data});
|    |3967|+	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data });
|3968|3968| };
|3969|3969| 
|3970|3970| UnitAI.prototype.OnHealthChanged = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3969|3969| 
|3970|3970| UnitAI.prototype.OnHealthChanged = function(msg)
|3971|3971| {
|3972|    |-	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to});
|    |3972|+	this.UnitFsm.ProcessMessage(this, { "type": "HealthChanged", "from": msg.from, "to": msg.to});
|3973|3973| };
|3974|3974| 
|3975|3975| UnitAI.prototype.OnRangeUpdate = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3969|3969| 
|3970|3970| UnitAI.prototype.OnHealthChanged = function(msg)
|3971|3971| {
|3972|    |-	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to});
|    |3972|+	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to });
|3973|3973| };
|3974|3974| 
|3975|3975| UnitAI.prototype.OnRangeUpdate = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3975|3975| UnitAI.prototype.OnRangeUpdate = function(msg)
|3976|3976| {
|3977|3977| 	if (msg.tag == this.losRangeQuery)
|3978|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|    |3978|+		this.UnitFsm.ProcessMessage(this, { "type": "LosRangeUpdate", "data": msg});
|3979|3979| 	else if (msg.tag == this.losHealRangeQuery)
|3980|3980| 		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|3981|3981| };
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3975|3975| UnitAI.prototype.OnRangeUpdate = function(msg)
|3976|3976| {
|3977|3977| 	if (msg.tag == this.losRangeQuery)
|3978|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|    |3978|+		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg });
|3979|3979| 	else if (msg.tag == this.losHealRangeQuery)
|3980|3980| 		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|3981|3981| };
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3977|3977| 	if (msg.tag == this.losRangeQuery)
|3978|3978| 		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|3979|3979| 	else if (msg.tag == this.losHealRangeQuery)
|3980|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|    |3980|+		this.UnitFsm.ProcessMessage(this, { "type": "LosHealRangeUpdate", "data": msg});
|3981|3981| };
|3982|3982| 
|3983|3983| UnitAI.prototype.OnPackFinished = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3977|3977| 	if (msg.tag == this.losRangeQuery)
|3978|3978| 		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|3979|3979| 	else if (msg.tag == this.losHealRangeQuery)
|3980|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|    |3980|+		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg });
|3981|3981| };
|3982|3982| 
|3983|3983| UnitAI.prototype.OnPackFinished = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3982|3982| 
|3983|3983| UnitAI.prototype.OnPackFinished = function(msg)
|3984|3984| {
|3985|    |-	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|    |3985|+	this.UnitFsm.ProcessMessage(this, { "type": "PackFinished", "packed": msg.packed});
|3986|3986| };
|3987|3987| 
|3988|3988| //// Helper functions to be called by the FSM ////
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3982|3982| 
|3983|3983| UnitAI.prototype.OnPackFinished = function(msg)
|3984|3984| {
|3985|    |-	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|    |3985|+	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed });
|3986|3986| };
|3987|3987| 
|3988|3988| //// Helper functions to be called by the FSM ////
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3985|3985| 	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|3986|3986| };
|3987|3987| 
|3988|    |-//// Helper functions to be called by the FSM ////
|    |3988|+// // Helper functions to be called by the FSM ////
|3989|3989| 
|3990|3990| UnitAI.prototype.GetWalkSpeed = function()
|3991|3991| {
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4654|4654| UnitAI.prototype.AttackEntityInZone = function(ents)
|4655|4655| {
|4656|4656| 	var target = ents.find(target =>
|4657|    |-		this.CanAttack(target)
|4658|    |-		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|    |4657|+		this.CanAttack(target) &&
|    |4658|+		this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|4659|4659| 		&& (this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|4660|4660| 	);
|4661|4661| 	if (!target)
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4655|4655| {
|4656|4656| 	var target = ents.find(target =>
|4657|4657| 		this.CanAttack(target)
|4658|    |-		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|4659|    |-		&& (this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|    |4658|+		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true)) &&
|    |4659|+		(this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|4660|4660| 	);
|4661|4661| 	if (!target)
|4662|4662| 		return false;
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before 'Engine'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4719|4719| 	// If we are guarding/escorting, don't abandon as long as the guarded unit is in target range of the attacker
|4720|4720| 	if (this.isGuardOf)
|4721|4721| 	{
|4722|    |-		var cmpUnitAI =  Engine.QueryInterface(target, IID_UnitAI);
|    |4722|+		var cmpUnitAI = Engine.QueryInterface(target, IID_UnitAI);
|4723|4723| 		var cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4724|4724| 		if (cmpUnitAI && cmpAttack &&
|4725|4725| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4723|4723| 		var cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4724|4724| 		if (cmpUnitAI && cmpAttack &&
|4725|4725| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|4726|    |-				return false;
|    |4726|+			return false;
|4727|4727| 	}
|4728|4728| 
|4729|4729| 	// Stop if we're in hold-ground mode and it's too far from the holding point
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before 'Engine'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4761|4761| 	// If we are guarding/escorting, chase at least as long as the guarded unit is in target range of the attacker
|4762|4762| 	if (this.isGuardOf)
|4763|4763| 	{
|4764|    |-		let cmpUnitAI =  Engine.QueryInterface(target, IID_UnitAI);
|    |4764|+		let cmpUnitAI = Engine.QueryInterface(target, IID_UnitAI);
|4765|4765| 		let cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4766|4766| 		if (cmpUnitAI && cmpAttack &&
|4767|4767| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4774|4774| 	return false;
|4775|4775| };
|4776|4776| 
|4777|    |-//// External interface functions ////
|    |4777|+// // External interface functions ////
|4778|4778| 
|4779|4779| UnitAI.prototype.SetFormationController = function(ent)
|4780|4780| {
|    | [NORMAL] ESLintBear (no-else-return):
|    | Unnecessary 'else' after 'return'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4930|4930| 	{
|4931|4931| 		if (this.isGuardOf == target && this.order && this.order.type == "Guard")
|4932|4932| 			return;
|4933|    |-		else
|4934|    |-			this.RemoveGuard();
|    |4933|+		this.RemoveGuard();
|4935|4934| 	}
|4936|4935| 
|4937|4936| 	this.AddOrder("Guard", { "target": target, "force": false }, queued);
|    | [NORMAL] ESLintBear (no-trailing-spaces):
|    | Trailing spaces not allowed.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5262|5262| 	    this.workOrders.length && this.workOrders[0].type == "Trade")
|5263|5263| 	{
|5264|5264| 		let cmpTrader = Engine.QueryInterface(this.entity, IID_Trader);
|5265|    |-		if (cmpTrader.HasBothMarkets() && 
|    |5265|+		if (cmpTrader.HasBothMarkets() &&
|5266|5266| 		   (cmpTrader.GetFirstMarket() == target && cmpTrader.GetSecondMarket() == source ||
|5267|5267| 		    cmpTrader.GetFirstMarket() == source && cmpTrader.GetSecondMarket() == target))
|5268|5268| 		{
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5543|5543| 				{
|5544|5544| 					var cmpIdentity = Engine.QueryInterface(targ, IID_Identity);
|5545|5545| 					var targetClasses = this.order.data.targetClasses;
|5546|    |-					if (targetClasses.attack && cmpIdentity
|5547|    |-						&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|    |5546|+					if (targetClasses.attack && cmpIdentity &&
|    |5547|+						!MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5548|5548| 						continue;
|5549|5549| 					if (targetClasses.avoid && cmpIdentity
|5550|5550| 						&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5546|5546| 					if (targetClasses.attack && cmpIdentity
|5547|5547| 						&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5548|5548| 						continue;
|5549|    |-					if (targetClasses.avoid && cmpIdentity
|5550|    |-						&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    |5549|+					if (targetClasses.avoid && cmpIdentity &&
|    |5550|+						MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|5551|5551| 						continue;
|5552|5552| 					// Only used by the AIs to prevent some choices of targets
|5553|5553| 					if (targetClasses.vetoEntities && targetClasses.vetoEntities[targ])
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5569|5569| 		{
|5570|5570| 			var cmpIdentity = Engine.QueryInterface(targ, IID_Identity);
|5571|5571| 			var targetClasses = this.order.data.targetClasses;
|5572|    |-			if (cmpIdentity && targetClasses.attack
|5573|    |-				&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|    |5572|+			if (cmpIdentity && targetClasses.attack &&
|    |5573|+				!MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5574|5574| 				continue;
|5575|5575| 			if (cmpIdentity && targetClasses.avoid
|5576|5576| 				&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5572|5572| 			if (cmpIdentity && targetClasses.attack
|5573|5573| 				&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5574|5574| 				continue;
|5575|    |-			if (cmpIdentity && targetClasses.avoid
|5576|    |-				&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    |5575|+			if (cmpIdentity && targetClasses.avoid &&
|    |5576|+				MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|5577|5577| 				continue;
|5578|5578| 			// Only used by the AIs to prevent some choices of targets
|5579|5579| 			if (targetClasses.vetoEntities && targetClasses.vetoEntities[targ])
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5729|5729| 
|5730|5730| UnitAI.prototype.SetHeldPosition = function(x, z)
|5731|5731| {
|5732|    |-	this.heldPosition = {"x": x, "z": z};
|    |5732|+	this.heldPosition = { "x": x, "z": z};
|5733|5733| };
|5734|5734| 
|5735|5735| UnitAI.prototype.SetHeldPositionOnEntity = function(entity)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5729|5729| 
|5730|5730| UnitAI.prototype.SetHeldPosition = function(x, z)
|5731|5731| {
|5732|    |-	this.heldPosition = {"x": x, "z": z};
|    |5732|+	this.heldPosition = {"x": x, "z": z };
|5733|5733| };
|5734|5734| 
|5735|5735| UnitAI.prototype.SetHeldPositionOnEntity = function(entity)
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5756|5756| 	return false;
|5757|5757| };
|5758|5758| 
|5759|    |-//// Helper functions ////
|    |5759|+// // Helper functions ////
|5760|5760| 
|5761|5761| UnitAI.prototype.CanAttack = function(target)
|5762|5762| {
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5954|5954| 	return cmpPack && cmpPack.IsPacking();
|5955|5955| };
|5956|5956| 
|5957|    |-//// Formation specific functions ////
|    |5957|+// // Formation specific functions ////
|5958|5958| 
|5959|5959| UnitAI.prototype.IsAttackingAsFormation = function()
|5960|5960| {
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5959|5959| UnitAI.prototype.IsAttackingAsFormation = function()
|5960|5960| {
|5961|5961| 	var cmpAttack = Engine.QueryInterface(this.entity, IID_Attack);
|5962|    |-	return cmpAttack && cmpAttack.CanAttackAsFormation()
|5963|    |-		&& this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|    |5962|+	return cmpAttack && cmpAttack.CanAttackAsFormation() &&
|    |5963|+		this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|5964|5964| };
|5965|5965| 
|5966|5966| //// Animal specific functions ////
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5963|5963| 		&& this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|5964|5964| };
|5965|5965| 
|5966|    |-//// Animal specific functions ////
|    |5966|+// // Animal specific functions ////
|5967|5967| 
|5968|5968| UnitAI.prototype.MoveRandomly = function(distance)
|5969|5969| {

binaries/data/mods/public/simulation/components/UnitAI.js
| 331| »   »   »   return·true;
|    | [NORMAL] ESLintBear (consistent-return):
|    | Method 'Order.WalkToTarget' expected no return value.

binaries/data/mods/public/simulation/components/UnitAI.js
| 920| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
| 945| »   »   »   "enter":·function(msg)·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
| 995| »   »   »   »   »   return·true;
|    | [NORMAL] ESLintBear (consistent-return):
|    | Method 'enter' expected no return value.

binaries/data/mods/public/simulation/components/UnitAI.js
|1058| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1094| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1126| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1286| »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1343| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1518| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1540| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1572| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1726| »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1776| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|1854| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2031| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2147| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2422| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2455| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2561| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2627| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2666| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|2877| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|3063| »   »   »   »   "enter":·function()·{
|    | [NORMAL] ESLintBear (consistent-return):
|    | Expected to return a value at the end of method 'enter'.

binaries/data/mods/public/simulation/components/UnitAI.js
|3794| »   var·isWorkType·=·type·=>·type·==·"Gather"·||·type·==·"Trade"·||·type·==·"Repair"·||·type·==·"ReturnResource";
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'type' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4641| »   var·target·=·ents.find(target·=>·this.CanAttack(target));
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'target' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4656| »   var·target·=·ents.find(target·=>
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'target' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4702| »   var·ent·=·ents.find(ent·=>·this.CanHeal(ent));
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'ent' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4725| »   »   ····cmpAttack.GetAttackTypes().some(type·=>·cmpUnitAI.CheckTargetAttackRange(this.isGuardOf,·type)))
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'type' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|1986| »   »   »   »   »   »   &&·this.order.data.target·!=·msg.data.attacker·&&·this.GetBestAttackAgainst(msg.data.attacker,·true)·!=·"Capture")
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|3756| »   »   var·order·=·{·"type":·type,·"data":·data·};
|    | [NORMAL] JSHintBear:
|    | 'order' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|3825| »   for·(var·i·=·0;·i·<·this.orderQueue.length;·++i)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|4658| »   »   &&·this.CheckTargetDistanceFromHeldPosition(target,·IID_Attack,·this.GetBestAttackAgainst(target,·true))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|4659| »   »   &&·(this.GetStance().respondChaseBeyondVision·||·this.CheckTargetIsInVisionRange(target))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5547| »   »   »   »   »   »   &&·!MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.attack))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5550| »   »   »   »   »   »   &&·MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.avoid))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5563| »   var·targets·=·this.GetTargetsFromUnit();
|    | [NORMAL] JSHintBear:
|    | 'targets' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5564| »   for·(var·targ·of·targets)
|    | [NORMAL] JSHintBear:
|    | 'targ' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5570| »   »   »   var·cmpIdentity·=·Engine.QueryInterface(targ,·IID_Identity);
|    | [NORMAL] JSHintBear:
|    | 'cmpIdentity' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5571| »   »   »   var·targetClasses·=·this.order.data.targetClasses;
|    | [NORMAL] JSHintBear:
|    | 'targetClasses' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5573| »   »   »   »   &&·!MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.attack))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5576| »   »   »   »   &&·MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.avoid))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5651| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5654| »   »   var·range·=·cmpVision.GetRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5659| »   »   var·cmpRanged·=·Engine.QueryInterface(this.entity,·iid);
|    | [NORMAL] JSHintBear:
|    | 'cmpRanged' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5662| »   »   var·range·=·iid·!==·IID_Attack·?·cmpRanged.GetRange()·:·cmpRanged.GetFullAttackRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5663| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5673| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5676| »   »   var·range·=·cmpVision.GetRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5963| »   »   &&·this.GetCurrentState()·==·"FORMATIONCONTROLLER.COMBAT.ATTACKING";
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1095/display/redirect

Harbormaster completed remote builds in B10024: Diff 10330.Nov 15 2019, 6:53 PM

Silier requested changes to this revision.Jan 8 2020, 9:08 AM

Silier added inline comments.

binaries/data/mods/public/simulation/components/UnitAI.js
2852	this should not be needed, if animal, "ANIMAL.GARRISON." should be kept and not switched to "INDIVIDUAL.GARRISON"
3193	You need to reuse whole Garrison state, no just approaching and garrisoned

This revision now requires changes to proceed.Jan 8 2020, 9:08 AM

Reuse the entire GARRISON-state.

Accidentally left the template change to test this in, but that can be removed when commiting (or on next update).

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1014/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (no-else-return):
|    | Unnecessary 'else' after 'return'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
| 785| 785| 					this.FinishOrder();
| 786| 786| 					return;
| 787| 787| 				}
| 788|    |-				else
| 789|    |-				{
|    | 788|+				
| 790| 789| 					this.SetNextState("GARRISON.APPROACHING");
| 791| 790| 					return;
| 792|    |-				}
|    | 791|+				
| 793| 792| 			}
| 794| 793| 
| 795| 794| 			this.SetNextState("GARRISON.GARRISONING");
|    | [NORMAL] ESLintBear (key-spacing):
|    | Missing space before value for key 'GARRISON'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|1057|1057| 			},
|1058|1058| 		},
|1059|1059| 
|1060|    |-		"GARRISON":{
|    |1060|+		"GARRISON": {
|1061|1061| 			"APPROACHING": {
|1062|1062| 				"enter": function() {
|1063|1063| 					if (!this.MoveToGarrisonRange(this.order.data.target))
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|2035|2035| 
|2036|2036| 				"Attacked": function(msg) {
|2037|2037| 					// If we are capturing and are attacked by something that we would not capture, attack that entity instead
|2038|    |-					if (this.order.data.attackType == "Capture" && (this.GetStance().targetAttackersAlways || !this.order.data.force)
|2039|    |-						&& this.order.data.target != msg.data.attacker && this.GetBestAttackAgainst(msg.data.attacker, true) != "Capture")
|    |2038|+					if (this.order.data.attackType == "Capture" && (this.GetStance().targetAttackersAlways || !this.order.data.force) &&
|    |2039|+						this.order.data.target != msg.data.attacker && this.GetBestAttackAgainst(msg.data.attacker, true) != "Capture")
|2040|2040| 						this.RespondToTargetedEntities([msg.data.attacker]);
|2041|2041| 				},
|2042|2042| 			},
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|2771|2771| 					{
|2772|2772| 						// The building was already finished/fully repaired before we arrived;
|2773|2773| 						// let the ConstructionFinished handler handle this.
|2774|    |-						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget});
|    |2774|+						this.OnGlobalConstructionFinished({ "entity": this.repairTarget, "newentity": this.repairTarget});
|2775|2775| 						return true;
|2776|2776| 					}
|2777|2777| 
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|2771|2771| 					{
|2772|2772| 						// The building was already finished/fully repaired before we arrived;
|2773|2773| 						// let the ConstructionFinished handler handle this.
|2774|    |-						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget});
|    |2774|+						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget });
|2775|2775| 						return true;
|2776|2776| 					}
|2777|2777| 
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3069|3069| 				this.StopTimer();
|3070|3070| 				this.ResetAnimation();
|3071|3071| 				if (this.formationAnimationVariant)
|3072|    |-					this.SetAnimationVariant(this.formationAnimationVariant)
|    |3072|+					this.SetAnimationVariant(this.formationAnimationVariant);
|3073|3073| 				else
|3074|3074| 					this.SetDefaultAnimationVariant();
|3075|3075| 				var cmpResistance = Engine.QueryInterface(this.entity, IID_Resistance);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 2 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3295|3295| 		"COMBAT": "INDIVIDUAL.COMBAT", // reuse the same combat behaviour for animals
|3296|3296| 
|3297|3297| 		"WALKING": "INDIVIDUAL.WALKING",	// reuse the same walking behaviour for animals
|3298|    |-							// only used for domestic animals
|    |3298|+		// only used for domestic animals
|3299|3299| 
|3300|3300| 		// Reuse the same garrison behaviour for animals.
|3301|3301| 		"GARRISON": "INDIVIDUAL.GARRISON",
|    | [NORMAL] ESLintBear (no-unneeded-ternary):
|    | Unnecessary use of boolean literals in conditional expression.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3357|3357| 
|3358|3358| UnitAI.prototype.IsAnimal = function()
|3359|3359| {
|3360|    |-	return (this.template.NaturalBehaviour ? true : false);
|    |3360|+	return (!!this.template.NaturalBehaviour);
|3361|3361| };
|3362|3362| 
|3363|3363| UnitAI.prototype.IsDangerousAnimal = function()
|    | [NORMAL] ESLintBear (comma-spacing):
|    | A space is required after ','.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3473|3473| 		{
|3474|3474| 			let index = this.GetCurrentState().indexOf(".");
|3475|3475| 			if (index != -1)
|3476|    |-				this.UnitFsm.SwitchToNextState(this, this.GetCurrentState().slice(0,index));
|    |3476|+				this.UnitFsm.SwitchToNextState(this, this.GetCurrentState().slice(0, index));
|3477|3477| 			this.Stop(false);
|3478|3478| 		}
|3479|3479| 
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3529|3529| 		if (this.orderQueue[i].type != "PickupUnit" || this.orderQueue[i].data.target != msg.entity)
|3530|3530| 			continue;
|3531|3531| 		if (i == 0)
|3532|    |-			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg});
|    |3532|+			this.UnitFsm.ProcessMessage(this, { "type": "PickupCanceled", "data": msg});
|3533|3533| 		else
|3534|3534| 			this.orderQueue.splice(i, 1);
|3535|3535| 		Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3529|3529| 		if (this.orderQueue[i].type != "PickupUnit" || this.orderQueue[i].data.target != msg.entity)
|3530|3530| 			continue;
|3531|3531| 		if (i == 0)
|3532|    |-			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg});
|    |3532|+			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg });
|3533|3533| 		else
|3534|3534| 			this.orderQueue.splice(i, 1);
|3535|3535| 		Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3613|3613| };
|3614|3614| 
|3615|3615| 
|3616|    |-//// FSM linkage functions ////
|    |3616|+// // FSM linkage functions ////
|3617|3617| 
|3618|3618| // Setting the next state to the current state will leave/re-enter the top-most substate.
|3619|3619| UnitAI.prototype.SetNextState = function(state)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3784|3784| 				continue;
|3785|3785| 			if (this.orderQueue[i].type == type)
|3786|3786| 				continue;
|3787|    |-			this.orderQueue.splice(i, 0, {"type": type, "data": data});
|    |3787|+			this.orderQueue.splice(i, 0, { "type": type, "data": data});
|3788|3788| 			Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|3789|3789| 			return;
|3790|3790| 		}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3784|3784| 				continue;
|3785|3785| 			if (this.orderQueue[i].type == type)
|3786|3786| 				continue;
|3787|    |-			this.orderQueue.splice(i, 0, {"type": type, "data": data});
|    |3787|+			this.orderQueue.splice(i, 0, {"type": type, "data": data });
|3788|3788| 			Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|3789|3789| 			return;
|3790|3790| 		}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4026|4026| 	if (data.timerRepeat === undefined)
|4027|4027| 		this.timer = undefined;
|4028|4028| 
|4029|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness});
|    |4029|+	this.UnitFsm.ProcessMessage(this, { "type": "Timer", "data": data, "lateness": lateness});
|4030|4030| };
|4031|4031| 
|4032|4032| /**
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4026|4026| 	if (data.timerRepeat === undefined)
|4027|4027| 		this.timer = undefined;
|4028|4028| 
|4029|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness});
|    |4029|+	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness });
|4030|4030| };
|4031|4031| 
|4032|4032| /**
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4071|4071| 	// TODO: This is a bit inefficient since every unit listens to every
|4072|4072| 	// construction message - ideally we could scope it to only the one we're building
|4073|4073| 
|4074|    |-	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg});
|    |4074|+	this.UnitFsm.ProcessMessage(this, { "type": "ConstructionFinished", "data": msg});
|4075|4075| };
|4076|4076| 
|4077|4077| UnitAI.prototype.OnGlobalEntityRenamed = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4071|4071| 	// TODO: This is a bit inefficient since every unit listens to every
|4072|4072| 	// construction message - ideally we could scope it to only the one we're building
|4073|4073| 
|4074|    |-	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg});
|    |4074|+	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg });
|4075|4075| };
|4076|4076| 
|4077|4077| UnitAI.prototype.OnGlobalEntityRenamed = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4096|4096| 
|4097|4097| UnitAI.prototype.OnAttacked = function(msg)
|4098|4098| {
|4099|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg});
|    |4099|+	this.UnitFsm.ProcessMessage(this, { "type": "Attacked", "data": msg});
|4100|4100| };
|4101|4101| 
|4102|4102| UnitAI.prototype.OnGuardedAttacked = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4096|4096| 
|4097|4097| UnitAI.prototype.OnAttacked = function(msg)
|4098|4098| {
|4099|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg});
|    |4099|+	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg });
|4100|4100| };
|4101|4101| 
|4102|4102| UnitAI.prototype.OnGuardedAttacked = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4101|4101| 
|4102|4102| UnitAI.prototype.OnGuardedAttacked = function(msg)
|4103|4103| {
|4104|    |-	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data});
|    |4104|+	this.UnitFsm.ProcessMessage(this, { "type": "GuardedAttacked", "data": msg.data});
|4105|4105| };
|4106|4106| 
|4107|4107| UnitAI.prototype.OnHealthChanged = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4101|4101| 
|4102|4102| UnitAI.prototype.OnGuardedAttacked = function(msg)
|4103|4103| {
|4104|    |-	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data});
|    |4104|+	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data });
|4105|4105| };
|4106|4106| 
|4107|4107| UnitAI.prototype.OnHealthChanged = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4106|4106| 
|4107|4107| UnitAI.prototype.OnHealthChanged = function(msg)
|4108|4108| {
|4109|    |-	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to});
|    |4109|+	this.UnitFsm.ProcessMessage(this, { "type": "HealthChanged", "from": msg.from, "to": msg.to});
|4110|4110| };
|4111|4111| 
|4112|4112| UnitAI.prototype.OnRangeUpdate = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4106|4106| 
|4107|4107| UnitAI.prototype.OnHealthChanged = function(msg)
|4108|4108| {
|4109|    |-	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to});
|    |4109|+	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to });
|4110|4110| };
|4111|4111| 
|4112|4112| UnitAI.prototype.OnRangeUpdate = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4112|4112| UnitAI.prototype.OnRangeUpdate = function(msg)
|4113|4113| {
|4114|4114| 	if (msg.tag == this.losRangeQuery)
|4115|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|    |4115|+		this.UnitFsm.ProcessMessage(this, { "type": "LosRangeUpdate", "data": msg});
|4116|4116| 	else if (msg.tag == this.losHealRangeQuery)
|4117|4117| 		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|4118|4118| };
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4112|4112| UnitAI.prototype.OnRangeUpdate = function(msg)
|4113|4113| {
|4114|4114| 	if (msg.tag == this.losRangeQuery)
|4115|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|    |4115|+		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg });
|4116|4116| 	else if (msg.tag == this.losHealRangeQuery)
|4117|4117| 		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|4118|4118| };
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4114|4114| 	if (msg.tag == this.losRangeQuery)
|4115|4115| 		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|4116|4116| 	else if (msg.tag == this.losHealRangeQuery)
|4117|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|    |4117|+		this.UnitFsm.ProcessMessage(this, { "type": "LosHealRangeUpdate", "data": msg});
|4118|4118| };
|4119|4119| 
|4120|4120| UnitAI.prototype.OnPackFinished = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4114|4114| 	if (msg.tag == this.losRangeQuery)
|4115|4115| 		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|4116|4116| 	else if (msg.tag == this.losHealRangeQuery)
|4117|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|    |4117|+		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg });
|4118|4118| };
|4119|4119| 
|4120|4120| UnitAI.prototype.OnPackFinished = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4119|4119| 
|4120|4120| UnitAI.prototype.OnPackFinished = function(msg)
|4121|4121| {
|4122|    |-	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|    |4122|+	this.UnitFsm.ProcessMessage(this, { "type": "PackFinished", "packed": msg.packed});
|4123|4123| };
|4124|4124| 
|4125|4125| //// Helper functions to be called by the FSM ////
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4119|4119| 
|4120|4120| UnitAI.prototype.OnPackFinished = function(msg)
|4121|4121| {
|4122|    |-	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|    |4122|+	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed });
|4123|4123| };
|4124|4124| 
|4125|4125| //// Helper functions to be called by the FSM ////
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4122|4122| 	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|4123|4123| };
|4124|4124| 
|4125|    |-//// Helper functions to be called by the FSM ////
|    |4125|+// // Helper functions to be called by the FSM ////
|4126|4126| 
|4127|4127| UnitAI.prototype.GetWalkSpeed = function()
|4128|4128| {
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4787|4787| UnitAI.prototype.AttackEntityInZone = function(ents)
|4788|4788| {
|4789|4789| 	var target = ents.find(target =>
|4790|    |-		this.CanAttack(target)
|4791|    |-		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|    |4790|+		this.CanAttack(target) &&
|    |4791|+		this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|4792|4792| 		&& (this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|4793|4793| 	);
|4794|4794| 	if (!target)
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4788|4788| {
|4789|4789| 	var target = ents.find(target =>
|4790|4790| 		this.CanAttack(target)
|4791|    |-		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|4792|    |-		&& (this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|    |4791|+		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true)) &&
|    |4792|+		(this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|4793|4793| 	);
|4794|4794| 	if (!target)
|4795|4795| 		return false;
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before 'Engine'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4852|4852| 	// If we are guarding/escorting, don't abandon as long as the guarded unit is in target range of the attacker
|4853|4853| 	if (this.isGuardOf)
|4854|4854| 	{
|4855|    |-		var cmpUnitAI =  Engine.QueryInterface(target, IID_UnitAI);
|    |4855|+		var cmpUnitAI = Engine.QueryInterface(target, IID_UnitAI);
|4856|4856| 		var cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4857|4857| 		if (cmpUnitAI && cmpAttack &&
|4858|4858| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4856|4856| 		var cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4857|4857| 		if (cmpUnitAI && cmpAttack &&
|4858|4858| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|4859|    |-				return false;
|    |4859|+			return false;
|4860|4860| 	}
|4861|4861| 
|4862|4862| 	// Stop if we're in hold-ground mode and it's too far from the holding point
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before 'Engine'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4894|4894| 	// If we are guarding/escorting, chase at least as long as the guarded unit is in target range of the attacker
|4895|4895| 	if (this.isGuardOf)
|4896|4896| 	{
|4897|    |-		let cmpUnitAI =  Engine.QueryInterface(target, IID_UnitAI);
|    |4897|+		let cmpUnitAI = Engine.QueryInterface(target, IID_UnitAI);
|4898|4898| 		let cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4899|4899| 		if (cmpUnitAI && cmpAttack &&
|4900|4900| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4907|4907| 	return false;
|4908|4908| };
|4909|4909| 
|4910|    |-//// External interface functions ////
|    |4910|+// // External interface functions ////
|4911|4911| 
|4912|4912| UnitAI.prototype.SetFormationController = function(ent)
|4913|4913| {
|    | [NORMAL] ESLintBear (no-else-return):
|    | Unnecessary 'else' after 'return'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5063|5063| 	{
|5064|5064| 		if (this.isGuardOf == target && this.order && this.order.type == "Guard")
|5065|5065| 			return;
|5066|    |-		else
|5067|    |-			this.RemoveGuard();
|    |5066|+		this.RemoveGuard();
|5068|5067| 	}
|5069|5068| 
|5070|5069| 	this.AddOrder("Guard", { "target": target, "force": false }, queued);
|    | [NORMAL] ESLintBear (no-trailing-spaces):
|    | Trailing spaces not allowed.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5405|5405| 	    this.workOrders.length && this.workOrders[0].type == "Trade")
|5406|5406| 	{
|5407|5407| 		let cmpTrader = Engine.QueryInterface(this.entity, IID_Trader);
|5408|    |-		if (cmpTrader.HasBothMarkets() && 
|    |5408|+		if (cmpTrader.HasBothMarkets() &&
|5409|5409| 		   (cmpTrader.GetFirstMarket() == target && cmpTrader.GetSecondMarket() == source ||
|5410|5410| 		    cmpTrader.GetFirstMarket() == source && cmpTrader.GetSecondMarket() == target))
|5411|5411| 		{
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5686|5686| 				{
|5687|5687| 					var cmpIdentity = Engine.QueryInterface(targ, IID_Identity);
|5688|5688| 					var targetClasses = this.order.data.targetClasses;
|5689|    |-					if (targetClasses.attack && cmpIdentity
|5690|    |-						&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|    |5689|+					if (targetClasses.attack && cmpIdentity &&
|    |5690|+						!MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5691|5691| 						continue;
|5692|5692| 					if (targetClasses.avoid && cmpIdentity
|5693|5693| 						&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5689|5689| 					if (targetClasses.attack && cmpIdentity
|5690|5690| 						&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5691|5691| 						continue;
|5692|    |-					if (targetClasses.avoid && cmpIdentity
|5693|    |-						&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    |5692|+					if (targetClasses.avoid && cmpIdentity &&
|    |5693|+						MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|5694|5694| 						continue;
|5695|5695| 					// Only used by the AIs to prevent some choices of targets
|5696|5696| 					if (targetClasses.vetoEntities && targetClasses.vetoEntities[targ])
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5712|5712| 		{
|5713|5713| 			var cmpIdentity = Engine.QueryInterface(targ, IID_Identity);
|5714|5714| 			var targetClasses = this.order.data.targetClasses;
|5715|    |-			if (cmpIdentity && targetClasses.attack
|5716|    |-				&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|    |5715|+			if (cmpIdentity && targetClasses.attack &&
|    |5716|+				!MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5717|5717| 				continue;
|5718|5718| 			if (cmpIdentity && targetClasses.avoid
|5719|5719| 				&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5715|5715| 			if (cmpIdentity && targetClasses.attack
|5716|5716| 				&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5717|5717| 				continue;
|5718|    |-			if (cmpIdentity && targetClasses.avoid
|5719|    |-				&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    |5718|+			if (cmpIdentity && targetClasses.avoid &&
|    |5719|+				MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|5720|5720| 				continue;
|5721|5721| 			// Only used by the AIs to prevent some choices of targets
|5722|5722| 			if (targetClasses.vetoEntities && targetClasses.vetoEntities[targ])
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5872|5872| 
|5873|5873| UnitAI.prototype.SetHeldPosition = function(x, z)
|5874|5874| {
|5875|    |-	this.heldPosition = {"x": x, "z": z};
|    |5875|+	this.heldPosition = { "x": x, "z": z};
|5876|5876| };
|5877|5877| 
|5878|5878| UnitAI.prototype.SetHeldPositionOnEntity = function(entity)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5872|5872| 
|5873|5873| UnitAI.prototype.SetHeldPosition = function(x, z)
|5874|5874| {
|5875|    |-	this.heldPosition = {"x": x, "z": z};
|    |5875|+	this.heldPosition = {"x": x, "z": z };
|5876|5876| };
|5877|5877| 
|5878|5878| UnitAI.prototype.SetHeldPositionOnEntity = function(entity)
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5899|5899| 	return false;
|5900|5900| };
|5901|5901| 
|5902|    |-//// Helper functions ////
|    |5902|+// // Helper functions ////
|5903|5903| 
|5904|5904| UnitAI.prototype.CanAttack = function(target)
|5905|5905| {
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|6097|6097| 	return cmpPack && cmpPack.IsPacking();
|6098|6098| };
|6099|6099| 
|6100|    |-//// Formation specific functions ////
|    |6100|+// // Formation specific functions ////
|6101|6101| 
|6102|6102| UnitAI.prototype.IsAttackingAsFormation = function()
|6103|6103| {
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|6102|6102| UnitAI.prototype.IsAttackingAsFormation = function()
|6103|6103| {
|6104|6104| 	var cmpAttack = Engine.QueryInterface(this.entity, IID_Attack);
|6105|    |-	return cmpAttack && cmpAttack.CanAttackAsFormation()
|6106|    |-		&& this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|    |6105|+	return cmpAttack && cmpAttack.CanAttackAsFormation() &&
|    |6106|+		this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|6107|6107| };
|6108|6108| 
|6109|6109| //// Animal specific functions ////
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|6106|6106| 		&& this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|6107|6107| };
|6108|6108| 
|6109|    |-//// Animal specific functions ////
|    |6109|+// // Animal specific functions ////
|6110|6110| 
|6111|6111| UnitAI.prototype.MoveRandomly = function(distance)
|6112|6112| {

binaries/data/mods/public/simulation/components/UnitAI.js
| 338| »   »   »   return·true;
|    | [NORMAL] ESLintBear (consistent-return):
|    | Method 'Order.WalkToTarget' expected no return value.

binaries/data/mods/public/simulation/components/UnitAI.js
|1245| »   »   »   »   return·false;
|    | [NORMAL] ESLintBear (consistent-return):
|    | Method 'Timer' expected no return value.

binaries/data/mods/public/simulation/components/UnitAI.js
|3931| »   var·isWorkType·=·type·=>·type·==·"Gather"·||·type·==·"Trade"·||·type·==·"Repair"·||·type·==·"ReturnResource";
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'type' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4774| »   var·target·=·ents.find(target·=>·this.CanAttack(target));
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'target' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4789| »   var·target·=·ents.find(target·=>
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'target' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4835| »   var·ent·=·ents.find(ent·=>·this.CanHeal(ent));
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'ent' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4858| »   »   ····cmpAttack.GetAttackTypes().some(type·=>·cmpUnitAI.CheckTargetAttackRange(this.isGuardOf,·type)))
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'type' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|2039| »   »   »   »   »   »   &&·this.order.data.target·!=·msg.data.attacker·&&·this.GetBestAttackAgainst(msg.data.attacker,·true)·!=·"Capture")
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|3072| »   »   »   »   »   this.SetAnimationVariant(this.formationAnimationVariant)
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/UnitAI.js
|3878| »   »   var·order·=·{·"type":·type,·"data":·data·};
|    | [NORMAL] JSHintBear:
|    | 'order' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|3962| »   for·(var·i·=·0;·i·<·this.orderQueue.length;·++i)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|4791| »   »   &&·this.CheckTargetDistanceFromHeldPosition(target,·IID_Attack,·this.GetBestAttackAgainst(target,·true))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|4792| »   »   &&·(this.GetStance().respondChaseBeyondVision·||·this.CheckTargetIsInVisionRange(target))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5690| »   »   »   »   »   »   &&·!MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.attack))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5693| »   »   »   »   »   »   &&·MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.avoid))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5706| »   var·targets·=·this.GetTargetsFromUnit();
|    | [NORMAL] JSHintBear:
|    | 'targets' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5707| »   for·(var·targ·of·targets)
|    | [NORMAL] JSHintBear:
|    | 'targ' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5713| »   »   »   var·cmpIdentity·=·Engine.QueryInterface(targ,·IID_Identity);
|    | [NORMAL] JSHintBear:
|    | 'cmpIdentity' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5714| »   »   »   var·targetClasses·=·this.order.data.targetClasses;
|    | [NORMAL] JSHintBear:
|    | 'targetClasses' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5716| »   »   »   »   &&·!MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.attack))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5719| »   »   »   »   &&·MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.avoid))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5794| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5797| »   »   var·range·=·cmpVision.GetRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5802| »   »   var·cmpRanged·=·Engine.QueryInterface(this.entity,·iid);
|    | [NORMAL] JSHintBear:
|    | 'cmpRanged' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5805| »   »   var·range·=·iid·!==·IID_Attack·?·cmpRanged.GetRange()·:·cmpRanged.GetFullAttackRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5806| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5816| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5819| »   »   var·range·=·cmpVision.GetRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|6106| »   »   &&·this.GetCurrentState()·==·"FORMATIONCONTROLLER.COMBAT.ATTACKING";
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1532/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/110/display/redirect

Harbormaster completed remote builds in B10757: Diff 10987.Jan 12 2020, 4:23 PM

You missed one case, else should be good i ll test tonight.

binaries/data/mods/public/simulation/components/UnitAI.js
611	missed

This revision now requires changes to proceed.Jan 13 2020, 8:15 AM

Added misses check.

Freagarach marked an inline comment as done.Jan 13 2020, 7:43 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1031/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (no-else-return):
|    | Unnecessary 'else' after 'return'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
| 788| 788| 					this.FinishOrder();
| 789| 789| 					return;
| 790| 790| 				}
| 791|    |-				else
| 792|    |-				{
|    | 791|+				
| 793| 792| 					this.SetNextState("GARRISON.APPROACHING");
| 794| 793| 					return;
| 795|    |-				}
|    | 794|+				
| 796| 795| 			}
| 797| 796| 
| 798| 797| 			this.SetNextState("GARRISON.GARRISONING");
|    | [NORMAL] ESLintBear (key-spacing):
|    | Missing space before value for key 'GARRISON'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|1060|1060| 			},
|1061|1061| 		},
|1062|1062| 
|1063|    |-		"GARRISON":{
|    |1063|+		"GARRISON": {
|1064|1064| 			"APPROACHING": {
|1065|1065| 				"enter": function() {
|1066|1066| 					if (!this.MoveToGarrisonRange(this.order.data.target))
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|2038|2038| 
|2039|2039| 				"Attacked": function(msg) {
|2040|2040| 					// If we are capturing and are attacked by something that we would not capture, attack that entity instead
|2041|    |-					if (this.order.data.attackType == "Capture" && (this.GetStance().targetAttackersAlways || !this.order.data.force)
|2042|    |-						&& this.order.data.target != msg.data.attacker && this.GetBestAttackAgainst(msg.data.attacker, true) != "Capture")
|    |2041|+					if (this.order.data.attackType == "Capture" && (this.GetStance().targetAttackersAlways || !this.order.data.force) &&
|    |2042|+						this.order.data.target != msg.data.attacker && this.GetBestAttackAgainst(msg.data.attacker, true) != "Capture")
|2043|2043| 						this.RespondToTargetedEntities([msg.data.attacker]);
|2044|2044| 				},
|2045|2045| 			},
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|2774|2774| 					{
|2775|2775| 						// The building was already finished/fully repaired before we arrived;
|2776|2776| 						// let the ConstructionFinished handler handle this.
|2777|    |-						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget});
|    |2777|+						this.OnGlobalConstructionFinished({ "entity": this.repairTarget, "newentity": this.repairTarget});
|2778|2778| 						return true;
|2779|2779| 					}
|2780|2780| 
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|2774|2774| 					{
|2775|2775| 						// The building was already finished/fully repaired before we arrived;
|2776|2776| 						// let the ConstructionFinished handler handle this.
|2777|    |-						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget});
|    |2777|+						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget });
|2778|2778| 						return true;
|2779|2779| 					}
|2780|2780| 
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3072|3072| 				this.StopTimer();
|3073|3073| 				this.ResetAnimation();
|3074|3074| 				if (this.formationAnimationVariant)
|3075|    |-					this.SetAnimationVariant(this.formationAnimationVariant)
|    |3075|+					this.SetAnimationVariant(this.formationAnimationVariant);
|3076|3076| 				else
|3077|3077| 					this.SetDefaultAnimationVariant();
|3078|3078| 				var cmpResistance = Engine.QueryInterface(this.entity, IID_Resistance);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 2 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3298|3298| 		"COMBAT": "INDIVIDUAL.COMBAT", // reuse the same combat behaviour for animals
|3299|3299| 
|3300|3300| 		"WALKING": "INDIVIDUAL.WALKING",	// reuse the same walking behaviour for animals
|3301|    |-							// only used for domestic animals
|    |3301|+		// only used for domestic animals
|3302|3302| 
|3303|3303| 		// Reuse the same garrison behaviour for animals.
|3304|3304| 		"GARRISON": "INDIVIDUAL.GARRISON",
|    | [NORMAL] ESLintBear (no-unneeded-ternary):
|    | Unnecessary use of boolean literals in conditional expression.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3360|3360| 
|3361|3361| UnitAI.prototype.IsAnimal = function()
|3362|3362| {
|3363|    |-	return (this.template.NaturalBehaviour ? true : false);
|    |3363|+	return (!!this.template.NaturalBehaviour);
|3364|3364| };
|3365|3365| 
|3366|3366| UnitAI.prototype.IsDangerousAnimal = function()
|    | [NORMAL] ESLintBear (comma-spacing):
|    | A space is required after ','.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3476|3476| 		{
|3477|3477| 			let index = this.GetCurrentState().indexOf(".");
|3478|3478| 			if (index != -1)
|3479|    |-				this.UnitFsm.SwitchToNextState(this, this.GetCurrentState().slice(0,index));
|    |3479|+				this.UnitFsm.SwitchToNextState(this, this.GetCurrentState().slice(0, index));
|3480|3480| 			this.Stop(false);
|3481|3481| 		}
|3482|3482| 
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3532|3532| 		if (this.orderQueue[i].type != "PickupUnit" || this.orderQueue[i].data.target != msg.entity)
|3533|3533| 			continue;
|3534|3534| 		if (i == 0)
|3535|    |-			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg});
|    |3535|+			this.UnitFsm.ProcessMessage(this, { "type": "PickupCanceled", "data": msg});
|3536|3536| 		else
|3537|3537| 			this.orderQueue.splice(i, 1);
|3538|3538| 		Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3532|3532| 		if (this.orderQueue[i].type != "PickupUnit" || this.orderQueue[i].data.target != msg.entity)
|3533|3533| 			continue;
|3534|3534| 		if (i == 0)
|3535|    |-			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg});
|    |3535|+			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg });
|3536|3536| 		else
|3537|3537| 			this.orderQueue.splice(i, 1);
|3538|3538| 		Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3616|3616| };
|3617|3617| 
|3618|3618| 
|3619|    |-//// FSM linkage functions ////
|    |3619|+// // FSM linkage functions ////
|3620|3620| 
|3621|3621| // Setting the next state to the current state will leave/re-enter the top-most substate.
|3622|3622| UnitAI.prototype.SetNextState = function(state)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3787|3787| 				continue;
|3788|3788| 			if (this.orderQueue[i].type == type)
|3789|3789| 				continue;
|3790|    |-			this.orderQueue.splice(i, 0, {"type": type, "data": data});
|    |3790|+			this.orderQueue.splice(i, 0, { "type": type, "data": data});
|3791|3791| 			Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|3792|3792| 			return;
|3793|3793| 		}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3787|3787| 				continue;
|3788|3788| 			if (this.orderQueue[i].type == type)
|3789|3789| 				continue;
|3790|    |-			this.orderQueue.splice(i, 0, {"type": type, "data": data});
|    |3790|+			this.orderQueue.splice(i, 0, {"type": type, "data": data });
|3791|3791| 			Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|3792|3792| 			return;
|3793|3793| 		}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4029|4029| 	if (data.timerRepeat === undefined)
|4030|4030| 		this.timer = undefined;
|4031|4031| 
|4032|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness});
|    |4032|+	this.UnitFsm.ProcessMessage(this, { "type": "Timer", "data": data, "lateness": lateness});
|4033|4033| };
|4034|4034| 
|4035|4035| /**
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4029|4029| 	if (data.timerRepeat === undefined)
|4030|4030| 		this.timer = undefined;
|4031|4031| 
|4032|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness});
|    |4032|+	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness });
|4033|4033| };
|4034|4034| 
|4035|4035| /**
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4074|4074| 	// TODO: This is a bit inefficient since every unit listens to every
|4075|4075| 	// construction message - ideally we could scope it to only the one we're building
|4076|4076| 
|4077|    |-	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg});
|    |4077|+	this.UnitFsm.ProcessMessage(this, { "type": "ConstructionFinished", "data": msg});
|4078|4078| };
|4079|4079| 
|4080|4080| UnitAI.prototype.OnGlobalEntityRenamed = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4074|4074| 	// TODO: This is a bit inefficient since every unit listens to every
|4075|4075| 	// construction message - ideally we could scope it to only the one we're building
|4076|4076| 
|4077|    |-	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg});
|    |4077|+	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg });
|4078|4078| };
|4079|4079| 
|4080|4080| UnitAI.prototype.OnGlobalEntityRenamed = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4099|4099| 
|4100|4100| UnitAI.prototype.OnAttacked = function(msg)
|4101|4101| {
|4102|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg});
|    |4102|+	this.UnitFsm.ProcessMessage(this, { "type": "Attacked", "data": msg});
|4103|4103| };
|4104|4104| 
|4105|4105| UnitAI.prototype.OnGuardedAttacked = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4099|4099| 
|4100|4100| UnitAI.prototype.OnAttacked = function(msg)
|4101|4101| {
|4102|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg});
|    |4102|+	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg });
|4103|4103| };
|4104|4104| 
|4105|4105| UnitAI.prototype.OnGuardedAttacked = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4104|4104| 
|4105|4105| UnitAI.prototype.OnGuardedAttacked = function(msg)
|4106|4106| {
|4107|    |-	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data});
|    |4107|+	this.UnitFsm.ProcessMessage(this, { "type": "GuardedAttacked", "data": msg.data});
|4108|4108| };
|4109|4109| 
|4110|4110| UnitAI.prototype.OnHealthChanged = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4104|4104| 
|4105|4105| UnitAI.prototype.OnGuardedAttacked = function(msg)
|4106|4106| {
|4107|    |-	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data});
|    |4107|+	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data });
|4108|4108| };
|4109|4109| 
|4110|4110| UnitAI.prototype.OnHealthChanged = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4109|4109| 
|4110|4110| UnitAI.prototype.OnHealthChanged = function(msg)
|4111|4111| {
|4112|    |-	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to});
|    |4112|+	this.UnitFsm.ProcessMessage(this, { "type": "HealthChanged", "from": msg.from, "to": msg.to});
|4113|4113| };
|4114|4114| 
|4115|4115| UnitAI.prototype.OnRangeUpdate = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4109|4109| 
|4110|4110| UnitAI.prototype.OnHealthChanged = function(msg)
|4111|4111| {
|4112|    |-	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to});
|    |4112|+	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to });
|4113|4113| };
|4114|4114| 
|4115|4115| UnitAI.prototype.OnRangeUpdate = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4115|4115| UnitAI.prototype.OnRangeUpdate = function(msg)
|4116|4116| {
|4117|4117| 	if (msg.tag == this.losRangeQuery)
|4118|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|    |4118|+		this.UnitFsm.ProcessMessage(this, { "type": "LosRangeUpdate", "data": msg});
|4119|4119| 	else if (msg.tag == this.losHealRangeQuery)
|4120|4120| 		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|4121|4121| };
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4115|4115| UnitAI.prototype.OnRangeUpdate = function(msg)
|4116|4116| {
|4117|4117| 	if (msg.tag == this.losRangeQuery)
|4118|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|    |4118|+		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg });
|4119|4119| 	else if (msg.tag == this.losHealRangeQuery)
|4120|4120| 		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|4121|4121| };
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4117|4117| 	if (msg.tag == this.losRangeQuery)
|4118|4118| 		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|4119|4119| 	else if (msg.tag == this.losHealRangeQuery)
|4120|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|    |4120|+		this.UnitFsm.ProcessMessage(this, { "type": "LosHealRangeUpdate", "data": msg});
|4121|4121| };
|4122|4122| 
|4123|4123| UnitAI.prototype.OnPackFinished = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4117|4117| 	if (msg.tag == this.losRangeQuery)
|4118|4118| 		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|4119|4119| 	else if (msg.tag == this.losHealRangeQuery)
|4120|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|    |4120|+		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg });
|4121|4121| };
|4122|4122| 
|4123|4123| UnitAI.prototype.OnPackFinished = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4122|4122| 
|4123|4123| UnitAI.prototype.OnPackFinished = function(msg)
|4124|4124| {
|4125|    |-	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|    |4125|+	this.UnitFsm.ProcessMessage(this, { "type": "PackFinished", "packed": msg.packed});
|4126|4126| };
|4127|4127| 
|4128|4128| //// Helper functions to be called by the FSM ////
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4122|4122| 
|4123|4123| UnitAI.prototype.OnPackFinished = function(msg)
|4124|4124| {
|4125|    |-	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|    |4125|+	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed });
|4126|4126| };
|4127|4127| 
|4128|4128| //// Helper functions to be called by the FSM ////
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4125|4125| 	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|4126|4126| };
|4127|4127| 
|4128|    |-//// Helper functions to be called by the FSM ////
|    |4128|+// // Helper functions to be called by the FSM ////
|4129|4129| 
|4130|4130| UnitAI.prototype.GetWalkSpeed = function()
|4131|4131| {
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4790|4790| UnitAI.prototype.AttackEntityInZone = function(ents)
|4791|4791| {
|4792|4792| 	var target = ents.find(target =>
|4793|    |-		this.CanAttack(target)
|4794|    |-		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|    |4793|+		this.CanAttack(target) &&
|    |4794|+		this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|4795|4795| 		&& (this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|4796|4796| 	);
|4797|4797| 	if (!target)
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4791|4791| {
|4792|4792| 	var target = ents.find(target =>
|4793|4793| 		this.CanAttack(target)
|4794|    |-		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|4795|    |-		&& (this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|    |4794|+		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true)) &&
|    |4795|+		(this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|4796|4796| 	);
|4797|4797| 	if (!target)
|4798|4798| 		return false;
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before 'Engine'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4855|4855| 	// If we are guarding/escorting, don't abandon as long as the guarded unit is in target range of the attacker
|4856|4856| 	if (this.isGuardOf)
|4857|4857| 	{
|4858|    |-		var cmpUnitAI =  Engine.QueryInterface(target, IID_UnitAI);
|    |4858|+		var cmpUnitAI = Engine.QueryInterface(target, IID_UnitAI);
|4859|4859| 		var cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4860|4860| 		if (cmpUnitAI && cmpAttack &&
|4861|4861| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4859|4859| 		var cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4860|4860| 		if (cmpUnitAI && cmpAttack &&
|4861|4861| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|4862|    |-				return false;
|    |4862|+			return false;
|4863|4863| 	}
|4864|4864| 
|4865|4865| 	// Stop if we're in hold-ground mode and it's too far from the holding point
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before 'Engine'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4897|4897| 	// If we are guarding/escorting, chase at least as long as the guarded unit is in target range of the attacker
|4898|4898| 	if (this.isGuardOf)
|4899|4899| 	{
|4900|    |-		let cmpUnitAI =  Engine.QueryInterface(target, IID_UnitAI);
|    |4900|+		let cmpUnitAI = Engine.QueryInterface(target, IID_UnitAI);
|4901|4901| 		let cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4902|4902| 		if (cmpUnitAI && cmpAttack &&
|4903|4903| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4910|4910| 	return false;
|4911|4911| };
|4912|4912| 
|4913|    |-//// External interface functions ////
|    |4913|+// // External interface functions ////
|4914|4914| 
|4915|4915| UnitAI.prototype.SetFormationController = function(ent)
|4916|4916| {
|    | [NORMAL] ESLintBear (no-else-return):
|    | Unnecessary 'else' after 'return'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5066|5066| 	{
|5067|5067| 		if (this.isGuardOf == target && this.order && this.order.type == "Guard")
|5068|5068| 			return;
|5069|    |-		else
|5070|    |-			this.RemoveGuard();
|    |5069|+		this.RemoveGuard();
|5071|5070| 	}
|5072|5071| 
|5073|5072| 	this.AddOrder("Guard", { "target": target, "force": false }, queued);
|    | [NORMAL] ESLintBear (no-trailing-spaces):
|    | Trailing spaces not allowed.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5408|5408| 	    this.workOrders.length && this.workOrders[0].type == "Trade")
|5409|5409| 	{
|5410|5410| 		let cmpTrader = Engine.QueryInterface(this.entity, IID_Trader);
|5411|    |-		if (cmpTrader.HasBothMarkets() && 
|    |5411|+		if (cmpTrader.HasBothMarkets() &&
|5412|5412| 		   (cmpTrader.GetFirstMarket() == target && cmpTrader.GetSecondMarket() == source ||
|5413|5413| 		    cmpTrader.GetFirstMarket() == source && cmpTrader.GetSecondMarket() == target))
|5414|5414| 		{
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5689|5689| 				{
|5690|5690| 					var cmpIdentity = Engine.QueryInterface(targ, IID_Identity);
|5691|5691| 					var targetClasses = this.order.data.targetClasses;
|5692|    |-					if (targetClasses.attack && cmpIdentity
|5693|    |-						&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|    |5692|+					if (targetClasses.attack && cmpIdentity &&
|    |5693|+						!MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5694|5694| 						continue;
|5695|5695| 					if (targetClasses.avoid && cmpIdentity
|5696|5696| 						&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5692|5692| 					if (targetClasses.attack && cmpIdentity
|5693|5693| 						&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5694|5694| 						continue;
|5695|    |-					if (targetClasses.avoid && cmpIdentity
|5696|    |-						&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    |5695|+					if (targetClasses.avoid && cmpIdentity &&
|    |5696|+						MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|5697|5697| 						continue;
|5698|5698| 					// Only used by the AIs to prevent some choices of targets
|5699|5699| 					if (targetClasses.vetoEntities && targetClasses.vetoEntities[targ])
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5715|5715| 		{
|5716|5716| 			var cmpIdentity = Engine.QueryInterface(targ, IID_Identity);
|5717|5717| 			var targetClasses = this.order.data.targetClasses;
|5718|    |-			if (cmpIdentity && targetClasses.attack
|5719|    |-				&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|    |5718|+			if (cmpIdentity && targetClasses.attack &&
|    |5719|+				!MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5720|5720| 				continue;
|5721|5721| 			if (cmpIdentity && targetClasses.avoid
|5722|5722| 				&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5718|5718| 			if (cmpIdentity && targetClasses.attack
|5719|5719| 				&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5720|5720| 				continue;
|5721|    |-			if (cmpIdentity && targetClasses.avoid
|5722|    |-				&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    |5721|+			if (cmpIdentity && targetClasses.avoid &&
|    |5722|+				MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|5723|5723| 				continue;
|5724|5724| 			// Only used by the AIs to prevent some choices of targets
|5725|5725| 			if (targetClasses.vetoEntities && targetClasses.vetoEntities[targ])
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5875|5875| 
|5876|5876| UnitAI.prototype.SetHeldPosition = function(x, z)
|5877|5877| {
|5878|    |-	this.heldPosition = {"x": x, "z": z};
|    |5878|+	this.heldPosition = { "x": x, "z": z};
|5879|5879| };
|5880|5880| 
|5881|5881| UnitAI.prototype.SetHeldPositionOnEntity = function(entity)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5875|5875| 
|5876|5876| UnitAI.prototype.SetHeldPosition = function(x, z)
|5877|5877| {
|5878|    |-	this.heldPosition = {"x": x, "z": z};
|    |5878|+	this.heldPosition = {"x": x, "z": z };
|5879|5879| };
|5880|5880| 
|5881|5881| UnitAI.prototype.SetHeldPositionOnEntity = function(entity)
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5902|5902| 	return false;
|5903|5903| };
|5904|5904| 
|5905|    |-//// Helper functions ////
|    |5905|+// // Helper functions ////
|5906|5906| 
|5907|5907| UnitAI.prototype.CanAttack = function(target)
|5908|5908| {
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|6100|6100| 	return cmpPack && cmpPack.IsPacking();
|6101|6101| };
|6102|6102| 
|6103|    |-//// Formation specific functions ////
|    |6103|+// // Formation specific functions ////
|6104|6104| 
|6105|6105| UnitAI.prototype.IsAttackingAsFormation = function()
|6106|6106| {
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|6105|6105| UnitAI.prototype.IsAttackingAsFormation = function()
|6106|6106| {
|6107|6107| 	var cmpAttack = Engine.QueryInterface(this.entity, IID_Attack);
|6108|    |-	return cmpAttack && cmpAttack.CanAttackAsFormation()
|6109|    |-		&& this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|    |6108|+	return cmpAttack && cmpAttack.CanAttackAsFormation() &&
|    |6109|+		this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|6110|6110| };
|6111|6111| 
|6112|6112| //// Animal specific functions ////
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|6109|6109| 		&& this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|6110|6110| };
|6111|6111| 
|6112|    |-//// Animal specific functions ////
|    |6112|+// // Animal specific functions ////
|6113|6113| 
|6114|6114| UnitAI.prototype.MoveRandomly = function(distance)
|6115|6115| {

binaries/data/mods/public/simulation/components/UnitAI.js
| 338| »   »   »   return·true;
|    | [NORMAL] ESLintBear (consistent-return):
|    | Method 'Order.WalkToTarget' expected no return value.

binaries/data/mods/public/simulation/components/UnitAI.js
|1248| »   »   »   »   return·false;
|    | [NORMAL] ESLintBear (consistent-return):
|    | Method 'Timer' expected no return value.

binaries/data/mods/public/simulation/components/UnitAI.js
|3934| »   var·isWorkType·=·type·=>·type·==·"Gather"·||·type·==·"Trade"·||·type·==·"Repair"·||·type·==·"ReturnResource";
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'type' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4777| »   var·target·=·ents.find(target·=>·this.CanAttack(target));
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'target' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4792| »   var·target·=·ents.find(target·=>
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'target' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4838| »   var·ent·=·ents.find(ent·=>·this.CanHeal(ent));
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'ent' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4861| »   »   ····cmpAttack.GetAttackTypes().some(type·=>·cmpUnitAI.CheckTargetAttackRange(this.isGuardOf,·type)))
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'type' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|2042| »   »   »   »   »   »   &&·this.order.data.target·!=·msg.data.attacker·&&·this.GetBestAttackAgainst(msg.data.attacker,·true)·!=·"Capture")
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|3075| »   »   »   »   »   this.SetAnimationVariant(this.formationAnimationVariant)
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/UnitAI.js
|3881| »   »   var·order·=·{·"type":·type,·"data":·data·};
|    | [NORMAL] JSHintBear:
|    | 'order' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|3965| »   for·(var·i·=·0;·i·<·this.orderQueue.length;·++i)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|4794| »   »   &&·this.CheckTargetDistanceFromHeldPosition(target,·IID_Attack,·this.GetBestAttackAgainst(target,·true))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|4795| »   »   &&·(this.GetStance().respondChaseBeyondVision·||·this.CheckTargetIsInVisionRange(target))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5693| »   »   »   »   »   »   &&·!MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.attack))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5696| »   »   »   »   »   »   &&·MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.avoid))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5709| »   var·targets·=·this.GetTargetsFromUnit();
|    | [NORMAL] JSHintBear:
|    | 'targets' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5710| »   for·(var·targ·of·targets)
|    | [NORMAL] JSHintBear:
|    | 'targ' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5716| »   »   »   var·cmpIdentity·=·Engine.QueryInterface(targ,·IID_Identity);
|    | [NORMAL] JSHintBear:
|    | 'cmpIdentity' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5717| »   »   »   var·targetClasses·=·this.order.data.targetClasses;
|    | [NORMAL] JSHintBear:
|    | 'targetClasses' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5719| »   »   »   »   &&·!MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.attack))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5722| »   »   »   »   &&·MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.avoid))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5797| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5800| »   »   var·range·=·cmpVision.GetRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5805| »   »   var·cmpRanged·=·Engine.QueryInterface(this.entity,·iid);
|    | [NORMAL] JSHintBear:
|    | 'cmpRanged' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5808| »   »   var·range·=·iid·!==·IID_Attack·?·cmpRanged.GetRange()·:·cmpRanged.GetFullAttackRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5809| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5819| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5822| »   »   var·range·=·cmpVision.GetRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|6109| »   »   &&·this.GetCurrentState()·==·"FORMATIONCONTROLLER.COMBAT.ATTACKING";
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1549/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/127/display/redirect

Harbormaster completed remote builds in B10781: Diff 11007.Jan 13 2020, 9:08 PM

Revert template change.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1036/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/132/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (no-else-return):
|    | Unnecessary 'else' after 'return'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
| 788| 788| 					this.FinishOrder();
| 789| 789| 					return;
| 790| 790| 				}
| 791|    |-				else
| 792|    |-				{
|    | 791|+				
| 793| 792| 					this.SetNextState("GARRISON.APPROACHING");
| 794| 793| 					return;
| 795|    |-				}
|    | 794|+				
| 796| 795| 			}
| 797| 796| 
| 798| 797| 			this.SetNextState("GARRISON.GARRISONING");
|    | [NORMAL] ESLintBear (key-spacing):
|    | Missing space before value for key 'GARRISON'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|1060|1060| 			},
|1061|1061| 		},
|1062|1062| 
|1063|    |-		"GARRISON":{
|    |1063|+		"GARRISON": {
|1064|1064| 			"APPROACHING": {
|1065|1065| 				"enter": function() {
|1066|1066| 					if (!this.MoveToGarrisonRange(this.order.data.target))
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|2038|2038| 
|2039|2039| 				"Attacked": function(msg) {
|2040|2040| 					// If we are capturing and are attacked by something that we would not capture, attack that entity instead
|2041|    |-					if (this.order.data.attackType == "Capture" && (this.GetStance().targetAttackersAlways || !this.order.data.force)
|2042|    |-						&& this.order.data.target != msg.data.attacker && this.GetBestAttackAgainst(msg.data.attacker, true) != "Capture")
|    |2041|+					if (this.order.data.attackType == "Capture" && (this.GetStance().targetAttackersAlways || !this.order.data.force) &&
|    |2042|+						this.order.data.target != msg.data.attacker && this.GetBestAttackAgainst(msg.data.attacker, true) != "Capture")
|2043|2043| 						this.RespondToTargetedEntities([msg.data.attacker]);
|2044|2044| 				},
|2045|2045| 			},
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|2774|2774| 					{
|2775|2775| 						// The building was already finished/fully repaired before we arrived;
|2776|2776| 						// let the ConstructionFinished handler handle this.
|2777|    |-						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget});
|    |2777|+						this.OnGlobalConstructionFinished({ "entity": this.repairTarget, "newentity": this.repairTarget});
|2778|2778| 						return true;
|2779|2779| 					}
|2780|2780| 
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|2774|2774| 					{
|2775|2775| 						// The building was already finished/fully repaired before we arrived;
|2776|2776| 						// let the ConstructionFinished handler handle this.
|2777|    |-						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget});
|    |2777|+						this.OnGlobalConstructionFinished({"entity": this.repairTarget, "newentity": this.repairTarget });
|2778|2778| 						return true;
|2779|2779| 					}
|2780|2780| 
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3072|3072| 				this.StopTimer();
|3073|3073| 				this.ResetAnimation();
|3074|3074| 				if (this.formationAnimationVariant)
|3075|    |-					this.SetAnimationVariant(this.formationAnimationVariant)
|    |3075|+					this.SetAnimationVariant(this.formationAnimationVariant);
|3076|3076| 				else
|3077|3077| 					this.SetDefaultAnimationVariant();
|3078|3078| 				var cmpResistance = Engine.QueryInterface(this.entity, IID_Resistance);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 2 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3298|3298| 		"COMBAT": "INDIVIDUAL.COMBAT", // reuse the same combat behaviour for animals
|3299|3299| 
|3300|3300| 		"WALKING": "INDIVIDUAL.WALKING",	// reuse the same walking behaviour for animals
|3301|    |-							// only used for domestic animals
|    |3301|+		// only used for domestic animals
|3302|3302| 
|3303|3303| 		// Reuse the same garrison behaviour for animals.
|3304|3304| 		"GARRISON": "INDIVIDUAL.GARRISON",
|    | [NORMAL] ESLintBear (no-unneeded-ternary):
|    | Unnecessary use of boolean literals in conditional expression.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3360|3360| 
|3361|3361| UnitAI.prototype.IsAnimal = function()
|3362|3362| {
|3363|    |-	return (this.template.NaturalBehaviour ? true : false);
|    |3363|+	return (!!this.template.NaturalBehaviour);
|3364|3364| };
|3365|3365| 
|3366|3366| UnitAI.prototype.IsDangerousAnimal = function()
|    | [NORMAL] ESLintBear (comma-spacing):
|    | A space is required after ','.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3476|3476| 		{
|3477|3477| 			let index = this.GetCurrentState().indexOf(".");
|3478|3478| 			if (index != -1)
|3479|    |-				this.UnitFsm.SwitchToNextState(this, this.GetCurrentState().slice(0,index));
|    |3479|+				this.UnitFsm.SwitchToNextState(this, this.GetCurrentState().slice(0, index));
|3480|3480| 			this.Stop(false);
|3481|3481| 		}
|3482|3482| 
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3532|3532| 		if (this.orderQueue[i].type != "PickupUnit" || this.orderQueue[i].data.target != msg.entity)
|3533|3533| 			continue;
|3534|3534| 		if (i == 0)
|3535|    |-			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg});
|    |3535|+			this.UnitFsm.ProcessMessage(this, { "type": "PickupCanceled", "data": msg});
|3536|3536| 		else
|3537|3537| 			this.orderQueue.splice(i, 1);
|3538|3538| 		Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3532|3532| 		if (this.orderQueue[i].type != "PickupUnit" || this.orderQueue[i].data.target != msg.entity)
|3533|3533| 			continue;
|3534|3534| 		if (i == 0)
|3535|    |-			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg});
|    |3535|+			this.UnitFsm.ProcessMessage(this, {"type": "PickupCanceled", "data": msg });
|3536|3536| 		else
|3537|3537| 			this.orderQueue.splice(i, 1);
|3538|3538| 		Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3616|3616| };
|3617|3617| 
|3618|3618| 
|3619|    |-//// FSM linkage functions ////
|    |3619|+// // FSM linkage functions ////
|3620|3620| 
|3621|3621| // Setting the next state to the current state will leave/re-enter the top-most substate.
|3622|3622| UnitAI.prototype.SetNextState = function(state)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3787|3787| 				continue;
|3788|3788| 			if (this.orderQueue[i].type == type)
|3789|3789| 				continue;
|3790|    |-			this.orderQueue.splice(i, 0, {"type": type, "data": data});
|    |3790|+			this.orderQueue.splice(i, 0, { "type": type, "data": data});
|3791|3791| 			Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|3792|3792| 			return;
|3793|3793| 		}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|3787|3787| 				continue;
|3788|3788| 			if (this.orderQueue[i].type == type)
|3789|3789| 				continue;
|3790|    |-			this.orderQueue.splice(i, 0, {"type": type, "data": data});
|    |3790|+			this.orderQueue.splice(i, 0, {"type": type, "data": data });
|3791|3791| 			Engine.PostMessage(this.entity, MT_UnitAIOrderDataChanged, { "to": this.GetOrderData() });
|3792|3792| 			return;
|3793|3793| 		}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4029|4029| 	if (data.timerRepeat === undefined)
|4030|4030| 		this.timer = undefined;
|4031|4031| 
|4032|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness});
|    |4032|+	this.UnitFsm.ProcessMessage(this, { "type": "Timer", "data": data, "lateness": lateness});
|4033|4033| };
|4034|4034| 
|4035|4035| /**
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4029|4029| 	if (data.timerRepeat === undefined)
|4030|4030| 		this.timer = undefined;
|4031|4031| 
|4032|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness});
|    |4032|+	this.UnitFsm.ProcessMessage(this, {"type": "Timer", "data": data, "lateness": lateness });
|4033|4033| };
|4034|4034| 
|4035|4035| /**
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4074|4074| 	// TODO: This is a bit inefficient since every unit listens to every
|4075|4075| 	// construction message - ideally we could scope it to only the one we're building
|4076|4076| 
|4077|    |-	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg});
|    |4077|+	this.UnitFsm.ProcessMessage(this, { "type": "ConstructionFinished", "data": msg});
|4078|4078| };
|4079|4079| 
|4080|4080| UnitAI.prototype.OnGlobalEntityRenamed = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4074|4074| 	// TODO: This is a bit inefficient since every unit listens to every
|4075|4075| 	// construction message - ideally we could scope it to only the one we're building
|4076|4076| 
|4077|    |-	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg});
|    |4077|+	this.UnitFsm.ProcessMessage(this, {"type": "ConstructionFinished", "data": msg });
|4078|4078| };
|4079|4079| 
|4080|4080| UnitAI.prototype.OnGlobalEntityRenamed = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4099|4099| 
|4100|4100| UnitAI.prototype.OnAttacked = function(msg)
|4101|4101| {
|4102|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg});
|    |4102|+	this.UnitFsm.ProcessMessage(this, { "type": "Attacked", "data": msg});
|4103|4103| };
|4104|4104| 
|4105|4105| UnitAI.prototype.OnGuardedAttacked = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4099|4099| 
|4100|4100| UnitAI.prototype.OnAttacked = function(msg)
|4101|4101| {
|4102|    |-	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg});
|    |4102|+	this.UnitFsm.ProcessMessage(this, {"type": "Attacked", "data": msg });
|4103|4103| };
|4104|4104| 
|4105|4105| UnitAI.prototype.OnGuardedAttacked = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4104|4104| 
|4105|4105| UnitAI.prototype.OnGuardedAttacked = function(msg)
|4106|4106| {
|4107|    |-	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data});
|    |4107|+	this.UnitFsm.ProcessMessage(this, { "type": "GuardedAttacked", "data": msg.data});
|4108|4108| };
|4109|4109| 
|4110|4110| UnitAI.prototype.OnHealthChanged = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4104|4104| 
|4105|4105| UnitAI.prototype.OnGuardedAttacked = function(msg)
|4106|4106| {
|4107|    |-	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data});
|    |4107|+	this.UnitFsm.ProcessMessage(this, {"type": "GuardedAttacked", "data": msg.data });
|4108|4108| };
|4109|4109| 
|4110|4110| UnitAI.prototype.OnHealthChanged = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4109|4109| 
|4110|4110| UnitAI.prototype.OnHealthChanged = function(msg)
|4111|4111| {
|4112|    |-	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to});
|    |4112|+	this.UnitFsm.ProcessMessage(this, { "type": "HealthChanged", "from": msg.from, "to": msg.to});
|4113|4113| };
|4114|4114| 
|4115|4115| UnitAI.prototype.OnRangeUpdate = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4109|4109| 
|4110|4110| UnitAI.prototype.OnHealthChanged = function(msg)
|4111|4111| {
|4112|    |-	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to});
|    |4112|+	this.UnitFsm.ProcessMessage(this, {"type": "HealthChanged", "from": msg.from, "to": msg.to });
|4113|4113| };
|4114|4114| 
|4115|4115| UnitAI.prototype.OnRangeUpdate = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4115|4115| UnitAI.prototype.OnRangeUpdate = function(msg)
|4116|4116| {
|4117|4117| 	if (msg.tag == this.losRangeQuery)
|4118|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|    |4118|+		this.UnitFsm.ProcessMessage(this, { "type": "LosRangeUpdate", "data": msg});
|4119|4119| 	else if (msg.tag == this.losHealRangeQuery)
|4120|4120| 		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|4121|4121| };
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4115|4115| UnitAI.prototype.OnRangeUpdate = function(msg)
|4116|4116| {
|4117|4117| 	if (msg.tag == this.losRangeQuery)
|4118|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|    |4118|+		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg });
|4119|4119| 	else if (msg.tag == this.losHealRangeQuery)
|4120|4120| 		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|4121|4121| };
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4117|4117| 	if (msg.tag == this.losRangeQuery)
|4118|4118| 		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|4119|4119| 	else if (msg.tag == this.losHealRangeQuery)
|4120|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|    |4120|+		this.UnitFsm.ProcessMessage(this, { "type": "LosHealRangeUpdate", "data": msg});
|4121|4121| };
|4122|4122| 
|4123|4123| UnitAI.prototype.OnPackFinished = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4117|4117| 	if (msg.tag == this.losRangeQuery)
|4118|4118| 		this.UnitFsm.ProcessMessage(this, {"type": "LosRangeUpdate", "data": msg});
|4119|4119| 	else if (msg.tag == this.losHealRangeQuery)
|4120|    |-		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg});
|    |4120|+		this.UnitFsm.ProcessMessage(this, {"type": "LosHealRangeUpdate", "data": msg });
|4121|4121| };
|4122|4122| 
|4123|4123| UnitAI.prototype.OnPackFinished = function(msg)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4122|4122| 
|4123|4123| UnitAI.prototype.OnPackFinished = function(msg)
|4124|4124| {
|4125|    |-	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|    |4125|+	this.UnitFsm.ProcessMessage(this, { "type": "PackFinished", "packed": msg.packed});
|4126|4126| };
|4127|4127| 
|4128|4128| //// Helper functions to be called by the FSM ////
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4122|4122| 
|4123|4123| UnitAI.prototype.OnPackFinished = function(msg)
|4124|4124| {
|4125|    |-	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|    |4125|+	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed });
|4126|4126| };
|4127|4127| 
|4128|4128| //// Helper functions to be called by the FSM ////
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4125|4125| 	this.UnitFsm.ProcessMessage(this, {"type": "PackFinished", "packed": msg.packed});
|4126|4126| };
|4127|4127| 
|4128|    |-//// Helper functions to be called by the FSM ////
|    |4128|+// // Helper functions to be called by the FSM ////
|4129|4129| 
|4130|4130| UnitAI.prototype.GetWalkSpeed = function()
|4131|4131| {
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4790|4790| UnitAI.prototype.AttackEntityInZone = function(ents)
|4791|4791| {
|4792|4792| 	var target = ents.find(target =>
|4793|    |-		this.CanAttack(target)
|4794|    |-		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|    |4793|+		this.CanAttack(target) &&
|    |4794|+		this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|4795|4795| 		&& (this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|4796|4796| 	);
|4797|4797| 	if (!target)
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4791|4791| {
|4792|4792| 	var target = ents.find(target =>
|4793|4793| 		this.CanAttack(target)
|4794|    |-		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true))
|4795|    |-		&& (this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|    |4794|+		&& this.CheckTargetDistanceFromHeldPosition(target, IID_Attack, this.GetBestAttackAgainst(target, true)) &&
|    |4795|+		(this.GetStance().respondChaseBeyondVision || this.CheckTargetIsInVisionRange(target))
|4796|4796| 	);
|4797|4797| 	if (!target)
|4798|4798| 		return false;
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before 'Engine'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4855|4855| 	// If we are guarding/escorting, don't abandon as long as the guarded unit is in target range of the attacker
|4856|4856| 	if (this.isGuardOf)
|4857|4857| 	{
|4858|    |-		var cmpUnitAI =  Engine.QueryInterface(target, IID_UnitAI);
|    |4858|+		var cmpUnitAI = Engine.QueryInterface(target, IID_UnitAI);
|4859|4859| 		var cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4860|4860| 		if (cmpUnitAI && cmpAttack &&
|4861|4861| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4859|4859| 		var cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4860|4860| 		if (cmpUnitAI && cmpAttack &&
|4861|4861| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|4862|    |-				return false;
|    |4862|+			return false;
|4863|4863| 	}
|4864|4864| 
|4865|4865| 	// Stop if we're in hold-ground mode and it's too far from the holding point
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before 'Engine'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4897|4897| 	// If we are guarding/escorting, chase at least as long as the guarded unit is in target range of the attacker
|4898|4898| 	if (this.isGuardOf)
|4899|4899| 	{
|4900|    |-		let cmpUnitAI =  Engine.QueryInterface(target, IID_UnitAI);
|    |4900|+		let cmpUnitAI = Engine.QueryInterface(target, IID_UnitAI);
|4901|4901| 		let cmpAttack = Engine.QueryInterface(target, IID_Attack);
|4902|4902| 		if (cmpUnitAI && cmpAttack &&
|4903|4903| 		    cmpAttack.GetAttackTypes().some(type => cmpUnitAI.CheckTargetAttackRange(this.isGuardOf, type)))
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|4910|4910| 	return false;
|4911|4911| };
|4912|4912| 
|4913|    |-//// External interface functions ////
|    |4913|+// // External interface functions ////
|4914|4914| 
|4915|4915| UnitAI.prototype.SetFormationController = function(ent)
|4916|4916| {
|    | [NORMAL] ESLintBear (no-else-return):
|    | Unnecessary 'else' after 'return'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5066|5066| 	{
|5067|5067| 		if (this.isGuardOf == target && this.order && this.order.type == "Guard")
|5068|5068| 			return;
|5069|    |-		else
|5070|    |-			this.RemoveGuard();
|    |5069|+		this.RemoveGuard();
|5071|5070| 	}
|5072|5071| 
|5073|5072| 	this.AddOrder("Guard", { "target": target, "force": false }, queued);
|    | [NORMAL] ESLintBear (no-trailing-spaces):
|    | Trailing spaces not allowed.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5408|5408| 	    this.workOrders.length && this.workOrders[0].type == "Trade")
|5409|5409| 	{
|5410|5410| 		let cmpTrader = Engine.QueryInterface(this.entity, IID_Trader);
|5411|    |-		if (cmpTrader.HasBothMarkets() && 
|    |5411|+		if (cmpTrader.HasBothMarkets() &&
|5412|5412| 		   (cmpTrader.GetFirstMarket() == target && cmpTrader.GetSecondMarket() == source ||
|5413|5413| 		    cmpTrader.GetFirstMarket() == source && cmpTrader.GetSecondMarket() == target))
|5414|5414| 		{
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5689|5689| 				{
|5690|5690| 					var cmpIdentity = Engine.QueryInterface(targ, IID_Identity);
|5691|5691| 					var targetClasses = this.order.data.targetClasses;
|5692|    |-					if (targetClasses.attack && cmpIdentity
|5693|    |-						&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|    |5692|+					if (targetClasses.attack && cmpIdentity &&
|    |5693|+						!MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5694|5694| 						continue;
|5695|5695| 					if (targetClasses.avoid && cmpIdentity
|5696|5696| 						&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5692|5692| 					if (targetClasses.attack && cmpIdentity
|5693|5693| 						&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5694|5694| 						continue;
|5695|    |-					if (targetClasses.avoid && cmpIdentity
|5696|    |-						&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    |5695|+					if (targetClasses.avoid && cmpIdentity &&
|    |5696|+						MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|5697|5697| 						continue;
|5698|5698| 					// Only used by the AIs to prevent some choices of targets
|5699|5699| 					if (targetClasses.vetoEntities && targetClasses.vetoEntities[targ])
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5715|5715| 		{
|5716|5716| 			var cmpIdentity = Engine.QueryInterface(targ, IID_Identity);
|5717|5717| 			var targetClasses = this.order.data.targetClasses;
|5718|    |-			if (cmpIdentity && targetClasses.attack
|5719|    |-				&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|    |5718|+			if (cmpIdentity && targetClasses.attack &&
|    |5719|+				!MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5720|5720| 				continue;
|5721|5721| 			if (cmpIdentity && targetClasses.avoid
|5722|5722| 				&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5718|5718| 			if (cmpIdentity && targetClasses.attack
|5719|5719| 				&& !MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.attack))
|5720|5720| 				continue;
|5721|    |-			if (cmpIdentity && targetClasses.avoid
|5722|    |-				&& MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|    |5721|+			if (cmpIdentity && targetClasses.avoid &&
|    |5722|+				MatchesClassList(cmpIdentity.GetClassesList(), targetClasses.avoid))
|5723|5723| 				continue;
|5724|5724| 			// Only used by the AIs to prevent some choices of targets
|5725|5725| 			if (targetClasses.vetoEntities && targetClasses.vetoEntities[targ])
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5875|5875| 
|5876|5876| UnitAI.prototype.SetHeldPosition = function(x, z)
|5877|5877| {
|5878|    |-	this.heldPosition = {"x": x, "z": z};
|    |5878|+	this.heldPosition = { "x": x, "z": z};
|5879|5879| };
|5880|5880| 
|5881|5881| UnitAI.prototype.SetHeldPositionOnEntity = function(entity)
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5875|5875| 
|5876|5876| UnitAI.prototype.SetHeldPosition = function(x, z)
|5877|5877| {
|5878|    |-	this.heldPosition = {"x": x, "z": z};
|    |5878|+	this.heldPosition = {"x": x, "z": z };
|5879|5879| };
|5880|5880| 
|5881|5881| UnitAI.prototype.SetHeldPositionOnEntity = function(entity)
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|5902|5902| 	return false;
|5903|5903| };
|5904|5904| 
|5905|    |-//// Helper functions ////
|    |5905|+// // Helper functions ////
|5906|5906| 
|5907|5907| UnitAI.prototype.CanAttack = function(target)
|5908|5908| {
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|6100|6100| 	return cmpPack && cmpPack.IsPacking();
|6101|6101| };
|6102|6102| 
|6103|    |-//// Formation specific functions ////
|    |6103|+// // Formation specific functions ////
|6104|6104| 
|6105|6105| UnitAI.prototype.IsAttackingAsFormation = function()
|6106|6106| {
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|6105|6105| UnitAI.prototype.IsAttackingAsFormation = function()
|6106|6106| {
|6107|6107| 	var cmpAttack = Engine.QueryInterface(this.entity, IID_Attack);
|6108|    |-	return cmpAttack && cmpAttack.CanAttackAsFormation()
|6109|    |-		&& this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|    |6108|+	return cmpAttack && cmpAttack.CanAttackAsFormation() &&
|    |6109|+		this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|6110|6110| };
|6111|6111| 
|6112|6112| //// Animal specific functions ////
|    | [NORMAL] ESLintBear (spaced-comment):
|    | Expected space or tab after '//' in comment.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
|6109|6109| 		&& this.GetCurrentState() == "FORMATIONCONTROLLER.COMBAT.ATTACKING";
|6110|6110| };
|6111|6111| 
|6112|    |-//// Animal specific functions ////
|    |6112|+// // Animal specific functions ////
|6113|6113| 
|6114|6114| UnitAI.prototype.MoveRandomly = function(distance)
|6115|6115| {

binaries/data/mods/public/simulation/components/UnitAI.js
| 338| »   »   »   return·true;
|    | [NORMAL] ESLintBear (consistent-return):
|    | Method 'Order.WalkToTarget' expected no return value.

binaries/data/mods/public/simulation/components/UnitAI.js
|1248| »   »   »   »   return·false;
|    | [NORMAL] ESLintBear (consistent-return):
|    | Method 'Timer' expected no return value.

binaries/data/mods/public/simulation/components/UnitAI.js
|3934| »   var·isWorkType·=·type·=>·type·==·"Gather"·||·type·==·"Trade"·||·type·==·"Repair"·||·type·==·"ReturnResource";
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'type' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4777| »   var·target·=·ents.find(target·=>·this.CanAttack(target));
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'target' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4792| »   var·target·=·ents.find(target·=>
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'target' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4838| »   var·ent·=·ents.find(ent·=>·this.CanHeal(ent));
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'ent' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|4861| »   »   ····cmpAttack.GetAttackTypes().some(type·=>·cmpUnitAI.CheckTargetAttackRange(this.isGuardOf,·type)))
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'type' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/UnitAI.js
|2042| »   »   »   »   »   »   &&·this.order.data.target·!=·msg.data.attacker·&&·this.GetBestAttackAgainst(msg.data.attacker,·true)·!=·"Capture")
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|3075| »   »   »   »   »   this.SetAnimationVariant(this.formationAnimationVariant)
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/UnitAI.js
|3881| »   »   var·order·=·{·"type":·type,·"data":·data·};
|    | [NORMAL] JSHintBear:
|    | 'order' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|3965| »   for·(var·i·=·0;·i·<·this.orderQueue.length;·++i)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|4794| »   »   &&·this.CheckTargetDistanceFromHeldPosition(target,·IID_Attack,·this.GetBestAttackAgainst(target,·true))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|4795| »   »   &&·(this.GetStance().respondChaseBeyondVision·||·this.CheckTargetIsInVisionRange(target))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5693| »   »   »   »   »   »   &&·!MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.attack))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5696| »   »   »   »   »   »   &&·MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.avoid))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5709| »   var·targets·=·this.GetTargetsFromUnit();
|    | [NORMAL] JSHintBear:
|    | 'targets' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5710| »   for·(var·targ·of·targets)
|    | [NORMAL] JSHintBear:
|    | 'targ' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5716| »   »   »   var·cmpIdentity·=·Engine.QueryInterface(targ,·IID_Identity);
|    | [NORMAL] JSHintBear:
|    | 'cmpIdentity' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5717| »   »   »   var·targetClasses·=·this.order.data.targetClasses;
|    | [NORMAL] JSHintBear:
|    | 'targetClasses' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5719| »   »   »   »   &&·!MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.attack))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5722| »   »   »   »   &&·MatchesClassList(cmpIdentity.GetClassesList(),·targetClasses.avoid))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/UnitAI.js
|5797| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5800| »   »   var·range·=·cmpVision.GetRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5805| »   »   var·cmpRanged·=·Engine.QueryInterface(this.entity,·iid);
|    | [NORMAL] JSHintBear:
|    | 'cmpRanged' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5808| »   »   var·range·=·iid·!==·IID_Attack·?·cmpRanged.GetRange()·:·cmpRanged.GetFullAttackRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5809| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5819| »   »   var·cmpVision·=·Engine.QueryInterface(this.entity,·IID_Vision);
|    | [NORMAL] JSHintBear:
|    | 'cmpVision' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|5822| »   »   var·range·=·cmpVision.GetRange();
|    | [NORMAL] JSHintBear:
|    | 'range' is already defined.

binaries/data/mods/public/simulation/components/UnitAI.js
|6109| »   »   &&·this.GetCurrentState()·==·"FORMATIONCONTROLLER.COMBAT.ATTACKING";
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1554/display/redirect

Harbormaster completed remote builds in B10791: Diff 11013.Jan 14 2020, 6:59 PM

Code changes are good and code works as expected.
Animal does not enter INDIVIDUAL state from GARRISON state.

Implementing decision to let animals garrison taken on irc http://irclogs.wildfiregames.com/2013-12/2013-12-03-QuakeNet-%230ad-dev.log relevant for ticket #1907. As it is not clear if whole idea is going to be implemented, this is good as it is.
Aside from ticket, this allows usage for mods with low change cost.

This revision is now accepted and ready to land.Jan 14 2020, 7:14 PM

Closed by commit rP23409: Allow to garrison animals. (authored by Silier). · Explain WhyJan 17 2020, 10:40 AM

This revision was automatically updated to reflect the committed changes.

Silier added a commit: rP23409: Allow to garrison animals..

Thanks @Angen for the review and commit :)

Let animals be able to garrison.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 9115

binaries/data/mods/public/simulation/components/UnitAI.js

Let animals be able to garrison.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9115

binaries/data/mods/public/simulation/components/UnitAI.js

Let animals be able to garrison.
ClosedPublic
Actions

Revision Contents
Changeset List