rP8063 added exception printing for JS errors. rP8975 added the violation TODO. D1510 proposes to update the code.
Since the code violates the specs, since it does an Evluate when no Evaluate is necessary, since there were library changes necessary with SM45 to keep something alive that should be removed, sine the JS exception must be disabled and enabled / restored, one could also not make this circus and just print the stack as is, without 1 tab indentation at each line begin.
Details
Details
Make sure that the code doesn't miss an important feature. That it shows up as nice as before.
Previous to the patch:
ERROR: JavaScript error: gui/gamesetup/gamesetup.js line 1123 Error: deepfreeze requires exactly one object as an argument. init@gui/gamesetup/gamesetup.js:1123:2 __eventhandler9 (press)@__internal(5) press:0:1 ERROR: GUI page 'page_gamesetup.xml': Failed to call init() function
After the patch (different text, but you get the idea):
initCheckbox@gui/gamesetup/gamesetup.js:1382:2 initSettingObjects@gui/gamesetup/gamesetup.js:1330:4 initGUIObjects@gui/gamesetup/gamesetup.js:1199:2 onTick@gui/gamesetup/gamesetup.js:1999:3 __eventhandler42 (tick)@setupWindow tick:0:1
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 8758 Build 14355: Vulcan Build Jenkins Build 14354: arc lint + arc unit
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/322/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/323/display/redirect
Comment Actions
This looks fine to me, works with SM38 and without any change with SM45, and so much hacky code is removed that I can only be happy ? The autorequest looks needed to me.