This optimised and cleans up code by using a template and a custom-ordered set.
This also indirectly optimises MakeGoalReachable.
Changes hashes, sadly.
(Last of the D53 series of patches)
Differential D1882
Optimise MakeGoalReachable and FindNearestNavcellInRegions (D53 outtake) wraitii on May 13 2019, 7:14 PM. Authored by Tags None Subscribers None
Details
This optimised and cleans up code by using a template and a custom-ordered set. This also indirectly optimises MakeGoalReachable. Changes hashes, sadly. (Last of the D53 series of patches) Review the logic change, play a game or two.
Diff Detail
Event TimelineComment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/differential/1390/display/redirect Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/docker-differential/472/display/redirect Comment Actions This is hilariously broken... Need to have a "InGoal" variant, but I need to find a way to not duplicate this all too much. Comment Actions So yeah, I could actually clean this up better and in a working manner. Thanks to the tests I've added to notice this for me. Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/docker-differential/477/display/redirect Comment Actions Had accidentally uploaded the patch to fix the previous broken diff. Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/26/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... source/simulation2/components/tests/test_HierPathfinder.h | 25| class·TestHierarchicalPathfinder·:·public·CxxTest::TestSuite | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classTestHierarchicalPathfinder:' is invalid C code. Use --std or --language to configure the language. source/simulation2/helpers/HierarchicalPathfinder.h | 34| ·*·is·defined·as·a·region. | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'template<...' is invalid C code. Use --std or --language to configure the language. Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/docker-differential/535/display/redirect Comment Actions Add some words on the why.
Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/28/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... source/simulation2/components/tests/test_HierPathfinder.h | 25| class·TestHierarchicalPathfinder·:·public·CxxTest::TestSuite | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classTestHierarchicalPathfinder:' is invalid C code. Use --std or --language to configure the language. source/simulation2/helpers/HierarchicalPathfinder.h | 34| ·*·is·defined·as·a·region. | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'template<...' is invalid C code. Use --std or --language to configure the language. Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/docker-differential/537/display/redirect |