#802 -> #812

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Fix styling issues, and read the data in the json file to know what to disable enable depending on what's on.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

MaxForce and MomentOfInertia won't be used.

Moved out of CCmpDecay.
(Means discarding the decay part for now, but should be added back in the future.)

Just for the record, only debian seems to provide a man command.

This person also runs out of memory #5645 without the fix, maybe it's the same reason.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

style

I think this is okay. While a build-time copy isn't perfect, having a binaries' help text rely on an external file seems equivalently undesirable. A help text should always work in my opinion.

The minimap looks correct atm, the entire game looks like it only needs some polish before it looks identical to the GL version, on Intel. :)

Thanks you so much for taking a look at this! Strong GL ES support has been on my wishlist for a long time. If the minimap still doesn't support GL ES (it didn't last I looked), I have a patch from years that could be salvaged rather than starting from scratch.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

style changes

I'll move the simple physics outside of CmpDecay.

Some more comments before i forget.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

style changes

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

moved to subdirectory
moving revert ahead of deletions so ugly spamming like in https://jenkins.wildfiregames.com/blue/organizations/jenkins/vs2015-differential/detail/vs2015-differential/604/pipeline will not happen

what i said above

I did not test it yet nor looked into replace order function.
I ll do later (just dont want to loose my notes)

MoveToGarrisonRange should not contain pickup logic.
It is expected from function to move unit to target range and return true/false.

Thanks for the fix. Note that it doesn't following the naming conventions though. As horse shouldn't be in the name if it's in a folder called "horse". That should be fixed sometime.

In rP23195#39836, @Alexandermb wrote:

In rP23195#39832, @minohaka wrote:

Was playing and got these errors:
ERROR: Mismatch between model's skeleton and animation's skeleton (46 model bones != 49 animation keys)
ERROR: CCacheLoader failed to find archived or source file for: "art/variants/quadraped/base_horse_trader.xml"
ERROR: Could not open path quadraped/base_horse_trader.xml
ERROR: CCacheLoader failed to find archived or source file for: "art/actors/props/units/helmets/hele_thracian_cart_hero_01.xml"
ERROR: CObjectManager::FindObjectBase(): Cannot find object 'props/units/helmets/hele_thracian_cart_hero_01.xml'
ERROR: Failed to build prop model "props/units/helmets/hele_thracian_cart_hero_01.xml" on actor "hero_elephantry_hannibal_d"

Fixed most of them but i can't recognize the mismatch model. Do you know where the model mismatch happens?

Successful build - Chance fights ever on the side of the prudent.

Build failure - The Moirai have given mortals hearts that can endure.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Remove the extra bugfix that was split into D2174.

It works nice, but there is problem aside small styling.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Update to trunk. Slightly refactor (not a functional difference from the patch before).

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

In D665#76161, @Imarok wrote:

One easy fix would be that the ship won't move if the units can be garrissoned with the ship not moving.

That's what the patch already does.

In D665#76122, @elexis wrote:

If I understood the patch correctly, the behavior of the patch is that the ship moves to the closest shoreline, which may be on an entirely different island, at least.

Updated to trunk. Took out the std::unordered_set change, because other code in HierarchicalPathfinder.cpp now depends on the set being ordered.

After required D1630 and D1633 are added this is good to go ;)

Missing newline at the end of the file.
Otherwise I'm to tired to review this right now. Let's call it a day ;)

See IRC for improvements: http://irclogs.wildfiregames.com/2019-11/2019-11-30-QuakeNet-%230ad-dev.log starting with "12:30 < FeXoR> ...so on to D1630 I guess ^^"

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

In D2353#102192, @OptimusShepard wrote:

I currently have no time to write the patch, sorry. If someone else writes this patch I would test it.
Here are the required information which Imarok got from the AMD forum.

https://community.amd.com/thread/244207

I currently have no time to write the patch, sorry. If someone else writes this patch I would test it.
Here are the required information which Imarok got from the AMD forum.

Mostly good, please try to make the JSdoc phrases and comments more telling and check that last "type" check.

Fixes (again)

Seems I forgot add the possibility to customize the base height (was always 0 if ELEVATION_SET)

prototype -> class

Some coding convention notes to keep you waiting for FeXoR.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Fix verb

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.

Successful build - Chance fights ever on the side of the prudent.