Page MenuHomeWildfire Games
Feed All Stories

Mar 29 2020

Silier added a comment to D2667: Upgrade engine to handle up to 30 players.

m_data = (m_data & ~(0x3 << 2 * i)) | (static_cast<u64>(v & 0x3) << 2 * i); -> m_data = (m_data & ~(static_cast<u64>(0x3) << 2 * i)) | (static_cast<u64>(v & 0x3) << 2 * i);
else 0x3 is 32bit integer

Mar 29 2020, 9:43 PM
Vulcan added a comment to D2613: Updated cppformat.

Build failure - The Moirai have given mortals hearts that can endure.

Mar 29 2020, 5:40 PM
Vulcan added a comment to D2613: Updated cppformat.

Build failure - The Moirai have given mortals hearts that can endure.

Mar 29 2020, 5:34 PM
Harbormaster failed remote builds in B11380: Diff 11607 for D2613: Updated cppformat!
Mar 29 2020, 5:34 PM
s0600204 updated the diff for D2613: Updated cppformat.

Re-rebase adrian's patch

Mar 29 2020, 5:33 PM
Stan added a comment to D2667: Upgrade engine to handle up to 30 players.

I guess you can also update _default.xml map to use 9 players.

Mar 29 2020, 5:26 PM
nani updated the diff for D2667: Upgrade engine to handle up to 30 players.
Mar 29 2020, 5:16 PM
Vulcan added a comment to D2688: [art/actors] move a few unit actors and icons.

Successful build - Chance fights ever on the side of the prudent.

Mar 29 2020, 5:15 PM
Harbormaster failed remote builds in B11378: Diff 11605 for D2688: [art/actors] move a few unit actors and icons!
Mar 29 2020, 5:08 PM
Vulcan added a comment to D2688: [art/actors] move a few unit actors and icons.

Build failure - The Moirai have given mortals hearts that can endure.

Mar 29 2020, 5:08 PM
Nescio created D2688: [art/actors] move a few unit actors and icons.
Mar 29 2020, 5:07 PM
nani added a comment to D2667: Upgrade engine to handle up to 30 players.
In D2667#112888, @Angen wrote:

Aside from this I got idea how this could be unlimited number of players.
You would need to store inside PlayerData an array of m_data and work with the value based on index you get.
Lets say you store m_data as u32. So if you get index 0 - 16 you get first item from array. If you get index from 17 - 32 you get second item from array and subtract 16 from index.

Mar 29 2020, 5:04 PM
nani added inline comments to D2667: Upgrade engine to handle up to 30 players.
Mar 29 2020, 5:00 PM
Vulcan added a comment to D2511: [gameplay] give worker elephants an aura instead.

Successful build - Chance fights ever on the side of the prudent.

Mar 29 2020, 4:39 PM
Nescio added a comment to D2511: [gameplay] give worker elephants an aura instead.

Might be worth checking if there are any tips referencing that as well.

Not in any gui/text/tips/* file.

Mar 29 2020, 4:34 PM
Harbormaster failed remote builds in B11376: Diff 11603 for D2511: [gameplay] give worker elephants an aura instead!
Mar 29 2020, 4:33 PM
Vulcan added a comment to D2511: [gameplay] give worker elephants an aura instead.

Build failure - The Moirai have given mortals hearts that can endure.

Mar 29 2020, 4:33 PM
Nescio updated the diff for D2511: [gameplay] give worker elephants an aura instead.

Update worker elephant tooltip (cf. D2578).

Mar 29 2020, 4:32 PM
Stan added a comment to D2511: [gameplay] give worker elephants an aura instead.

Might be worth checking if there are any tips referencing that as well.

Mar 29 2020, 4:30 PM
Nescio added inline comments to D2511: [gameplay] give worker elephants an aura instead.
Mar 29 2020, 4:28 PM
Nescio retitled D890: [gameplay] Makes Military Colony stats dependent on Civic Centre from Makes Military Colony stats dependent on Civic Centre to [gameplay] Makes Military Colony stats dependent on Civic Centre.
Mar 29 2020, 4:26 PM
Nescio retitled D1365: [gameplay] Lower the repeat rate of spear cavalry from Lower the repeat rate of spear cavalry to [gameplay] Lower the repeat rate of spear cavalry.
Mar 29 2020, 4:25 PM
Nescio retitled D904: [gameplay] Themistocle aura 1 modify from Themistocle aura 1 modify to [gameplay] Themistocle aura 1 modify.
Mar 29 2020, 4:25 PM
Silier added inline comments to D2511: [gameplay] give worker elephants an aura instead.
Mar 29 2020, 2:51 PM
Silier accepted D2665: Explicitly return "undefined" when requesting Splash data in Attack.js..

Compared to other occurrences in code base, it makes sense to return undefined rather then just empty return.

Mar 29 2020, 2:41 PM
Silier added inline comments to D2667: Upgrade engine to handle up to 30 players.
Mar 29 2020, 2:08 PM
Harbormaster failed remote builds in B11374: Diff 11601 for D2614: Also store turret position in map file.!
Mar 29 2020, 1:42 PM
Vulcan added a comment to D2614: Also store turret position in map file..

Build failure - The Moirai have given mortals hearts that can endure.

Mar 29 2020, 1:42 PM
Vulcan added a comment to D2614: Also store turret position in map file..

Successful build - Chance fights ever on the side of the prudent.

Mar 29 2020, 1:23 PM
Silier added a comment to D2667: Upgrade engine to handle up to 30 players.

Aside from this I got idea how this could be unlimited number of players.
You would need to store inside PlayerData an array of m_data and work with the value based on index you get.
Lets say you store m_data as u32. So if you get index 0 - 16 you get first item from array. If you get index from 17 - 32 you get second item from array and substract 16 from index.

Mar 29 2020, 1:19 PM
Silier requested changes to D2667: Upgrade engine to handle up to 30 players.
Mar 29 2020, 1:10 PM
Freagarach updated the diff for D2614: Also store turret position in map file..

Working version :)

Mar 29 2020, 12:57 PM
ValihrAnt abandoned D2605: [gameplay] Fix loot oversights.
Mar 29 2020, 12:06 PM
Freagarach updated the diff for D2614: Also store turret position in map file..
Mar 29 2020, 11:40 AM

Mar 28 2020

nephele added a comment to D2671: Build: include libexecinfo on musl system.

Alright, i can move the test to line 92 cache the result and then retest. (with apropriate comments)

Mar 28 2020, 7:45 PM
Itms added a comment to D2671: Build: include libexecinfo on musl system.

Else at the very least I'd prefer to test the need for execinfo once at the beginning, so that we don't have calls to the compiler in the middle of our (already complex) prebuild logic.

Why would it matter?

Mar 28 2020, 7:42 PM
nephele added a comment to D2671: Build: include libexecinfo on musl system.

Would it be easy to detect musl?

No, it wouldn't, and detecting musl does not seem desireable either since the libc is supposed to be useable anyway.
We basically only need to figure out if the symbol is available in the system libc or not, which this test does.

Mar 28 2020, 7:38 PM
Itms added a comment to D2671: Build: include libexecinfo on musl system.

I see. In that case I suppose this is OK (I find it rather ugly but that's personal taste).

Mar 28 2020, 7:34 PM
nephele added a comment to D2671: Build: include libexecinfo on musl system.

and waiting for the test compilation would slow down the pre-build process.

Atleast for my (by now low-to-medium end) system it's a negligable ammount of time.

Mar 28 2020, 7:19 PM
Itms requested changes to D2671: Build: include libexecinfo on musl system.

Hi! Thanks for your contribution.

Mar 28 2020, 7:09 PM
Stan added inline comments to D2667: Upgrade engine to handle up to 30 players.
Mar 28 2020, 7:09 PM
nani updated the diff for D2667: Upgrade engine to handle up to 30 players.
Mar 28 2020, 7:03 PM
nani added inline comments to D2667: Upgrade engine to handle up to 30 players.
Mar 28 2020, 7:00 PM
Itms requested changes to D2613: Updated cppformat.

Thanks for the rebase @s0600204! Jenkins is indeed broken when source files are deleted (or moved) but there is still a build error on a clean build due to the test file.

Mar 28 2020, 6:52 PM
Vulcan added a comment to D880: Ballistics..

Build failure - The Moirai have given mortals hearts that can endure.

Mar 28 2020, 5:30 PM
Vulcan added a comment to D880: Ballistics..

Build failure - The Moirai have given mortals hearts that can endure.

Mar 28 2020, 5:29 PM
Harbormaster failed remote builds in B9718: Diff 10072 for D880: Ballistics.!
Mar 28 2020, 5:29 PM
Vulcan added a comment to D880: Ballistics..

Build failure - The Moirai have given mortals hearts that can endure.

Mar 28 2020, 5:29 PM
Freagarach commandeered D880: Ballistics..
Mar 28 2020, 5:28 PM
Freagarach updated the diff for D880: Ballistics..

Different approach.

Mar 28 2020, 5:28 PM
Freagarach added a comment to D2676: Move common functionality of Foundation and Repairable to Buildable..

(I still think constructing a building should not necessarily be tied to Health.)

Mar 28 2020, 4:03 PM
Stan abandoned D1198: Add JSdoc to AuraManager.
Mar 28 2020, 1:41 PM
Stan added a reviewer for D1636: Dune random map.: Restricted Owners Package.
Mar 28 2020, 1:41 PM
Stan added a reviewer for D2642: Contrast-Adaptiv-Sharpening pass: vladislavbelov.
Mar 28 2020, 1:40 PM
Stan added a reviewer for D2479: Add thread names on Linux: vladislavbelov.
Mar 28 2020, 1:39 PM
Stan added a reviewer for D2671: Build: include libexecinfo on musl system: Itms.

Itms said this was not the correct way to do, it I'll let him explain why.

Mar 28 2020, 1:38 PM
Vulcan added a comment to D2611: [gameplay] make wall segment cost proportional.

Successful build - Chance fights ever on the side of the prudent.

Mar 28 2020, 10:54 AM
Vulcan added a comment to D2611: [gameplay] make wall segment cost proportional.

Successful build - Chance fights ever on the side of the prudent.

Mar 28 2020, 10:50 AM
Nescio updated the diff for D2611: [gameplay] make wall segment cost proportional.
Mar 28 2020, 10:47 AM
Feldfeld added a comment to D2596: [gameplay] unify Cavalry walk speeds.

It looks good to me. Only small grey area for me is that citizen cavalry is slightly faster as a result (x1.95 to x2.0) but at this point it's just nitpicking, I don't think it will have noticeable effect to balance.

Mar 28 2020, 10:47 AM
Nescio updated the diff for D2611: [gameplay] make wall segment cost proportional.

Updated because of rP23559/D2659.

Mar 28 2020, 10:46 AM
Vulcan added a comment to D2687: [gameplay] tweak gate cost.

Successful build - Chance fights ever on the side of the prudent.

Mar 28 2020, 10:40 AM
Vulcan added a comment to D2687: [gameplay] tweak gate cost.

Successful build - Chance fights ever on the side of the prudent.

Mar 28 2020, 10:36 AM
Nescio updated subscribers of D2596: [gameplay] unify Cavalry walk speeds.

@Feldfeld, any opinions on this?

Mar 28 2020, 10:36 AM
Feldfeld updated subscribers of D2640: adjust trader footprints.

I personally have nothing against this, I think a slight imbalance between traders will not change much there. Can ask @ValihrAnt just in case.

Mar 28 2020, 10:34 AM
Nescio updated the diff for D2687: [gameplay] tweak gate cost.

forgot maur gate loot

Mar 28 2020, 10:34 AM
Nescio created D2687: [gameplay] tweak gate cost.
Mar 28 2020, 10:31 AM
Silier updated subscribers of D2640: adjust trader footprints.

@Feldfeld anything against? If yes do we agree that camel traders need to have the same footprint, one or another?

Mar 28 2020, 10:19 AM
Nescio added inline comments to D2660: [gameplay] standardize wonder healing.
Mar 28 2020, 10:18 AM
Vulcan added a comment to D2660: [gameplay] standardize wonder healing.

Successful build - Chance fights ever on the side of the prudent.

Mar 28 2020, 10:16 AM
Nescio added a comment to D2496: tweak soldier footprints.

For what's it worth, I believe I ran a few AI vs AI test games when I proposed this patch in December, and didn't notice any difference. Cavalry footprint area is still much larger than that of Infantry, footprint length is unchanged, and Structure attack spread is typically low.
You can implement the patch with arc patch D2496 and try it out yourself.

Mar 28 2020, 10:16 AM
Nescio updated the diff for D2660: [gameplay] standardize wonder healing.
  • garrison heal to 5 (temples have 3)
  • garrison capacity from 30 to 50 (temples have 20)
  • garrison classes to Support or Soldier, which means you can also garrison war elephants inside (worker elephants were already possible)
Mar 28 2020, 10:12 AM
Vulcan added a comment to D2686: [gameplay] tweak pyramids and wonder costs and auras.

Successful build - Chance fights ever on the side of the prudent.

Mar 28 2020, 10:09 AM
Feldfeld added a comment to D2532: [gameplay] train champion cavalry at stable.

I have nothing against this patch, in the current state of the game it would do no harm, but i would like to note that if we are in a situation where champions are balanced and viable then suddenly persians would become (by far i think) the civ who would be able to spam them the fastest entering city phase and it could become a problem in that case.

Mar 28 2020, 10:06 AM
Nescio created D2686: [gameplay] tweak pyramids and wonder costs and auras.
Mar 28 2020, 10:01 AM
Feldfeld added a comment to D2496: tweak soldier footprints.

I also think it might affect balance. Here it is not the balance between civs but the balance between units which is also important (to compare, right now champions aren't really viable compared to citizen soldier which is a problem). If cav become harder to hit it would buff them. Now i don't know if this patch actually noticeably changes balance or not, but to me it would be the kind of patch that could use some testing to be on the safe side of things.
If it does affect balance but we still want that patch then maybe cavalry would have to be nerfed in some other stats.

Mar 28 2020, 9:55 AM
Feldfeld accepted D2511: [gameplay] give worker elephants an aura instead.
Mar 28 2020, 9:46 AM
Nescio added inline comments to rP23558: Remove deprecated variants from Brit structures actors..
Mar 28 2020, 9:32 AM
Nescio added a comment to D2605: [gameplay] Fix loot oversights.

This patch is practically superseded by D2659/rP23559 (thanks, Angen). Maybe it should be abandoned/closed, or replaced with a different differential?

Mar 28 2020, 9:29 AM
Nescio added a comment to D2530: [art/actors] change pers_cavalry_archer_* actor.

Is there another differential for the Seleucid Cavalry Javelinist? It's also a Persian unit.

Is it? It looks like ordinary Greek cavalry. Maybe you're confused with something else?

I know I am late to the game, but I agree with making the Scythe Chariot into a champion for the Persians. I already did this over a year ago for the Persians in Delenda Est.

This patch already changed it into a champion; it's just not trainable yet, because that would be a gameplay balance change, but there is a patch available for that. And yeah, I already did that in my 0abc mod long ago.
Feel free to propose patches for uncontroversial improvements you made in Delenda Est (e.g. art corrections), so they can be incorporated into the public folder. That'll make your mod smaller to download and easier to maintain in the long run; besides, the default game and other mods can also benefit.

Mar 28 2020, 9:26 AM
Freagarach added inline comments to rP18467: Allow entities to upgrade into other entities..
Mar 28 2020, 8:13 AM

Mar 27 2020

Silier added a comment to D2667: Upgrade engine to handle up to 30 players.

some more comments

Mar 27 2020, 11:41 PM
Silier accepted rP23558: Remove deprecated variants from Brit structures actors..

Fixed in rP23560

Mar 27 2020, 9:37 PM
Stan requested verification of rP23558: Remove deprecated variants from Brit structures actors..
Mar 27 2020, 9:32 PM
Stan committed rP23560: Fix missing <group> tag in rP23558.
Fix missing <group> tag in rP23558
Mar 27 2020, 9:32 PM
Silier raised a concern with rP23558: Remove deprecated variants from Brit structures actors..
Mar 27 2020, 9:26 PM
Harbormaster failed to build B11363: rP23559: [gameplay-a24] Standardize structure loot to 20% for rP23559: [gameplay-a24] Standardize structure loot to 20%!
Mar 27 2020, 9:18 PM
Silier committed rP23559: [gameplay-a24] Standardize structure loot to 20%.
[gameplay-a24] Standardize structure loot to 20%
Mar 27 2020, 9:14 PM
Silier closed D2659: [gameplay] standardize structure loot.
Mar 27 2020, 9:14 PM
Harbormaster failed to build B11362: rP23558: Remove deprecated variants from Brit structures actors. for rP23558: Remove deprecated variants from Brit structures actors.!
Mar 27 2020, 9:09 PM
Stan committed rP23558: Remove deprecated variants from Brit structures actors..
Remove deprecated variants from Brit structures actors.
Mar 27 2020, 9:03 PM
Stan closed D2633: [art/actors] remove frequency="0" variants from brit structure actors.
Mar 27 2020, 9:03 PM
Freagarach added a comment to D2679: Remove unnecessary argument of Pack-timer..

Thanks for the commit @Angen :)

Mar 27 2020, 9:02 PM
Silier committed rP23557: Remove unnecessary arguments in Pack.js.
Remove unnecessary arguments in Pack.js
Mar 27 2020, 9:00 PM
Silier closed D2679: Remove unnecessary argument of Pack-timer..
Mar 27 2020, 9:00 PM
Stan accepted D2633: [art/actors] remove frequency="0" variants from brit structure actors.

I'll fix the S when committing, thanks for the patch.

Mar 27 2020, 9:00 PM
Silier committed rP23556: Standardizes formating style of aura json files.
Standardizes formating style of aura json files
Mar 27 2020, 8:55 PM
Silier closed D2000: aura style corrections.
Mar 27 2020, 8:55 PM
OptimusShepard added a comment to rP23484: Adds anti-aliasing option with FXAA algorithm..
In rP23484#41603, @Stan wrote:

FXAA doesn't work on my linux system. On dual boot Windows it's working.
Manjaro 64Bit, Radeon RX 570

Same map? It doesn't work on all maps if postprocessing is disabled on the map settings...

Mar 27 2020, 8:29 PM
Stan added a comment to rP23484: Adds anti-aliasing option with FXAA algorithm..

FXAA doesn't work on my linux system. On dual boot Windows it's working.
Manjaro 64Bit, Radeon RX 570

Mar 27 2020, 8:24 PM